Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
gnodet commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590556633 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -81,6 +81,24 @@ public interface Type extends ExtensibleEnum { */ String MODULAR_JAR =

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
gnodet commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590556560 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -81,6 +81,24 @@ public interface Type extends ExtensibleEnum { */ String MODULAR_JAR =

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
gnodet commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590556427 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -81,6 +81,24 @@ public interface Type extends ExtensibleEnum { */ String MODULAR_JAR =

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590440306 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.Documenta

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590433117 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -63,16 +75,17 @@ public enum JavaPathType implements PathType { * class

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590432902 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -187,31 +247,38 @@ public Optional option() { * * @param paths the path

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590432486 ## api/maven-api-core/src/main/java/org/apache/maven/api/PathType.java: ## @@ -94,23 +94,24 @@ public String option(Iterable paths) { * The path elements are s

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
gnodet commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590366917 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -63,16 +75,17 @@ public enum JavaPathType implements PathType { * class-path.

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
rmannibucau commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590346155 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.Documentat

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-05 Thread via GitHub
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590282082 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.Documenta

Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-04 Thread via GitHub
rmannibucau commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590207944 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.Documentat

[PR] Adjustments in new API related to PathType [maven]

2024-05-04 Thread via GitHub
desruisseaux opened a new pull request, #1501: URL: https://github.com/apache/maven/pull/1501 This pull request makes the following changes in API related to `PathType`. Those changes are for supporting the development of the Maven compiler plugin: * Add new artifact types for annotat