desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590440306
########## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ########## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.DocumentationTool; Review Comment: "Java" here refers to standard Java as defined by Oracle (other entities must use other names, e.g. "Jakarta"). The use of standard `javax.tools` API should not block non-standard Java tools to be added to this `JavaPathType` enumeration if desired, because `Location` is an interface with 2 non-default methods easy to implement (`getName()` and `isOutputLocation()`), and the proposed `JavaPathType.location()` property is `Optional` anyway. The close connection to `javax.tools` API may actually be desirable because contrarily to other API, `javax.tools` is updated immediately when new Java features requires compiler changes. For example, `javax.tools` has been updated in Java 9 with the addition of new methods specific to modules management. By contrast, Maven and the Plexus compiler did not really reflected that evolution as far as I can see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
