desruisseaux commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590432902
##########
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##########
@@ -187,31 +247,38 @@ public Optional<String> option() {
*
* @param paths the path to format as a tool option
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element
+ * or an empty array if there is no path element
* @throws IllegalStateException if no option is associated to this path
type
*/
@Nonnull
@Override
- public String option(Iterable<? extends Path> paths) {
+ public String[] option(Iterable<? extends Path> paths) {
Review Comment:
The presence or not of this method depends on the [comment
below](https://github.com/apache/maven/pull/1501#discussion_r1590432486).
##########
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##########
@@ -187,31 +247,38 @@ public Optional<String> option() {
*
* @param paths the path to format as a tool option
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element
+ * or an empty array if there is no path element
* @throws IllegalStateException if no option is associated to this path
type
*/
@Nonnull
@Override
- public String option(Iterable<? extends Path> paths) {
+ public String[] option(Iterable<? extends Path> paths) {
return format(null, paths);
}
/**
* Implementation shared with {@link Modular}.
*/
- String format(String moduleName, Iterable<? extends Path> paths) {
+ final String[] format(String moduleName, Iterable<? extends Path> paths) {
Review Comment:
The presence or not of this method depends on the [comment
below](https://github.com/apache/maven/pull/1501#discussion_r1590432486).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
