elharo merged PR #196:
URL: https://github.com/apache/maven-release/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.ap
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1883913424
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractScmCommitPhase.java:
##
@@ -288,11 +303,25 @@ protected static List
createPomFi
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1883813971
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractScmCommitPhase.java:
##
@@ -288,11 +303,25 @@ protected static List
createPomFi
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1883525657
##
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##
@@ -2452,6 +2453,9 @@ private static MavenProject createPr
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1882003514
##
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##
@@ -2447,11 +2448,44 @@ public void
testUpdateDevelopment
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1882002284
##
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##
@@ -2452,6 +2453,9 @@ private static MavenProject createPr
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1877095588
##
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##
@@ -2452,6 +2453,9 @@ private static MavenProject createPr
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1876862759
##
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##
@@ -2452,6 +2453,9 @@ private static MavenProject createPr
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1438995411
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -39,6 +43,7 @@
import org.apache.maven.shared.rele
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1432644313
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -199,13 +213,18 @@ private void transform(
wuwen5 commented on PR #196:
URL: https://github.com/apache/maven-release/pull/196#issuecomment-1864331769
@elharo I have addressed the issues you pointed out, and I kindly request
you to review the modified code. If you have any further suggestions or if
there are additional changes neede
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1432603322
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -39,6 +43,7 @@
import org.apache.maven.shared.rele
wuwen5 commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1432603322
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -39,6 +43,7 @@
import org.apache.maven.shared.rele
13 matches
Mail list logo
