rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891626872
> I don't mix anything, but that's actually the point, now the producer is
forced to set something so it stays as before, because consumers before have
never complained obvi
laeubi commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891564489
> You mix two things there: the producer and consumer sides. There is no
change for consumers (users), it only changes the way the producer sets the
prefix.
I don't mix an
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891553087
> So for (1) it seems a lot of users where happy with that
I assume you mean for tycho case but it is really done under the carpet so
50-50 IMHO (implicit case is actu
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891520373
@laeubi ok, so if I rephrase the questions are IMHO:
1. Do we want to let people go a prefix they didn't anticipate since it will
fully be part of the exposed UI to th
laeubi commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891513101
> The fix is always trivial: grab your last release read your plugin.xml and
just configure it to be aligned.
This recommendation together with this fact
> if the a
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891500550
> Especially it seems that two projects (tycho+apache-rat) that are using
the convention -plugin getting the same resulting prefix (==
) so it can't be that random
laeubi commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891431842
> I'm not sure cause no it cant happen. You can get conflicts but no
surprise nor wrong behavior if explicit compared to an almost random heuristic.
Until now no one could
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891408990
@laeubi well I'm not sure cause no it cant happen. You can get conflicts but
no surprise nor wrong behavior if explicit compared to an almost random
heuristic.
Alternativ
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891047013
> I don't see any issue that can arise from the default (beside that the
prefix is maybe longer than one wants) but why enforce it to specify what the
plugin was able to dec
rmannibucau commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891041901
> I also see some risk that different plugins now they are forced to, choose
some prefix that clashes in the name.
AFAIK it always had been the case, the heuristic alw
michael-o commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891039908
> @gnodet the JIRA mentions
>
> > but we may want to have some option to turn off this feature
>
> but it seems there is no such option as far as I can see?
>
cstamas commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1886718724
According to doco it is `apache-rat`, yes:
https://creadur.apache.org/rat/apache-rat-plugin/index.html
--
This is an automated message from the Apache Git Service.
To respond
ottlinger commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1886714970
> I guess @ottlinger will use now:
>
> ```
> rat
> ```
h - I thought apache-rat or do I misinterpret what the goal-prefix is? I
thought it is a fully q
alexsuter commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1886698205
I guess @ottlinger will use now:
```
rat
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cstamas commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1886689266
https://maven.apache.org/plugin-tools/maven-plugin-plugin/helpmojo-mojo.html#goalPrefix
In short, just add this to maven-plugin-plugin configuration:
```
foo
``
ottlinger commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1886686937
Same with me - https://github.com/apache/creadur-rat/pull/190
As a consumer of the api I need to specify my own goal-prefix, right?
--
This is an automated message from th
alexsuter commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1886680728
Updating to the last version breaks my plugin builds and I don't know what
needs to be specified for goalPrefix. I also can not find good documentation
for it.
--
This
gnodet merged PR #240:
URL: https://github.com/apache/maven-plugin-tools/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mav
michael-o commented on PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1869076332
@gnodet Please go ahead: squash, rebase and merge. I will take care of the
next minor release.
--
This is an automated message from the Apache Git Service.
To respond to the
michael-o commented on code in PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393124464
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExec
gnodet commented on code in PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393117919
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecuti
michael-o commented on code in PR #240:
URL:
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393074122
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExec
gnodet closed pull request #239: [MPLUGIN-450] Require goalPrefix to be valid
URL: https://github.com/apache/maven-plugin-tools/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
23 matches
Mail list logo
