rmannibucau commented on PR #240: URL: https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891626872
> I don't mix anything, but that's actually the point, now the producer is forced to set something so it stays as before, because consumers before have never complained obviously that they want some change. I don't understand what you mean, I read it like "because [consumers] are not impacted they would have to be impacted", so not sure the point. The key in what you said is _now the producer is forced to set something so it stays as before_ which is exactly that, keep in mind part of the producers were not controlling at all that part and another part were setting invalid values so overall validating it the hard way is the safest solution for maven and we keep backward compatibility for consumers by explaining the producer to set the goal prefix so nobody is broken. > So neither producer nor consumer requested for such feature / change Isn't it always the case when there was a design issue in a tool and it gets fixed? Nobody asked to configure a filter for RMI serialization, it is the same there. > e.g. for the tycho case I now need to add 24 useless duplication in the config that was previously perfectly derived without a problem and users never where unhappy enough to open an issue > 10 years: on the user point please see previous comment, it is *normal* they never complained since this fix does *not* impact them > https://github.com/eclipse-tycho/tycho/pull/3363/files Looks good and now you control your produced plugin and you will not break your command lines (ci) even if you refactor your gav to comply to maven recommended pattern (x-maven-plugin, not x-plugin), this sounds way better to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
