laeubi commented on PR #240: URL: https://github.com/apache/maven-plugin-tools/pull/240#issuecomment-1891431842
> I'm not sure cause no it cant happen. You can get conflicts but no surprise nor wrong behavior if explicit compared to an almost random heuristic. Until now no one could give an example of "random" behavior, so can you show where this random part happen? For me it was (and is) completely deterministic as for each given input it always gives the same output. Especially it seems that two projects (`tycho`+`apache-rat`) that are using the convention `<projectname>-plugin` getting the same resulting prefix (== `<projectname>` ) so it can't be _that_ random.... It was simply assumed (what obviously is wrong) that: 1. goal prefix is optional, but "good to have" --> actually goal prefix was always present, so only explicitly specify it was optional) 2. Cases when is not present, is when heuristics fails (so plugin module is not named as "xxx-maven-plugin" or "maven-xxx-plugin") --> also "xxx-plugin" works fine before, as well as even xxx as artifact id 3. The cases when prefix is not present is mostly unintentional --> the new behavior does not fail/war/... in cases there is no prefix, as obviously tycho+rat have a prefix successfully derived but now fail So obviously the assumption that anything that do not matches `*-maven-plugin` `*-maven-plugin` got **no prefix** is wrong, you never get an empty prefix as claimed in the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
