Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-19 Thread via GitHub
cstamas merged PR #1384: URL: https://github.com/apache/maven/pull/1384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-19 Thread via GitHub
cstamas commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1458691354 ## api/maven-api-core/src/main/java/org/apache/maven/api/Session.java: ## @@ -55,23 +56,32 @@ public interface Session { SessionData getData(); /** - * Ge

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-19 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1458557440 ## api/maven-api-core/src/main/java/org/apache/maven/api/Session.java: ## @@ -55,23 +56,32 @@ public interface Session { SessionData getData(); /** - * Get

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-18 Thread via GitHub
cstamas commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1457526016 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-18 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1457524210 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -133,4 +134,10 @@ default String getId() { @Nonnull List getRemotePluginRepositori

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-18 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1457522507 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/Properties.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-18 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1457520316 ## api/maven-api-core/src/main/java/org/apache/maven/api/Session.java: ## @@ -73,15 +74,12 @@ public interface Session { Map getSystemProperties(); /** - *

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-18 Thread via GitHub
cstamas commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1457521519 ## api/maven-api-core/src/main/java/org/apache/maven/api/Session.java: ## @@ -73,15 +74,12 @@ public interface Session { Map getSystemProperties(); /** -

Re: [PR] [MNG-8006] SPI to contribute to effective properties and more [maven]

2024-01-18 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1457519372 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -133,4 +134,10 @@ default String getId() { @Nonnull List getRemotePluginRepositori