gnodet commented on code in PR #1384:
URL: https://github.com/apache/maven/pull/1384#discussion_r1458557440
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Session.java:
##########
@@ -55,23 +56,32 @@ public interface Session {
SessionData getData();
/**
- * Gets the user properties to use for interpolation. The user properties
have been configured directly by the user,
- * e.g. via the {@code -Dkey=value} parameter on the command line.
+ * Returns immutable user properties to use for interpolation. The user
properties have been configured directly
+ * by the user, e.g. via the {@code -Dkey=value} parameter on the command
line.
*
* @return the user properties, never {@code null}
*/
@Nonnull
Map<String, String> getUserProperties();
/**
- * Gets the system properties to use for interpolation. The system
properties are collected from the runtime
- * environment such as {@link System#getProperties()} and environment
variables.
+ * Returns immutable system properties to use for interpolation. The
system properties are collected from the
+ * runtime environment such as {@link System#getProperties()} and
environment variables.
*
* @return the system properties, never {@code null}
*/
@Nonnull
Map<String, String> getSystemProperties();
+ /**
+ * Each invocation computes a new map of effective properties. To be used
in interpolation.
Review Comment:
I think we need to explain here what "effective properties" are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
