Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
gnodet merged PR #1270: URL: https://github.com/apache/maven/pull/1270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
sebastien-doyon commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1367046791 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -103,13 +117,9 @@ protected String getLocation(final StackTraceElement e) {

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
sebastien-doyon commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1367045641 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -103,13 +117,9 @@ protected String getLocation(final StackTraceElement e) {

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
sebastien-doyon commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1367034601 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/MessageBuilder.java: ## @@ -206,4 +206,11 @@ public interface MessageBuilder { */ @No

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
gnodet commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1366758647 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -103,13 +117,9 @@ protected String getLocation(final StackTraceElement e) { } e

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
gnodet commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1366754120 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/MessageBuilder.java: ## @@ -206,4 +206,11 @@ public interface MessageBuilder { */ @Nonnull

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-20 Thread via GitHub
sebastien-doyon commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1366679339 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -30,6 +29,14 @@ * @since 3.5.0 */ public class MavenSimpleLogger extends S

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-19 Thread via GitHub
sebastien-doyon commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1365467245 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -30,6 +29,14 @@ * @since 3.5.0 */ public class MavenSimpleLogger extends S

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-19 Thread via GitHub
sebastien-doyon commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1365453818 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -71,8 +78,13 @@ private void printStackTrace(Throwable t, PrintStream stream,

Re: [PR] [MNG-7899] Various memory usage improvements 5 [maven]

2023-10-19 Thread via GitHub
gnodet commented on code in PR #1270: URL: https://github.com/apache/maven/pull/1270#discussion_r1365012668 ## maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java: ## @@ -71,8 +78,13 @@ private void printStackTrace(Throwable t, PrintStream stream, String pr