sebastien-doyon commented on code in PR #1270:
URL: https://github.com/apache/maven/pull/1270#discussion_r1367045641
##########
maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java:
##########
@@ -103,13 +117,9 @@ protected String getLocation(final StackTraceElement e) {
} else if (e.getFileName() == null) {
return "Unknown Source";
} else if (e.getLineNumber() >= 0) {
- return String.format("%s:%s", e.getFileName(), e.getLineNumber());
+ return e.getFileName() + ":" + e.getLineNumber();
Review Comment:
I think it is not worth the trouble, in the case where the getLocation
method would concatenate the file name and the lin e number, we would need to
surround `e.getFileName() + ":" + e.getLineNumber()` with the strong style,
separately or with a style set and reset. I see no support for that in the
current implementation (style set/reset).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
