gnodet commented on code in PR #1270:
URL: https://github.com/apache/maven/pull/1270#discussion_r1366758647
##########
maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java:
##########
@@ -103,13 +117,9 @@ protected String getLocation(final StackTraceElement e) {
} else if (e.getFileName() == null) {
return "Unknown Source";
} else if (e.getLineNumber() >= 0) {
- return String.format("%s:%s", e.getFileName(), e.getLineNumber());
+ return e.getFileName() + ":" + e.getLineNumber();
Review Comment:
Shouldn't we go further and pass the message builder as an argument to avoid
concatenating strings here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
