Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

2024-01-24 Thread via GitHub
hboutemy merged PR #190: URL: https://github.com/apache/maven-jlink-plugin/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

2024-01-23 Thread via GitHub
hboutemy commented on code in PR #190: URL: https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File outputDirectory, File ou

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

2024-01-23 Thread via GitHub
hboutemy commented on code in PR #190: URL: https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463035542 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File outputDirectory, File ou

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

2024-01-23 Thread via GitHub
hboutemy commented on code in PR #190: URL: https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File outputDirectory, File ou

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

2024-01-22 Thread via GitHub
bmarwell commented on code in PR #190: URL: https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1462839170 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File outputDirectory, File ou