Re: [PR] Bump org.junit.jupiter:junit-jupiter from 5.13.0 to 5.13.1 [maven-verifier]

2025-06-08 Thread via GitHub
Bukama merged PR #108: URL: https://github.com/apache/maven-verifier/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-08 Thread via GitHub
adangel commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2135111740 ## pom.xml: ## @@ -816,6 +824,10 @@ under the License. + +org.apache.maven.plugins +maven-pmd-plugin + Review Comment:

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-08 Thread via GitHub
adangel commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2135104993 ## .pmd/ruleset.xml: ## @@ -0,0 +1,27 @@ + + + strange that its not detected: > > is this: > > * supposed to be like this? > > * any good?

[PR] Bump org.junit.jupiter:junit-jupiter from 5.13.0 to 5.13.1 [maven-verifier]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/maven-verifier/pull/108 Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>o

Re: [PR] Remove references to Jira [maven-site]

2025-06-08 Thread via GitHub
olamy commented on code in PR #812: URL: https://github.com/apache/maven-site/pull/812#discussion_r2135060479 ## content/apt/developers/release/maven-project-release-procedure.apt: ## @@ -130,10 +128,7 @@ Subject: [VOTE] Release Apache Maven XXX Plugin version Y.Z Hi, We sol

Re: [PR] Remove references to Jira [maven-site]

2025-06-08 Thread via GitHub
olamy commented on code in PR #812: URL: https://github.com/apache/maven-site/pull/812#discussion_r2135058542 ## content/apt/developers/conventions/git.apt: ## @@ -181,7 +172,7 @@ $ git checkout . --- git clone https://github.com//maven-surefire.git -git remote add apache h

Re: [PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-install-plugin]

2025-06-08 Thread via GitHub
Bukama merged PR #351: URL: https://github.com/apache/maven-install-plugin/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-plugin-testing]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/maven-plugin-testing/pull/106 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.juni

Re: [PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven]

2025-06-08 Thread via GitHub
Bukama merged PR #2459: URL: https://github.com/apache/maven/pull/2459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[PR] Remove references to Jira [maven-site]

2025-06-08 Thread via GitHub
olamy opened a new pull request, #812: URL: https://github.com/apache/maven-site/pull/812 - **Remove Jira references** - **remove more references to Jira** Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should

Re: [PR] Bump org.junit.jupiter:junit-jupiter from 5.13.0 to 5.13.1 [maven]

2025-06-08 Thread via GitHub
Bukama merged PR #2460: URL: https://github.com/apache/maven/pull/2460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[PR] Bump maven3Version from 3.9.9 to 3.9.10 [maven-resolver]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #741: URL: https://github.com/apache/maven-resolver/pull/741 Bumps `maven3Version` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-resolver-provider` from 3.9.9 to 3.9.10 Updates `org.apache.maven:maven-model-builder` from 3.9.9 to 3.

Re: [PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-jar-plugin]

2025-06-08 Thread via GitHub
Bukama merged PR #147: URL: https://github.com/apache/maven-jar-plugin/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven

Re: [PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-jlink-plugin]

2025-06-08 Thread via GitHub
Bukama merged PR #612: URL: https://github.com/apache/maven-jlink-plugin/pull/612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[I] When will JDK21 be supported? [maven-mvnd]

2025-06-08 Thread via GitHub
390237 opened a new issue, #1350: URL: https://github.com/apache/maven-mvnd/issues/1350 ### New feature, improvement proposal When will JDK21 be supported? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-jlink-plugin]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #612: URL: https://github.com/apache/maven-jlink-plugin/pull/612 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.junit:

[PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-jar-plugin]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #147: URL: https://github.com/apache/maven-jar-plugin/pull/147 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.junit:ju

[I] two Java projects with the same pom configuration and modules.'mvnd clean package' in the second project will result in an error [maven-mvnd]

2025-06-08 Thread via GitHub
F-T-Jen opened a new issue, #1349: URL: https://github.com/apache/maven-mvnd/issues/1349 ### Affected version Apache Maven Daemon (mvnd) 1.0-m7 windows-amd64 native client (b2ef5d81997adbcdb72dc8c5603722538fa641fe) ### Bug description There are two Java projects with the

[PR] Bump org.junit.jupiter:junit-jupiter from 5.13.0 to 5.13.1 [maven]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #2460: URL: https://github.com/apache/maven/pull/2460 Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.juni

[PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #2459: URL: https://github.com/apache/maven/pull/2459 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.junit:junit-bom's

Re: [PR] Bump minaSshdVersion from 2.11.0 to 2.15.0 [maven-scm]

2025-06-08 Thread via GitHub
olamy commented on PR #235: URL: https://github.com/apache/maven-scm/pull/235#issuecomment-2954379530 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump org.eclipse.jgit:org.eclipse.jgit from 5.13.3.202401111512-r to 7.2.1.202505142326-r in /maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit [maven-scm]

2025-06-08 Thread via GitHub
dependabot[bot] closed pull request #243: Bump org.eclipse.jgit:org.eclipse.jgit from 5.13.3.20240512-r to 7.2.1.202505142326-r in /maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit URL: https://github.com/apache/maven-scm/pull/243 -- This is an automated message from

Re: [PR] Bump org.eclipse.jgit:org.eclipse.jgit from 5.13.3.202401111512-r to 7.2.1.202505142326-r in /maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit [maven-scm]

2025-06-08 Thread via GitHub
dependabot[bot] commented on PR #243: URL: https://github.com/apache/maven-scm/pull/243#issuecomment-2954378792 Superseded by #245. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Bump org.eclipse.jgit:org.eclipse.jgit from 5.13.3.202401111512-r to 6.10.1.202505221210-r in /maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit [maven-scm]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #245: URL: https://github.com/apache/maven-scm/pull/245 Bumps org.eclipse.jgit:org.eclipse.jgit from 5.13.3.20240512-r to 6.10.1.202505221210-r. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compat

Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.3 to 1.4 [maven-scm]

2025-06-08 Thread via GitHub
dependabot[bot] merged PR #239: URL: https://github.com/apache/maven-scm/pull/239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.3 to 1.4 [maven-scm]

2025-06-08 Thread via GitHub
olamy commented on PR #239: URL: https://github.com/apache/maven-scm/pull/239#issuecomment-2954378680 @dependabot merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Bump org.codehaus.plexus:plexus-classworlds from 2.8.0 to 2.9.0 [maven-scm]

2025-06-08 Thread via GitHub
dependabot[bot] merged PR #240: URL: https://github.com/apache/maven-scm/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Bump org.codehaus.plexus:plexus-classworlds from 2.8.0 to 2.9.0 [maven-scm]

2025-06-08 Thread via GitHub
olamy commented on PR #240: URL: https://github.com/apache/maven-scm/pull/240#issuecomment-2954378422 @dependabot merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Bump org.apache.commons:commons-text from 1.13.0 to 1.13.1 [maven-scm]

2025-06-08 Thread via GitHub
olamy commented on PR #241: URL: https://github.com/apache/maven-scm/pull/241#issuecomment-2954378101 @dependabot merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Bump org.apache.commons:commons-text from 1.13.0 to 1.13.1 [maven-scm]

2025-06-08 Thread via GitHub
dependabot[bot] merged PR #241: URL: https://github.com/apache/maven-scm/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[PR] Bump org.junit:junit-bom from 5.13.0 to 5.13.1 [maven-install-plugin]

2025-06-08 Thread via GitHub
dependabot[bot] opened a new pull request, #351: URL: https://github.com/apache/maven-install-plugin/pull/351 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.13.0 to 5.13.1. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.juni

Re: [PR] chore: remove `.gitignore` obsoletes [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2439: URL: https://github.com/apache/maven/pull/2439#issuecomment-2954250129 wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] chore: remove `.gitignore` obsoletes [maven]

2025-06-08 Thread via GitHub
Pankraz76 closed pull request #2439: chore: remove `.gitignore` obsoletes URL: https://github.com/apache/maven/pull/2439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2134810657 ## .pmd/ruleset.xml: ## @@ -0,0 +1,27 @@ + + +

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134809860 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -124,7 +124,7 @@ public class MavenProject implements Cloneable { private Arti

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134809860 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -124,7 +124,7 @@ public class MavenProject implements Cloneable { private Arti

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2458: URL: https://github.com/apache/maven/pull/2458#issuecomment-2954243180 SUCCESS lets get this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134807718 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134807173 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -861,7 +861,7 @@ public void addLicense(License license) { } public void

Re: [PR] test `NPE` in `WrapperProperties#init` [maven]

2025-06-08 Thread via GitHub
Pankraz76 closed pull request #2437: test `NPE` in `WrapperProperties#init` URL: https://github.com/apache/maven/pull/2437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] chore: promote lambda `isPresent()` to `ifPresent()` in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 closed pull request #2456: chore: promote lambda `isPresent()` to `ifPresent()` in `LookupInvoker` URL: https://github.com/apache/maven/pull/2456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] test `NPE` in `WrapperProperties#init` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2437: URL: https://github.com/apache/maven/pull/2437#issuecomment-2954226689 wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] chore: promote lambda `isPresent()` to `ifPresent()` in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2456: URL: https://github.com/apache/maven/pull/2456#issuecomment-2954226672 wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] chore: promote lambda `isPresent()` to `ifPresent()` in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2456: URL: https://github.com/apache/maven/pull/2456#issuecomment-2954225890 yes. remove old boilerplate. use lambda the ultimate way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] fix: stabilize build by temp `@DisabledOnOs(MAC)` flaky tests related to `mvn3 fails to close log file properly, therefore JUnit fails to clean up as well.` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2451: URL: https://github.com/apache/maven/pull/2451#issuecomment-2954225062 agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] fix lambda handling in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
slachiewicz commented on PR #2456: URL: https://github.com/apache/maven/pull/2456#issuecomment-2954209038 please make clear what issue are you fixing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix: stabilize build by temp `@DisabledOnOs(MAC)` flaky tests related to `mvn3 fails to close log file properly, therefore JUnit fails to clean up as well.` [maven]

2025-06-08 Thread via GitHub
slachiewicz commented on PR #2451: URL: https://github.com/apache/maven/pull/2451#issuecomment-2954206066 @Pankraz76 please register issue instead of proposing to disable test. Improvements to our test suite to have reproducer are welcome. Unfortunately CI on GH is green -- This is an

Re: [PR] Update parent to 44 [maven-rar-plugin]

2025-06-08 Thread via GitHub
Bukama merged PR #127: URL: https://github.com/apache/maven-rar-plugin/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven

Re: [PR] fix: stabilize build by temp `@DisabledOnOs(MAC)` flaky tests related to `mvn3 fails to close log file properly, therefore JUnit fails to clean up as well.` [maven]

2025-06-08 Thread via GitHub
slachiewicz closed pull request #2451: fix: stabilize build by temp `@DisabledOnOs(MAC)` flaky tests related to `mvn3 fails to close log file properly, therefore JUnit fails to clean up as well.` URL: https://github.com/apache/maven/pull/2451 -- This is an automated message from the Apache G

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134770491 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: `NPE` in `MavenProject#getArtifacts` Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134770491 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [I] Maven 3.9.10 fails randomly with message: Cannot evaluate expression '${project.artifactMap}' [maven]

2025-06-08 Thread via GitHub
slawekjaranowski commented on issue #2455: URL: https://github.com/apache/maven/issues/2455#issuecomment-2954171523 I see a changes which can impact on it: - https://github.com/apache/maven/pull/1724 - https://github.com/apache/maven/pull/2345 - https://github.com/apache/maven/pull/2

Re: [I] Maven 3.9.10 fails randomly with message: Cannot evaluate expression '${project.artifactMap}' [maven]

2025-06-08 Thread via GitHub
delanym commented on issue #2455: URL: https://github.com/apache/maven/issues/2455#issuecomment-2954163079 Not the same result, but probably related: when I perform a partial build `-pl :a, :b` I get (consistently with certain projects and not at all with others) ``` [WARNING] ***

Re: [PR] fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134737851 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134737851 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134737851 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134737851 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134737851 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -877,16 +879,11 @@ public void setArtifacts(Set artifacts) { */ public Set

Re: [PR] fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134733349 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -861,7 +861,7 @@ public void addLicense(License license) { } public void

Re: [PR] Use Maven 3.9.10 for build on GitHub [maven]

2025-06-08 Thread via GitHub
slawekjaranowski merged PR #2452: URL: https://github.com/apache/maven/pull/2452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] WIP: fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2458: URL: https://github.com/apache/maven/pull/2458#issuecomment-2954127469 this should help can is small change easy to pick and evaluate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] Use GET() and PUT() instead of method() [maven-resolver]

2025-06-08 Thread via GitHub
cstamas opened a new pull request, #740: URL: https://github.com/apache/maven-resolver/pull/740 But this does not work for HEAD() that is 18+. Moreover, builder `method(String, BodyPublisher)` enforces body publisher as non-null, while the logic to stop emitting `Content-Length: 0` on

[jira] [Commented] (MPMD-412) Tests are inobviously broken due to overly broad catch clauses

2025-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956784#comment-17956784 ] ASF GitHub Bot commented on MPMD-412: - elharo commented on PR #226: URL: https://github

Re: [PR] avoid single letter variable names [maven-pmd-plugin]

2025-06-08 Thread via GitHub
slawekjaranowski commented on PR #225: URL: https://github.com/apache/maven-pmd-plugin/pull/225#issuecomment-2954104831 @elharo please take more attentions how release notes will look you should choose a proper label for PR according to changes -- This is an automated message from t

Re: [PR] [MPMD-412] Simplify stub setup by not swallowing exceptions [maven-pmd-plugin]

2025-06-08 Thread via GitHub
elharo commented on PR #226: URL: https://github.com/apache/maven-pmd-plugin/pull/226#issuecomment-2954104700 Previously we were suppressing the exception with an empty catch block. This seems to have hidden failures in existing tests. With PR we are no longer hiding such failures -- Thi

Re: [I] Documentation incorrect around maven version compatibility for custom rules using injection [maven-enforcer]

2025-06-08 Thread via GitHub
slawekjaranowski commented on issue #369: URL: https://github.com/apache/maven-enforcer/issues/369#issuecomment-2954096998 we have documentation about custom rules: https://maven.apache.org/enforcer/enforcer-api/writing-a-custom-rule.html there is: > Target bytecode versi

Re: [I] JDK transport issue with jitpack.io [maven-resolver]

2025-06-08 Thread via GitHub
vorburger commented on issue #739: URL: https://github.com/apache/maven-resolver/issues/739#issuecomment-2954092979 Wow! Great debugging & nice find. And... mental note to self to use Apache HttpComponents (or OkHTTP) over JDK elsewhere! I can (of course) reproduce it with your `curl`

Re: [I] JDK transport issue with jitpack.io [maven-resolver]

2025-06-08 Thread via GitHub
cstamas commented on issue #739: URL: https://github.com/apache/maven-resolver/issues/739#issuecomment-2954089591 Interestingly, similar thing may happen with HTTP HEAD as well, as `HttpREquest.Builder.HEAD` has this: ```java default Builder HEAD() { return m

Re: [PR] WIP: fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2458: URL: https://github.com/apache/maven/pull/2458#issuecomment-2954089704 yes, first fix then cherry pick. was wondering how its done anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] JDK transport issue with jitpack.io [maven-resolver]

2025-06-08 Thread via GitHub
cstamas commented on issue #739: URL: https://github.com/apache/maven-resolver/issues/739#issuecomment-2954087062 Found it: jitpack.io craps out on this request: ``` $ curl -v --http1.1 -H "Content-Length: 0" \ -H "Host: jitpack.io" \ -H "User-Agent: Apache-Maven/4.0.0-rc-

Re: [PR] WIP: fix: Maven 3.9.10 fails randomly with message: Cannot evaluate expression `${project.artifactMap}` [maven]

2025-06-08 Thread via GitHub
slawekjaranowski commented on PR #2458: URL: https://github.com/apache/maven/pull/2458#issuecomment-2954083769 @Pankraz76 please consider that issue is reported for Maven 3.9.10 version. You are trying resolve it on master branch - so will be targeted for 4.x version for Maven 3.9.

Re: [I] Maven 4.0.0-rc-3 fails with HTTP 500 when downloading from JitPack (but Maven 3.9.10 is fine, and it's fully reproducible, and not a transient server error) [maven]

2025-06-08 Thread via GitHub
cstamas commented on issue #2454: URL: https://github.com/apache/maven/issues/2454#issuecomment-2954075239 Thanks for reporting this! I confirm and reproduced it. Created https://github.com/apache/maven-resolver/issues/739 You can circumvent it by using `-Dmaven.resolver.transport=apa

[jira] [Closed] (MSHARED-1476) Maven 4.0.0-rc-3 fails with HTTP 500 when downloading from JitPack (but Maven 3.9.10 is fine, and it's fully reproducible, and not a transient server error)

2025-06-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1476. Resolution: Duplicate created in GitHub issue   > Maven 4.0.0-rc-3 fails with H

[I] JDK transport issue with jitpack.io [maven-resolver]

2025-06-08 Thread via GitHub
cstamas opened a new issue, #739: URL: https://github.com/apache/maven-resolver/issues/739 ### Affected version 2.0.x ### Bug description jitpack.io for some reason responds with HTTP to JDK transport. Apache transport does not reproduce. -- This is an automated messa

Re: [PR] Remove the milestone from not merged PR or labeled with skip-changelog [maven-gh-actions-shared]

2025-06-08 Thread via GitHub
gnodet commented on PR #169: URL: https://github.com/apache/maven-gh-actions-shared/pull/169#issuecomment-2954058849 Ah, got it, I missed that it was on closed PRs. Totally makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] avoid single letter variable names [maven-pmd-plugin]

2025-06-08 Thread via GitHub
slawekjaranowski commented on PR #225: URL: https://github.com/apache/maven-pmd-plugin/pull/225#issuecomment-2954054891 If we skip from releases notes, we should also remove from milestone -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (MPMD-412) Tests are inobviously broken due to overly broad catch clauses

2025-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956778#comment-17956778 ] ASF GitHub Bot commented on MPMD-412: - slawekjaranowski commented on code in PR #226: U

Re: [PR] [MPMD-412] Simplify stub setup by not swallowing exceptions [maven-pmd-plugin]

2025-06-08 Thread via GitHub
slawekjaranowski commented on code in PR #226: URL: https://github.com/apache/maven-pmd-plugin/pull/226#discussion_r2134685616 ## src/test/java/org/apache/maven/plugins/pmd/stubs/CustomConfigurationMavenProjectStub.java: ## @@ -40,35 +41,26 @@ public class CustomConfigurationMav

Re: [PR] Fix npe artifact map [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2458: URL: https://github.com/apache/maven/pull/2458#discussion_r2134684437 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -120,15 +121,15 @@ public class MavenProject implements Cloneable { private Pa

[PR] Fix npe artifact map [maven]

2025-06-08 Thread via GitHub
Pankraz76 opened a new pull request, #2458: URL: https://github.com/apache/maven/pull/2458 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes. - [ ] Write a

Re: [PR] Remove the milestone from not merged PR or labeled with skip-changelog [maven-gh-actions-shared]

2025-06-08 Thread via GitHub
slawekjaranowski commented on PR #169: URL: https://github.com/apache/maven-gh-actions-shared/pull/169#issuecomment-2954039901 > Why ? I find that very useful to be able to assign a milestone to indicate what the target is. It is a case PR is closed without merge or PR has a label sk

Re: [I] Maven 3.9.10 fails randomly with message: Cannot evaluate expression '${project.artifactMap}' [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on issue #2455: URL: https://github.com/apache/maven/issues/2455#issuecomment-2954038915 root cause: `Caused by: java.lang.NullPointerException: Cannot invoke "java.util.Set.add(Object)" because "this.artifacts" is null` -- This is an automated message f

Re: [PR] use `try-with-resources` statement in `Mojos` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2443: URL: https://github.com/apache/maven/pull/2443#issuecomment-2954034398 rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] fix: stabilize build by temp `@DisabledOnOs(MAC)` flaky tests related to `mvn3 fails to close log file properly, therefore JUnit fails to clean up as well.` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2451: URL: https://github.com/apache/maven/pull/2451#issuecomment-2954033540 yes will investigate this together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2457: URL: https://github.com/apache/maven/pull/2457#discussion_r2134669387 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -406,12 +406,8 @@ protected Consumer doDetermineWriter(C context) {

Re: [PR] fix: stabilize build by temp `@DisabledOnOs(MAC)` flaky tests related to `mvn3 fails to close log file properly, therefore JUnit fails to clean up as well.` [maven]

2025-06-08 Thread via GitHub
cstamas commented on PR #2451: URL: https://github.com/apache/maven/pull/2451#issuecomment-2954027853 I am still curious how this fails to you. And knowing that would allow us to understand how (and why) these tests do not fail for anyone else just you. You never said what the failure is, j

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2457: URL: https://github.com/apache/maven/pull/2457#discussion_r2134669387 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -406,12 +406,8 @@ protected Consumer doDetermineWriter(C context) {

[PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 opened a new pull request, #2457: URL: https://github.com/apache/maven/pull/2457 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes. - [ ] Write a

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2456: URL: https://github.com/apache/maven/pull/2456#discussion_r2134663166 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -396,56 +399,41 @@ protected Consumer determineWriter(C context) { protect

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2456: URL: https://github.com/apache/maven/pull/2456#discussion_r2134663166 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -396,56 +399,41 @@ protected Consumer determineWriter(C context) { protect

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2456: URL: https://github.com/apache/maven/pull/2456#discussion_r2134663166 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -396,56 +399,41 @@ protected Consumer determineWriter(C context) { protect

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2456: URL: https://github.com/apache/maven/pull/2456#discussion_r2134663166 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -396,56 +399,41 @@ protected Consumer determineWriter(C context) { protect

Re: [PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2456: URL: https://github.com/apache/maven/pull/2456#discussion_r2134663166 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -396,56 +399,41 @@ protected Consumer determineWriter(C context) { protect

Re: [PR] use `try-with-resources` statement in `CommonsCliOptions` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2440: URL: https://github.com/apache/maven/pull/2440#discussion_r2134658986 ## impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java: ## @@ -407,11 +407,7 @@ protected Consumer doDetermineWriter(C context) { }

[PR] use `try-with-resources` statement in `LookupInvoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 opened a new pull request, #2456: URL: https://github.com/apache/maven/pull/2456 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes. - [ ] Write a

Re: [PR] use `try-with-resources` statement in `impl/maven-cli/src/main/java/org/apache/maven/cling/invoker` [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on PR #2440: URL: https://github.com/apache/maven/pull/2440#issuecomment-2954000603 isolated issue: ```console [INFO] Error: Failures: Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:173 No INFO found ==> expected: bu

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2134656622 ## impl/maven-core/src/test/java/org/apache/maven/model/PropertiesTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2134656500 ## impl/maven-core/src/test/java/org/apache/maven/model/PropertiesTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2134655588 ## src/mdo/java/WrapperProperties.java: ## @@ -101,102 +88,89 @@ public void list(PrintWriter out) { @Override public int size() { -ensureInitialize

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-08 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2134654507 ## src/mdo/java/WrapperProperties.java: ## @@ -101,102 +88,89 @@ public void list(PrintWriter out) { @Override public int size() { -ensureInitialize

  1   2   >