Pankraz76 commented on code in PR #2458:
URL: https://github.com/apache/maven/pull/2458#discussion_r2134770491


##########
impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -877,16 +879,11 @@ public void setArtifacts(Set<Artifact> artifacts) {
      */
     public Set<Artifact> getArtifacts() {

Review Comment:
   ```suggestion
       public synchronized Set<Artifact> getArtifacts() {
   ```
   is it related to concurrency? The `artifacts` referenced in `L:886` should 
not be `null`.
   
   It it possible that some setter call happens, between `L:883` init and 
access on `NPE` throwing line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to