gnodet commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125798341
##
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java:
##
@@ -426,29 +425,14 @@ private void removeFromResolutionStack(Key key) {
}
private
ggjulio commented on issue #888:
URL: https://github.com/apache/maven-mvnd/issues/888#issuecomment-2938798030
+1, would be quite useful for people using MacOS since they only sell arm
laptops.
Is it okay to bump to `2.17` or should we use a different glibc version
between arm and amd
gnodet commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125776377
##
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java:
##
@@ -253,11 +244,6 @@ private Q getInstance(Binding binding) {
ret
gnodet commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125773585
##
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java:
##
@@ -176,17 +175,14 @@ public Supplier getCompiledBinding(Dependency
dep) {
gnodet commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125772512
##
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java:
##
@@ -24,7 +24,6 @@
import java.lang.annotation.Annotation;
Review Comment:
gnodet commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125769798
##
impl/maven-di/src/main/java/org/apache/maven/di/impl/Binding.java:
##
@@ -128,14 +128,19 @@ public Annotation getScope() {
return scope;
}
-public S
Pankraz76 commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938777587
> So having them implementing `Comparable` should definitely be a possible
enhancement.
merci.
- https://github.com/apache/maven/pull/2428
--
This is an automated message
rmannibucau commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125764354
##
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java:
##
@@ -24,7 +24,6 @@
import java.lang.annotation.Annotation;
Review Comment
Pankraz76 commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938775707
> IOC
yes, i mean the concept behind it, not some random impl. detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rmannibucau commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125761407
##
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java:
##
@@ -426,29 +425,14 @@ private void removeFromResolutionStack(Key key) {
}
pr
Pankraz76 commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125761713
##
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java:
##
@@ -176,17 +175,14 @@ public Supplier getCompiledBinding(Dependency
dep) {
Pankraz76 opened a new pull request, #2428:
URL: https://github.com/apache/maven/pull/2428
- https://github.com/apache/maven/pull/2425
- https://github.com/apache/maven/pull/2425#issuecomment-2938746732
--
This is an automated message from the Apache Git Service.
To respond to the messa
gnodet commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938746732
> Its just about moving the external `comparator` (feature envy) to the
actual domain (business logic, following OOP) making it `comparable`. No
injection, no nothing. **Just plain old java.
Pankraz76 commented on code in PR #2425:
URL: https://github.com/apache/maven/pull/2425#discussion_r2125725963
##
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java:
##
@@ -220,7 +220,13 @@ public Supplier doGetCompiledBinding(Dependency
dep) {
if
Pankraz76 commented on code in PR #2425:
URL: https://github.com/apache/maven/pull/2425#discussion_r2125724201
##
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java:
##
@@ -220,7 +220,13 @@ public Supplier doGetCompiledBinding(Dependency
dep) {
if
olamy commented on PR #2413:
URL: https://github.com/apache/maven/pull/2413#issuecomment-2938691596
> Important will be to understand in the same way by maintainers - how we
should work with GitHub issues
>
> Documents to works on
https://maven.apache.org/developers/conventions/githu
olamy commented on PR #2414:
URL: https://github.com/apache/maven/pull/2414#issuecomment-2938686878
> ok, we can start I'm not sure if PR template will be respected per branch
I think only template from default branch is used. (when you create an issue
is not against a branch ;) )
-
Pankraz76 commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938680640
Its just about moving the external `comparator` (feature envy) to the actual
domain (business logic, following OOP) making it `comparable`. No injection, no
nothing. **Just plain old java
gnodet commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938669358
> > wouldn't want to use IoC
>
> why not? IoC is a pattern generally valid and possible to apply in this
case as well.
Did you read the full sentence ? Maven DI *is* an IoC cont
olamy commented on issue #857:
URL: https://github.com/apache/maven-surefire/issues/857#issuecomment-2938666048
duplicate of #834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
olamy closed issue #857: Failsafe Plugin v3.5.3 does not detect or fail on
Cucumber test failures (v3.5.2 works)
URL: https://github.com/apache/maven-surefire/issues/857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Pankraz76 commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938664502
> wouldn't want to use IoC
why not? IoC is a pattern generally valid and possible to apply in this case
as well.
Current implementation seems to be entangled with **feature e
Pankraz76 commented on PR #2417:
URL: https://github.com/apache/maven/pull/2417#issuecomment-2938655500
thx. So no changes at all in this module? Then it could be ignored from git,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rajatsharma2393 opened a new issue, #857:
URL: https://github.com/apache/maven-surefire/issues/857
### Affected version
3.5.3
### Bug description
## Summary
Failsafe plugin version **3.5.3** does not correctly register or report
Cucumber integration test failures.
pmayweg opened a new issue, #218:
URL: https://github.com/apache/maven-build-cache-extension/issues/218
### Affected version
1.2.0
### Bug description
When I have a project with a module with the maven property
maven.build.cache.skipCache set to true and I run maven with
slachiewicz merged PR #58:
URL: https://github.com/apache/maven-reporting-impl/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
github-actions[bot] commented on PR #438:
URL: https://github.com/apache/maven/pull/438#issuecomment-2938316940
This pull request has been closed because no response was received within 90
days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
github-actions[bot] closed pull request #438: [MNG-7083] - introduce lazy Log
message evaluation
URL: https://github.com/apache/maven/pull/438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/MBUILDCACHE-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956018#comment-17956018
]
ASF GitHub Bot commented on MBUILDCACHE-115:
olamy commented on PR #217:
olamy commented on PR #217:
URL:
https://github.com/apache/maven-build-cache-extension/pull/217#issuecomment-2938308747
@sebtiem Thanks! Can we have the reproduction project added as an IT test?
https://github.com/sebtiem/mbuildcache-115-repoduction. It's under ASF license
so we are free
olamy merged PR #209:
URL: https://github.com/apache/maven-build-cache-extension/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956016#comment-17956016
]
ASF GitHub Bot commented on MBUILDCACHE-123:
olamy merged PR #209:
URL:
elharo commented on code in PR #2398:
URL: https://github.com/apache/maven/pull/2398#discussion_r2125146845
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultInterpolator.java:
##
@@ -284,8 +283,7 @@ private static String doSubstVars(
}
private stat
dependabot[bot] opened a new pull request, #207:
URL: https://github.com/apache/maven-doxia-sitetools/pull/207
Bumps [org.htmlunit:htmlunit](https://github.com/HtmlUnit/htmlunit) from
4.12.0 to 4.13.0.
Release notes
Sourced from https://github.com/HtmlUnit/htmlunit/releases";>org.h
gnodet commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2937629223
> well done.
>
>
>
> might consider `IoC (Dependency Inversion Principle)`, as part of SOLID
principles afterward.
This _is_ an IoC container, I wouldn't want to use Io
slawekjaranowski opened a new pull request, #214:
URL: https://github.com/apache/maven-pmd-plugin/pull/214
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
slachiewicz commented on PR #58:
URL:
https://github.com/apache/maven-reporting-impl/pull/58#issuecomment-2937238518
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
gnodet commented on PR #2417:
URL: https://github.com/apache/maven/pull/2417#issuecomment-2937211691
> yes this request it persistent, did not remember that. Is it because of
legacy or backwards compatibility?
Both actually.
--
This is an automated message from the Apache Git Servi
dependabot[bot] commented on PR #211:
URL: https://github.com/apache/maven-pmd-plugin/pull/211#issuecomment-2937211479
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a depend
slawekjaranowski closed pull request #211: Bump resolverVersion from 1.4.1 to
1.9.23
URL: https://github.com/apache/maven-pmd-plugin/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Pankraz76 commented on code in PR #2425:
URL: https://github.com/apache/maven/pull/2425#discussion_r2124918459
##
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java:
##
@@ -220,7 +220,13 @@ public Supplier doGetCompiledBinding(Dependency
dep) {
if
Pankraz76 commented on PR #2398:
URL: https://github.com/apache/maven/pull/2398#issuecomment-2937123854
yes sorry from 7 to 6 params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Pankraz76 opened a new pull request, #2427:
URL: https://github.com/apache/maven/pull/2427
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
Pankraz76 commented on code in PR #2381:
URL: https://github.com/apache/maven/pull/2381#discussion_r2124860538
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -144,12 +150,11
Pankraz76 commented on code in PR #2426:
URL: https://github.com/apache/maven/pull/2426#discussion_r2124846353
##
its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java:
##
@@ -92,21 +92,11 @@ public void
elharo commented on PR #2398:
URL: https://github.com/apache/maven/pull/2398#issuecomment-2937062295
No, it's definitely removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Pankraz76 commented on code in PR #2426:
URL: https://github.com/apache/maven/pull/2426#discussion_r2124846353
##
its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java:
##
@@ -92,21 +92,11 @@ public void
Pankraz76 opened a new pull request, #2426:
URL: https://github.com/apache/maven/pull/2426
- https://github.com/apache/maven/pull/2424
ref
- https://github.com/apache/maven/pull/2396#issuecomment-2936965168
--
This is an automated message from the Apache Git Service.
To respond
Pankraz76 commented on code in PR #2426:
URL: https://github.com/apache/maven/pull/2426#discussion_r2124845009
##
its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java:
##
@@ -92,21 +92,11 @@ public void
Pankraz76 commented on PR #2396:
URL: https://github.com/apache/maven/pull/2396#issuecomment-2937016628
> I see no benefit in this change.
indeed, not all, as its a mix of:
- https://github.com/apache/maven/pull/2426
- https://github.com/apache/maven/pull/2395
--
This is a
Pankraz76 commented on PR #2398:
URL: https://github.com/apache/maven/pull/2398#issuecomment-2936986762
> otherwise looks good.
pr title?
it seems more re`name`, rather than re`move`.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Pankraz76 commented on PR #2417:
URL: https://github.com/apache/maven/pull/2417#issuecomment-2936970597
yes this request it persistent, did not remember that. Is it because of
legacy or backwards compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the
Pankraz76 commented on PR #2396:
URL: https://github.com/apache/maven/pull/2396#issuecomment-2936965168
its simply false catch and hindering `try-with-resources` statement
promoting bare overhead.
will give dedicated example. But yes it should be done in combination with
`autoclosab
slawekjaranowski commented on PR #2413:
URL: https://github.com/apache/maven/pull/2413#issuecomment-2936958272
Important will be to understand in the same way by maintainers - how we
should work with GitHub issues
Documents to works on
https://maven.apache.org/developers/conventions/
gnodet closed pull request #2396: avoid false `IO` catch on `mkdirs()`
URL: https://github.com/apache/maven/pull/2396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
gnodet closed pull request #2376: chore: `DefaultUpdateCheckManager` Fix
variable 'lock' is never used (PMD: UnusedPrivateField)
URL: https://github.com/apache/maven/pull/2376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/MNG-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955965#comment-17955965
]
Matthias Bünger commented on MNG-8765:
--
What is this about? No description :(
> Maven
gnodet commented on code in PR #2381:
URL: https://github.com/apache/maven/pull/2381#discussion_r2124744832
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -144,12 +150,11 @@
gnodet closed pull request #2384: chore: `MojoExecutor` Fix variable 'lock' is
never used (PMD: UnusedPrivateField)
URL: https://github.com/apache/maven/pull/2384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
gnodet commented on PR #2384:
URL: https://github.com/apache/maven/pull/2384#issuecomment-2936871732
You just cannot remove a feature such as a lock mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Pankraz76 commented on code in PR #2370:
URL: https://github.com/apache/maven/pull/2370#discussion_r2124732837
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -95,7 +95,10 @@
gnodet commented on code in PR #2398:
URL: https://github.com/apache/maven/pull/2398#discussion_r2124727807
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultInterpolator.java:
##
@@ -284,8 +283,7 @@ private static String doSubstVars(
}
private stat
Pankraz76 commented on code in PR #2398:
URL: https://github.com/apache/maven/pull/2398#discussion_r2124725169
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultInterpolator.java:
##
@@ -283,7 +283,7 @@ private static String doSubstVars(
}
private s
Pankraz76 commented on code in PR #2398:
URL: https://github.com/apache/maven/pull/2398#discussion_r2124725169
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultInterpolator.java:
##
@@ -283,7 +283,7 @@ private static String doSubstVars(
}
private s
Pankraz76 commented on code in PR #2423:
URL: https://github.com/apache/maven/pull/2423#discussion_r2124706225
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -251,7 +252,10 @@ void
locateExistingPomWithFilePathShouldReturnSameFile
dependabot[bot] opened a new pull request, #856:
URL: https://github.com/apache/maven-surefire/pull/856
Bumps [org.htmlunit:htmlunit](https://github.com/HtmlUnit/htmlunit) from
4.12.0 to 4.13.0.
Release notes
Sourced from https://github.com/HtmlUnit/htmlunit/releases";>org.htmlunit
gnodet commented on code in PR #2398:
URL: https://github.com/apache/maven/pull/2398#discussion_r2124692550
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultInterpolator.java:
##
@@ -283,7 +283,7 @@ private static String doSubstVars(
}
private stat
Pankraz76 commented on PR #2406:
URL: https://github.com/apache/maven/pull/2406#issuecomment-2936782087
yes, the now explicitly methods are kind of overhead, as empty like before,
would be nice to have them in some kind of default impl.
Whats the matter? Its just the same method and s
gnodet commented on code in PR #2423:
URL: https://github.com/apache/maven/pull/2423#discussion_r2124682903
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -251,7 +252,10 @@ void
locateExistingPomWithFilePathShouldReturnSameFileIfR
Pankraz76 commented on code in PR #2413:
URL: https://github.com/apache/maven/pull/2413#discussion_r2124679516
##
.github/ISSUE_TEMPLATE/BUG.yml:
##
@@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. Se
gnodet opened a new pull request, #2425:
URL: https://github.com/apache/maven/pull/2425
When injecting List dependencies, the DI container now sorts the
bindings by their @Priority annotation value in descending order
(highest priority first) to ensure deterministic ordering.
Thi
Guillaume Nodet created MNG-8765:
Summary: Maven Upgrade Tool
Key: MNG-8765
URL: https://issues.apache.org/jira/browse/MNG-8765
Project: Maven
Issue Type: New Feature
Reporter: Gu
elharo merged PR #389:
URL: https://github.com/apache/maven-javadoc-plugin/pull/389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@m
elharo merged PR #390:
URL: https://github.com/apache/maven-javadoc-plugin/pull/390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@m
Guillaume Nodet created MNG-8764:
Summary: Maven DI should sort injected list according to the items
priority
Key: MNG-8764
URL: https://issues.apache.org/jira/browse/MNG-8764
Project: Maven
Pankraz76 commented on code in PR #2423:
URL: https://github.com/apache/maven/pull/2423#discussion_r2124347941
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java:
##
@@ -251,7 +252,10 @@ void
locateExistingPomWithFilePathShouldReturnSameFile
Pankraz76 commented on PR #2402:
URL: https://github.com/apache/maven/pull/2402#issuecomment-2936064182
> provide fixes
yes, that would be awesome and possible with open rewrite.
-
https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation
- https://github
Pankraz76 commented on PR #2402:
URL: https://github.com/apache/maven/pull/2402#issuecomment-2936090338
whats the issue with licence? do they send out bill, or try to claim maven
then?
do not expect anything from mentioned scenarios, so whats the deal breaker?
as long we dont c
cstamas commented on issue #333:
URL:
https://github.com/apache/maven-compiler-plugin/issues/333#issuecomment-2936013610
Yup, I'd have this plugin emit only one line: `Compiling source files with
javac [debug deorecation release=17]`
--
This is an automated message from the Apache Git Se
gsmet commented on code in PR #335:
URL:
https://github.com/apache/maven-compiler-plugin/pull/335#discussion_r2124261488
##
src/main/java/org/apache/maven/plugin/compiler/DeltaList.java:
##
@@ -33,10 +33,8 @@ final class DeltaList {
private final boolean hasChanged;
gsmet opened a new pull request, #335:
URL: https://github.com/apache/maven-compiler-plugin/pull/335
This pull request targets the 3.x branch as I think this support has been
rewritten in 4.
Here is the situation prior to this patch with a massive project (~40k
source files):
gsmet opened a new issue, #334:
URL: https://github.com/apache/maven-compiler-plugin/issues/334
### Affected version
3.14.0
### Bug description
I'm experimenting with a large Quarkus project to try to enhance our build
time and I noticed that `DeltaList` was very ineffic
Bukama merged PR #262:
URL: https://github.com/apache/maven-doxia/pull/262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apac
Bukama merged PR #266:
URL: https://github.com/apache/maven-doxia/pull/266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apac
Bukama merged PR #268:
URL: https://github.com/apache/maven-doxia/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apac
[
https://issues.apache.org/jira/browse/MBUILDCACHE-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated MBUILDCACHE-115:
---
Labels: pull-request-available (was: )
> MojoExecution is not seeded in session
[
https://issues.apache.org/jira/browse/MBUILDCACHE-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955891#comment-17955891
]
ASF GitHub Bot commented on MBUILDCACHE-115:
sebtiem opened a new pull r
sebtiem opened a new pull request, #217:
URL: https://github.com/apache/maven-build-cache-extension/pull/217
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes
dependabot[bot] opened a new pull request, #268:
URL: https://github.com/apache/maven-doxia/pull/268
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from
5.12.2 to 5.13.0.
Release notes
Sourced from https://github.com/junit-team/junit5/releases";>org.junit:junit-b
gnodet commented on PR #2402:
URL: https://github.com/apache/maven/pull/2402#issuecomment-2935066317
Could we setup the tools in PRs only so that it would comment and provide
fixes as suggestions ? We would keep it on CI only ?
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955870#comment-17955870
]
ASF GitHub Bot commented on MBUILDCACHE-123:
olamy commented on PR #209:
olamy commented on PR #209:
URL:
https://github.com/apache/maven-build-cache-extension/pull/209#issuecomment-2934931824
@zrlw Good idea. I will try for later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
YaSuenag commented on PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#issuecomment-2934905865
PING: Do you have any comments?
I'm happy if I can contribute this change. I believe adding prefix is very
useful to package apps with jlink. Any comments welcome, thanks!
elharo opened a new pull request, #390:
URL: https://github.com/apache/maven-javadoc-plugin/pull/390
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
elharo commented on PR #388:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/388#issuecomment-2934807530
The label security, not security-fix. It is security related so it gets the
label so anyone interested in security things can easily find it.
The removed label was not a
elharo closed pull request #2400: Redu
URL: https://github.com/apache/maven/pull/2400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
elharo opened a new pull request, #389:
URL: https://github.com/apache/maven-javadoc-plugin/pull/389
On the happy path, just generate the Javadocs and don't bother the users
excessively about every step of the process
--
This is an automated message from the Apache Git Service.
To respond
elharo merged PR #384:
URL: https://github.com/apache/maven-javadoc-plugin/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@m
elharo commented on code in PR #2423:
URL: https://github.com/apache/maven/pull/2423#discussion_r2123466940
##
impl/maven-executor/src/test/java/org/apache/maven/cling/executor/MavenExecutorTestSupport.java:
##
@@ -63,7 +64,9 @@ void mvnenc(
System.out.println(Files.rea
elharo commented on PR #2402:
URL: https://github.com/apache/maven/pull/2402#issuecomment-2934699629
It sounds like you might not be accustomed to legacy projects with decades
long history that predate conventions like @Override. Not every project is a
greenfield, and other factors come int
1 - 100 of 103 matches
Mail list logo
