rmannibucau commented on code in PR #2428: URL: https://github.com/apache/maven/pull/2428#discussion_r2125764354
########## impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java: ########## @@ -24,7 +24,6 @@ import java.lang.annotation.Annotation; Review Comment: is there any benefit in this change except adding mor responsability to binding than it should have? (btw OOP is outdated these days we tend to move to something closer to functional since it evolves smoother in practise, exactly as your PR shows) a good example is that if we get interceptors for ex, sorting will be reversed so your comparable impl will not work and will need to be reverted to this code or will make the code no more even -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
