Pankraz76 commented on PR #2425:
URL: https://github.com/apache/maven/pull/2425#issuecomment-2938664502

   > wouldn't want to use IoC
   
   why not? IoC is a pattern generally valid and possible to apply in this case 
as well.
   
   Current implementation seems to be entangled with **feature envy**, as the 
sorting logic is **an random impl. detail**, not of interest to the actual 
`InjectorImpl.java`. 
   
   Its task it to apply to sorting not to actually do it. 
   
   Instead of delegating the topic to the real one, its done by its consumer, 
making the code **impossible to reuse**.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to