gnodet commented on PR #2277:
URL: https://github.com/apache/maven/pull/2277#issuecomment-2848467350
@Pankraz76 I'm not sure what you aim for with your PRs. How do they differ
from this one ? It's fine very fine that you used openrewrite rules, but isn't
the result the same at the end ?
slachiewicz merged PR #209:
URL: https://github.com/apache/maven-assembly-plugin/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
slachiewicz commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848187270
> > You need also to adjust CI/CD pipeline
>
> is it located in this repo, please? where to find this?
maven-verify.yaml
--
This is an automated message from
Pankraz76 commented on PR #2293:
URL: https://github.com/apache/maven/pull/2293#issuecomment-2848146670
[INFO] BUILD SUCCESS
https://github.com/user-attachments/assets/b37bc130-c2f4-4d5d-b441-b45e9a1158da";
/>
--
This is an automated message from the Apache Git Service.
To
michael-o commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848054878
> > OK as a temporary stopgap, but in general generated files shouldn't even
be in the source repo.
>
> This is a limitation of site/doxia: it cannot process generated resour
Bukama opened a new pull request, #241:
URL: https://github.com/apache/maven-release/pull/241
* Release was already there
* Milestone created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Pankraz76 commented on PR #2292:
URL: https://github.com/apache/maven/pull/2292#issuecomment-2848023291
whats the mystery about this?
```
[ERROR] Errors:
[ERROR] EmbeddedMavenExecutorTest.defaultFs3xCaptureOutput(Path) ยป Timeout
defaultFs3xCaptureOutput(java.nio.file.Path) timed
cstamas commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848017024
> OK as a temporary stopgap, but in general generated files shouldn't even
be in the source repo.
This is a limitation of site/doxia: it cannot process generated resources,
at
Pankraz76 commented on code in PR #2291:
URL: https://github.com/apache/maven/pull/2291#discussion_r2072091113
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -99,28 +96,16 @@ public Model read(XmlReaderRequest request) throws
IOEx
slachiewicz commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2847959273
> OK as a temporary stopgap, but in general generated files shouldn't even
be in the source repo.
but this is template that will be used to generate files - and expectation
Pankraz76 commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2847948280
> You need also to adjust CI/CD pipeline
is it located in this repo, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Pankraz76 commented on code in PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#discussion_r2072057531
##
pom.xml:
##
@@ -96,6 +96,11 @@ under the License.
+
Review Comment:
done thx.
--
This is an automated message from the Apache Git Se
Pankraz76 commented on code in PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#discussion_r2072056970
##
pom.xml:
##
@@ -96,6 +96,11 @@ under the License.
+
+ jakarta.inject
+ jakarta.inject-api
+ 1.0.3
+
Review Comment:
`
desruisseaux commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2847939741
> But it can still apply source or target when compiling against Java 8?
Yes, but this is not useful since the plugin requires Java 17 for execution
anyway. Therefore, user
slachiewicz commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2847937699
You need also to adjust CI/CD pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
slachiewicz commented on code in PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#discussion_r2072053989
##
pom.xml:
##
@@ -96,6 +96,11 @@ under the License.
+
Review Comment:
remove this
--
This is an automated message from the Apache Gi
Pankraz76 commented on code in PR #2291:
URL: https://github.com/apache/maven/pull/2291#discussion_r2072051138
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -99,28 +96,16 @@ public Model read(XmlReaderRequest request) throws
IOEx
slachiewicz commented on PR #209:
URL:
https://github.com/apache/maven-assembly-plugin/pull/209#issuecomment-2847918175
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
slachiewicz merged PR #207:
URL: https://github.com/apache/maven-assembly-plugin/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
slachiewicz merged PR #189:
URL: https://github.com/apache/maven-shared-utils/pull/189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
slachiewicz merged PR #193:
URL: https://github.com/apache/maven-shared-utils/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
slachiewicz merged PR #191:
URL: https://github.com/apache/maven-shared-utils/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
Pankraz76 commented on code in PR #2290:
URL: https://github.com/apache/maven/pull/2290#discussion_r2072009172
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelXmlFactoryTest.java:
##
@@ -105,7 +105,7 @@ void testNoNamespaceWithModelVersion400() throws Exceptio
slachiewicz closed pull request #194: Move to org.jline:jansi
URL: https://github.com/apache/maven-shared-utils/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
Pankraz76 commented on code in PR #2277:
URL: https://github.com/apache/maven/pull/2277#discussion_r2071987522
##
impl/maven-impl/src/main/java/org/apache/maven/impl/AbstractSession.java:
##
@@ -134,7 +132,7 @@ public AbstractSession(
List repositories,
Pankraz76 commented on code in PR #2277:
URL: https://github.com/apache/maven/pull/2277#discussion_r2071983187
##
impl/maven-impl/src/main/java/org/apache/maven/impl/AbstractSession.java:
##
@@ -337,7 +335,7 @@ public LocalRepository getLocalRepository() {
@Nonnull
@Ov
Pankraz76 commented on PR #2287:
URL: https://github.com/apache/maven/pull/2287#issuecomment-2847774999
update:
https://github.com/user-attachments/assets/1a775ad6-2a8f-496e-aacc-2a89f02e0ab1";
/>
https://github.com/user-attachments/assets/c89bbdc6-6cd0-41c8-980b-fd0e20cca0a1";
/
Bukama opened a new pull request, #400:
URL: https://github.com/apache/maven-plugin-tools/pull/400
* Release and Milestone already there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Bukama opened a new pull request, #37:
URL: https://github.com/apache/maven-jdeprscan-plugin/pull/37
* No release created (only an alpha-version tag with no PR linked as far as
I can see)
* Milestone created
--
This is an automated message from the Apache Git Service.
To respond to the
Bukama opened a new pull request, #50:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/50
* Release was there
* Milestone created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Bukama opened a new pull request, #286:
URL: https://github.com/apache/maven-invoker-plugin/pull/286
* Release and milestones already there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Bukama opened a new pull request, #131:
URL: https://github.com/apache/maven-help-plugin/pull/131
* Release created
* Milestone created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
cstamas commented on code in PR #2289:
URL: https://github.com/apache/maven/pull/2289#discussion_r2071740836
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/rootlocator/DefaultRootLocator.java:
##
@@ -81,11 +87,19 @@ protected boolean isRootDirectory(Path dir) {
cstamas opened a new pull request, #2289:
URL: https://github.com/apache/maven/pull/2289
Applied proposed fix and a bit more.
---
https://issues.apache.org/jira/browse/MNG-8720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/MNG-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-8720:
Assignee: Tamas Cservenak
> Warning about root directory and multiModuleProjectDirectory not
[
https://issues.apache.org/jira/browse/MNG-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8720:
-
Fix Version/s: 4.0.0-rc-4
> Warning about root directory and multiModuleProjectDirectory not being
Henning Hoefer created MNG-8720:
---
Summary: Warning about root directory and
multiModuleProjectDirectory not being aligned doesn't account for symlinks
Key: MNG-8720
URL: https://issues.apache.org/jira/browse/MNG-872
seekM opened a new issue, #173:
URL: https://github.com/apache/maven-checkstyle-plugin/issues/173
### New feature, improvement proposal
Please consider the following Checkstyle report created with `mvn:site`:
 instead of
collect(Collectors.toList()))
https://github.com/checkstyle/checkstyle/issues/16965
--
This is an automated message from the
Pankraz76 commented on PR #2277:
URL: https://github.com/apache/maven/pull/2277#issuecomment-2846992058
> *
https://docs.openrewrite.org/recipes/staticanalysis/replacestreamtolistwithcollect
this is wrong. Only the
[upgradetojava21](https://docs.openrewrite.org/recipes/java/migrate/u
Pankraz76 commented on PR #2287:
URL: https://github.com/apache/maven/pull/2287#issuecomment-2846907433
issue:
https://github.com/user-attachments/assets/bd5a54a9-9d58-497b-ba58-eb1310eafb4a";
/>
--
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/MNG-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-8719:
Assignee: Tamas Cservenak
> Restore Maven 3 compatibility: ConfigurationContainer.setInherit
cstamas opened a new pull request, #2288:
URL: https://github.com/apache/maven/pull/2288
Added it as deprecated indirection for legacy code.
---
https://issues.apache.org/jira/browse/MNG-8719
--
This is an automated message from the Apache Git Service.
To respond to the messa
Pankraz76 commented on PR #2277:
URL: https://github.com/apache/maven/pull/2277#issuecomment-2846904753
its nice to fix this once, but without a computer checking and enforcing
this by some tool like checkstyle or rewrite, its not completed.
--
This is an automated message from the Apache
Pankraz76 commented on PR #2277:
URL: https://github.com/apache/maven/pull/2277#issuecomment-2846900885
please consider this supplemental PR to apply SRP:
- #2287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Pankraz76 opened a new pull request, #2287:
URL: https://github.com/apache/maven/pull/2287
Supplement of:
- https://github.com/apache/maven/pull/2277
-
https://docs.openrewrite.org/recipes/staticanalysis/replacestreamtolistwithcollect
--
This is an automated message from the Apache
Tamas Cservenak created MNG-8719:
Summary: Restore Maven 3 compatibility:
ConfigurationContainer.setInherited
Key: MNG-8719
URL: https://issues.apache.org/jira/browse/MNG-8719
Project: Maven
Bukama commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2846561066
> > Should we left old properties and allow to m-compiler-p to use proper
one?
> > I think that we need preserve also source and target - it will be used
for jdk8
>
> Actually
Bukama merged PR #224:
URL: https://github.com/apache/maven-assembly-plugin/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
Bukama merged PR #223:
URL: https://github.com/apache/maven-assembly-plugin/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
desruisseaux commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2846541911
> Should we left old properties and allow to m-compiler-p to use proper one?
> I think that we need preserve also source and target - it will be used for
jdk8
Actually, i
52 matches
Mail list logo
