cstamas commented on code in PR #2289:
URL: https://github.com/apache/maven/pull/2289#discussion_r2071740836
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/rootlocator/DefaultRootLocator.java:
##########
@@ -81,11 +87,19 @@ protected boolean isRootDirectory(Path dir) {
return false;
}
- protected Optional<Path> getRootDirectoryFallback() {
+ protected Optional<Path> getRootDirectoryFallback() throws IOException {
String mmpd = System.getProperty("maven.multiModuleProjectDirectory");
if (mmpd != null) {
- return Optional.of(Paths.get(mmpd));
+ return Optional.of(getCanonicalPath(Paths.get(mmpd)));
}
return Optional.empty();
}
+
+ protected Path getCanonicalPath(Path path) {
Review Comment:
This is the third "incarnation" of this method :smile: so we may want to do
something about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
