Re: [PR] Bump resolverVersion from 1.9.20 to 1.9.22 [maven-plugin-tools]

2025-03-22 Thread via GitHub
dependabot[bot] commented on PR #348: URL: https://github.com/apache/maven-plugin-tools/pull/348#issuecomment-2745912868 Ignore Conditions |Dependency| Ignore Condition| |-|-| | org.apache.maven.resolver:maven-resolver-api | [>= 2.a0, < 3] | -- This is an automate

Re: [PR] Bump resolverVersion from 1.9.20 to 1.9.22 [maven-plugin-tools]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #348: URL: https://github.com/apache/maven-plugin-tools/pull/348#issuecomment-2745912862 @dependabot show org.apache.maven.resolver:maven-resolver-api ignore conditions -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Bump org.apache.maven:maven-parent from 44-SNAPSHOT to 44 [maven-site]

2025-03-22 Thread via GitHub
slachiewicz merged PR #735: URL: https://github.com/apache/maven-site/pull/735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] Bump resolverVersion from 1.9.20 to 1.9.22 [maven-plugin-tools]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #348: URL: https://github.com/apache/maven-plugin-tools/pull/348#issuecomment-2745902508 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 43 to 44 [maven-install-plugin]

2025-03-22 Thread via GitHub
slawekjaranowski commented on code in PR #131: URL: https://github.com/apache/maven-install-plugin/pull/131#discussion_r2008965173 ## pom.xml: ## @@ -148,6 +148,7 @@ org.apache.maven.plugin-tools maven-plugin-annotations + 3.15.1 Review Comment: pro

Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 43 to 44 [maven-compiler-plugin]

2025-03-22 Thread via GitHub
slawekjaranowski commented on code in PR #316: URL: https://github.com/apache/maven-compiler-plugin/pull/316#discussion_r2008965004 ## pom.xml: ## @@ -84,6 +84,7 @@ under the License. org.apache.maven.plugin-tools maven-plugin-annotations + 3.15.1 Revi

Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.16.1 [maven-plugin-tools]

2025-03-22 Thread via GitHub
dependabot[bot] commented on PR #378: URL: https://github.com/apache/maven-plugin-tools/pull/378#issuecomment-2745898081 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.16.1 [maven-plugin-tools]

2025-03-22 Thread via GitHub
slachiewicz commented on PR #378: URL: https://github.com/apache/maven-plugin-tools/pull/378#issuecomment-2745898044 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.16.1 [maven-plugin-tools]

2025-03-22 Thread via GitHub
dependabot[bot] closed pull request #378: Bump org.mockito:mockito-core from 3.12.4 to 5.16.1 URL: https://github.com/apache/maven-plugin-tools/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.17.2 [maven-plugin-tools]

2025-03-22 Thread via GitHub
gnodet commented on PR #372: URL: https://github.com/apache/maven-plugin-tools/pull/372#issuecomment-2745801674 I'm interested in having that label applied at creation time so that we can have that info easily when looking at the PR list. After merging, it's not that useful. -- This i

Re: [PR] Bump slf4jVersion from 1.7.36 to 2.0.0 [maven-plugin-tools]

2025-03-22 Thread via GitHub
gnodet commented on PR #326: URL: https://github.com/apache/maven-plugin-tools/pull/326#issuecomment-2745809545 Do we want this upgrade ? The plugin still targets maven 3.x for the moment, so not sure we want to switch to maven 4 dependencies (slf4j 2.x, resolver 2.x, etc...) @slawekjar

[PR] Always refreshes artifacts in MavenITmng7470ResolverTransportTest [maven-integration-testing]

2025-03-22 Thread via GitHub
slawekjaranowski opened a new pull request, #402: URL: https://github.com/apache/maven-integration-testing/pull/402 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Bump slf4jVersion from 1.7.36 to 2.0.0 [maven-plugin-tools]

2025-03-22 Thread via GitHub
slawekjaranowski merged PR #326: URL: https://github.com/apache/maven-plugin-tools/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.17.2 [maven-plugin-tools]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #372: URL: https://github.com/apache/maven-plugin-tools/pull/372#issuecomment-2745674783 @gnodet do we need a label `3.x` ... if yes we should add it do dependabot configuration ... But we also have a milestone which will be added automatically after

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745484049 > Thanks for the link, I just had a look. Does anyone know for which services jline needs native access? I'm curious in particular if this is a service that Maven actually uses, an

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
desruisseaux commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745458796 Thanks for the link, I just had a look. Does anyone know for which services jline needs native access? I'm curious in particular if this is a service that Maven actually uses, and whic

[PR] Use Maven 3.9.9 for build maven-3.9.x branch [maven]

2025-03-22 Thread via GitHub
slawekjaranowski opened a new pull request, #2177: URL: https://github.com/apache/maven/pull/2177 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2745418432 JDK 24 is available now we have: ``` Error: Failed to execute goal org.eclipse.sisu:sisu-maven-plugin:0.9.0.M3:main-index (index-project) on project maven-model-bui

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745408963 > Is it adding the `--enable-native-access=ALL-UNNAMED` systematically? If yes, I wonder for which feature, and whether there are safer alternatives? @desruisseaux Please al

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on PR #2171: URL: https://github.com/apache/maven/pull/2171#issuecomment-2745407374 @Bukama I need a test on Windows use `mvn.cmd` from this PR on JDK 24 warning should not be displayed -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [MNG-8248] Add enable-native-access to startup scripts [maven]

2025-03-22 Thread via GitHub
slawekjaranowski commented on code in PR #2171: URL: https://github.com/apache/maven/pull/2171#discussion_r2008834455 ## apache-maven/src/bin/mvn: ## @@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" export MAVEN_CMD_LINE_ARGS +# MNG-824

Re: [PR] Update to Maven Parent 44 [maven-checkstyle-plugin]

2025-03-22 Thread via GitHub
slawekjaranowski commented on code in PR #170: URL: https://github.com/apache/maven-checkstyle-plugin/pull/170#discussion_r2008834125 ## pom.xml: ## @@ -114,6 +115,7 @@ under the License. org.apache.maven.plugin-tools maven-plugin-annotations + ${mavenP

Re: [PR] [MNG-8510] Avoid duplicate Utils classes [maven]

2025-03-22 Thread via GitHub
elharo commented on code in PR #2173: URL: https://github.com/apache/maven/pull/2173#discussion_r2008812793 ## impl/maven-core/src/main/java/org/apache/maven/internal/impl/CoreUtils.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [MNG-8639] Check namespaces when reading XML models [maven]

2025-03-22 Thread via GitHub
gnodet commented on code in PR #2170: URL: https://github.com/apache/maven/pull/2170#discussion_r2008796371 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java: ## @@ -48,8 +48,37 @@ @Singleton public class DefaultModelXmlFactory implements Model

Re: [PR] [MNG-8510] Avoid duplicate Utils classes [maven]

2025-03-22 Thread via GitHub
gnodet commented on code in PR #2173: URL: https://github.com/apache/maven/pull/2173#discussion_r2008796034 ## impl/maven-core/src/main/java/org/apache/maven/internal/impl/CoreUtils.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [MNG-8510] Avoid duplicate Utils classes [maven]

2025-03-22 Thread via GitHub
desruisseaux commented on code in PR #2173: URL: https://github.com/apache/maven/pull/2173#discussion_r2008789802 ## impl/maven-core/src/main/java/org/apache/maven/internal/impl/CoreUtils.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] [MNG-8510] Avoid duplicate Utils classes [maven]

2025-03-22 Thread via GitHub
desruisseaux commented on code in PR #2173: URL: https://github.com/apache/maven/pull/2173#discussion_r2008787491 ## impl/maven-core/src/main/java/org/apache/maven/internal/impl/CoreUtils.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Comment Edited] (MNG-8537) Maven 4 namespace should not change

2025-03-22 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937601#comment-17937601 ] Elliotte Rusty Harold edited comment on MNG-8537 at 3/22/25 1:14 PM:

[jira] [Comment Edited] (MNG-8537) Maven 4 namespace should not change

2025-03-22 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937603#comment-17937603 ] Elliotte Rusty Harold edited comment on MNG-8537 at 3/22/25 1:16 PM:

[jira] [Comment Edited] (MNG-8537) Maven 4 namespace should not change

2025-03-22 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937603#comment-17937603 ] Elliotte Rusty Harold edited comment on MNG-8537 at 3/22/25 1:13 PM:

[jira] [Commented] (MNG-8537) Maven 4 namespace should not change

2025-03-22 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937603#comment-17937603 ] Elliotte Rusty Harold commented on MNG-8537: Thinking about this further, it oc

[jira] [Commented] (MNG-8537) Maven 4 namespace should not change

2025-03-22 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937601#comment-17937601 ] Elliotte Rusty Harold commented on MNG-8537: Is that a new problem? Today anybo

Re: [PR] [MNG-8639] Check namespaces when reading XML models [maven]

2025-03-22 Thread via GitHub
elharo commented on code in PR #2170: URL: https://github.com/apache/maven/pull/2170#discussion_r2008763401 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java: ## @@ -48,8 +48,37 @@ @Singleton public class DefaultModelXmlFactory implements Model