desruisseaux commented on code in PR #2173: URL: https://github.com/apache/maven/pull/2173#discussion_r2008789802
########## impl/maven-core/src/main/java/org/apache/maven/internal/impl/CoreUtils.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.internal.impl; + +import java.util.Collection; +import java.util.List; +import java.util.Objects; +import java.util.function.Function; +import java.util.stream.Collectors; + +class CoreUtils { + public static <T> T nonNull(T t) { Review Comment: Note: the automatically generated message cited in above comment is for implicit null-checks, not for the exception thrown by `Objects.requireNonNull(T)`. I would propose that when a method uses the parameter immediately like below: ```java public void foo(String biz) { if (biz.equals("foo")) { } } ``` If `biz` is null, Java 14 and latter while automatically generates a message saying _"Cannot invoke "String.equals(Object)" because "biz" is null"_. Therefore, it may be better (compared to no message at all) to not invoke a method such as `nonNull` if we accept that the exception is `NullPointerException`. For cases where the implicit null check would be too late, the `Objects.requireNonNull` methods throw an exception of type consistent with the implicit null checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
