desruisseaux commented on code in PR #2173: URL: https://github.com/apache/maven/pull/2173#discussion_r2008787491
########## impl/maven-core/src/main/java/org/apache/maven/internal/impl/CoreUtils.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.internal.impl; + +import java.util.Collection; +import java.util.List; +import java.util.Objects; +import java.util.function.Function; +import java.util.stream.Collectors; + +class CoreUtils { + public static <T> T nonNull(T t) { Review Comment: Or should we use `Objects.requireNonNull(T)` instead? The exception is not the same (`NullPointerException` instead of `IllegalArgumentException`), but the former became the standard usage in the JDK API. It is also consistent with the code that just rely on implicit null-check, especially since Java 14 [automatically generates an exception message with the name of the parameter that was null](https://openjdk.org/jeps/358). Finally, `Objects.requireNonNull(T)` as some JVM-level optimization (the `@ForceInline` annotation) that we can't reproduce in our own null-check method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
