[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758841#comment-17758841 ] ASF GitHub Bot commented on MBUILDCACHE-64: --- gnodet commented on PR #91: UR

[GitHub] [maven-build-cache-extension] gnodet commented on pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-24 Thread via GitHub
gnodet commented on PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1692814388 I'm starting to wonder if the use of the JDK `PathMatcher` is sufficient here. If we want to optimize the file system access and not traverse _all_ files / subdirectories

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758839#comment-17758839 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on PR #1208: URL: https://git

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758837#comment-17758837 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on PR #1208: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1692789865 > > @elharo I don't really see the need to spend much time on rewriting code copied from a utility class. The DefaultWagonManager is part of maven-compat, so deprecated and not really mainta

[GitHub] [maven-mvnd] Joeywzr closed issue #880: How can I get the mvnd with 3.6.3 version maven?

2023-08-24 Thread via GitHub
Joeywzr closed issue #880: How can I get the mvnd with 3.6.3 version maven? URL: https://github.com/apache/maven-mvnd/issues/880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (MNG-7822) Add support for TRACE logging level (with style "bold,magenta")

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758822#comment-17758822 ] ASF GitHub Bot commented on MNG-7822: - CrazyHZM commented on code in PR #1215: URL: htt

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758819#comment-17758819 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on code in PR #1208: URL: htt

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
CrazyHZM commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305099465 ## maven-core/src/main/java/org/apache/maven/utils/dag/CycleDetector.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758818#comment-17758818 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on code in PR #1208: URL: htt

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
CrazyHZM commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305099150 ## maven-core/src/main/java/org/apache/maven/utils/dag/CycleDetector.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758817#comment-17758817 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on code in PR #1208: URL: htt

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
CrazyHZM commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305096986 ## maven-core/src/main/java/org/apache/maven/utils/introspection/ReflectionValueExtractor.java: ## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758794#comment-17758794 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on PR #1208: URL: https://git

[GitHub] [maven] CrazyHZM commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
CrazyHZM commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1692669455 > @elharo I don't really see the need to spend much time on rewriting code copied from a utility class. The DefaultWagonManager is part of maven-compat, so deprecated and not really mainta

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758750#comment-17758750 ] ASF GitHub Bot commented on MENFORCER-490: -- elharo opened a new pull request,

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758671#comment-17758671 ] ASF GitHub Bot commented on MENFORCER-490: -- elharo merged PR #283: URL: https

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758670#comment-17758670 ] ASF GitHub Bot commented on MENFORCER-490: -- elharo merged PR #284: URL: https

[GitHub] [maven-enforcer] elharo merged pull request #284: [MENFORCER-490] Declare maven-enforcer-extension dependencies

2023-08-24 Thread via GitHub
elharo merged PR #284: URL: https://github.com/apache/maven-enforcer/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758635#comment-17758635 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758633#comment-17758633 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304514826 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304513934 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758632#comment-17758632 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on PR #1208: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
gnodet commented on PR #1208: URL: https://github.com/apache/maven/pull/1208#issuecomment-1691906581 @elharo I don't really see the need to spend much time on rewriting code copied from a utility class. The DefaultWagonManager is part of maven-compat, so deprecated and not really maintaine

[GitHub] [maven-build-cache-extension] atsteffen opened a new pull request, #98: Avoid hash calculation when is true

2023-08-24 Thread via GitHub
atsteffen opened a new pull request, #98: URL: https://github.com/apache/maven-build-cache-extension/pull/98 I have a large multi-module project with a top level project who only responsibility is to wrap together the other modules along with some large resources into a deployable zip or do

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758605#comment-17758605 ] ASF GitHub Bot commented on MENFORCER-490: -- elharo opened a new pull request,

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758553#comment-17758553 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304233854 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758550#comment-17758550 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1274774380 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758526#comment-17758526 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304179696 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Commented] (MDEP-832) Remove commons-collections-4

2023-08-24 Thread Eric Lilja (Jira)
[ https://issues.apache.org/jira/browse/MDEP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758525#comment-17758525 ] Eric Lilja commented on MDEP-832: - The commit removes a usage of commons-collections-4, but

[jira] [Created] (MSHADE-456) test-jar dependencies remain in POM after being shaded

2023-08-24 Thread Nick Tindall (Jira)
Nick Tindall created MSHADE-456: --- Summary: test-jar dependencies remain in POM after being shaded Key: MSHADE-456 URL: https://issues.apache.org/jira/browse/MSHADE-456 Project: Maven Shade Plugin

[jira] [Commented] (MENFORCER-490) Properly declare dependencies

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758522#comment-17758522 ] ASF GitHub Bot commented on MENFORCER-490: -- elharo opened a new pull request,

[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758517#comment-17758517 ] ASF GitHub Bot commented on MNG-6847: - timtebeek commented on PR #153: URL: https://gi

[GitHub] [maven-assembly-plugin] timtebeek commented on pull request #153: [MNG-6847] Use diamond operator

2023-08-24 Thread via GitHub
timtebeek commented on PR #153: URL: https://github.com/apache/maven-assembly-plugin/pull/153#issuecomment-1691447385 Force pushed the spotless fix. Is there any way for my PRs to skip the manual CI approval? I think that's usually the case when you've previously contributed, but I'v

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758515#comment-17758515 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-24 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304137698 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[jira] [Assigned] (SUREFIRE-2190) optional dependencies and JPMS modules confuse surefire

2023-08-24 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned SUREFIRE-2190: - Assignee: Henning Schmiedehausen > optional dependencies and JPMS mod

[jira] [Updated] (SUREFIRE-2190) optional dependencies and JPMS modules confuse surefire

2023-08-24 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated SUREFIRE-2190: -- Fix Version/s: 3.2.0 > optional dependencies and JPMS modules confuse surefi