atsteffen opened a new pull request, #98:
URL: https://github.com/apache/maven-build-cache-extension/pull/98
I have a large multi-module project with a top level project who only
responsibility is to wrap together the other modules along with some large
resources into a deployable zip or docker image. The top level project pulls
together enough stuff that it gives an array size limit error when trying to
calculate the cache for all of its inputs. Since this top level project should
always be rebuilt if any code changes, it is a good candidate for using
<maven.build.cache.skipCache>true<maven.build.cache.skipCache>. However, I
found that using this parameter does not actually prevent the calculation of
the hash. It seems reasonable to consider this parameter as disabling all
aspects of caching, including hash calculation and saving of the cached
artifact.
I realize this change is rather surgical, and a more involved refactor might
be warranted especially with respect to delicate boolean logic, and nullability
of inputInfo in CacheContext. However, before I start any refactoring I wanted
to make sure this issue was filed and discussed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [MBUILDCACHE JIRA
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
