[ 
https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758632#comment-17758632
 ] 

ASF GitHub Bot commented on MNG-7820:
-------------------------------------

gnodet commented on PR #1208:
URL: https://github.com/apache/maven/pull/1208#issuecomment-1691906581

   @elharo I don't really see the need to spend much time on rewriting code 
copied from a utility class.  The DefaultWagonManager is part of maven-compat, 
so deprecated and not really maintained. Any possible cleanup could introduce 
problems, so I'm more in favour of a blunt copy/paste, even if the code is not 
the cleanest, to avoid any possible behaviour difference with this legacy code.
   
   For information, I've successfully run the whole IT test suite after 
changing the DefaultWagonManager to throw exceptions instead of actually 
downloading/uploading anything using a Wagon (and disabling the 
DefaultWagonManagerTest UT).  However, it might still be in use by old plugins, 
so I would not delete it at this point (we do have warnings when using 
maven-compat since a few months afaik).  But I would not spend too much time on 
this code either...




> Remove dependency on plexus-utils
> ---------------------------------
>
>                 Key: MNG-7820
>                 URL: https://issues.apache.org/jira/browse/MNG-7820
>             Project: Maven
>          Issue Type: Task
>            Reporter: Guillaume Nodet
>            Priority: Major
>             Fix For: 4.0.0-alpha-8
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to