[jira] [Closed] (MENFORCER-451) Refresh download page

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-451. - Resolution: Fixed > Refresh download page > - > >

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #204: [MENFORCER-451] Refresh download page

2022-12-27 Thread GitBox
slawekjaranowski merged PR #204: URL: https://github.com/apache/maven-enforcer/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Updated] (MENFORCER-378) requireReleaseDeps does not support optional dependencies or runtime scope

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MENFORCER-378: -- Fix Version/s: 3.2.0 > requireReleaseDeps does not support optional dependen

[jira] [Commented] (MENFORCER-378) requireReleaseDeps does not support optional dependencies or runtime scope

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652328#comment-17652328 ] Slawomir Jaranowski commented on MENFORCER-378: --- Ok, I see that should b

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057973498 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057972238 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -134,9 +147,7 @@ public void execute() throws MojoExecutionExcepti

[jira] [Comment Edited] (MENFORCER-378) requireReleaseDeps does not support optional dependencies or runtime scope

2022-12-27 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652326#comment-17652326 ] Petr Široký edited comment on MENFORCER-378 at 12/27/22 11:15 PM: --

[jira] [Commented] (MENFORCER-378) requireReleaseDeps does not support optional dependencies or runtime scope

2022-12-27 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652326#comment-17652326 ] Petr Široký commented on MENFORCER-378: --- {{3.2.0-SNAPSHOT}} seems to behave the

[jira] [Commented] (MENFORCER-378) requireReleaseDeps does not support optional dependencies or runtime scope

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652321#comment-17652321 ] Slawomir Jaranowski commented on MENFORCER-378: --- To retest with 3.2.0-SN

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
slawekjaranowski commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057954678 ## maven-enforcer-plugin/src/it/projects/cli-skip-rules/invoker.properties: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (MENFORCER-378) requireReleaseDeps does not support optional dependencies or runtime scope

2022-12-27 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652320#comment-17652320 ] Petr Široký commented on MENFORCER-378: --- I tried to run the test project with pl

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #206: [MENFORCER-452] Manage all Maven Core dependencies as provided

2022-12-27 Thread GitBox
slawekjaranowski opened a new pull request, #206: URL: https://github.com/apache/maven-enforcer/pull/206 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[jira] [Closed] (SUREFIRE-2101) Phrased test names with missing @DisplayName result in a "null" test name

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2101. - Resolution: Fixed > Phrased test names with missing @DisplayName result in a "

[GitHub] [maven-surefire] slawekjaranowski merged pull request #587: [SUREFIRE-2101] JUnit5 console reporting: Fall back to class name

2022-12-27 Thread GitBox
slawekjaranowski merged PR #587: URL: https://github.com/apache/maven-surefire/pull/587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652315#comment-17652315 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks

2022-12-27 Thread GitBox
cstamas commented on code in PR #232: URL: https://github.com/apache/maven-resolver/pull/232#discussion_r1057927629 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -302,4 +302,39 @@ List newResolutionRepositories( RepositorySystemSession sess

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652311#comment-17652311 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #232

[GitHub] [maven-resolver] kwin commented on a diff in pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks

2022-12-27 Thread GitBox
kwin commented on code in PR #232: URL: https://github.com/apache/maven-resolver/pull/232#discussion_r1057923595 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -302,4 +302,39 @@ List newResolutionRepositories( RepositorySystemSession sessio

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057922405 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057922768 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057922405 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652309#comment-17652309 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #232

[GitHub] [maven-resolver] kwin commented on a diff in pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks

2022-12-27 Thread GitBox
kwin commented on code in PR #232: URL: https://github.com/apache/maven-resolver/pull/232#discussion_r1057922037 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -302,4 +302,39 @@ List newResolutionRepositories( RepositorySystemSession sessio

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057921554 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -242,22 +253,59 @@ public void execute() throws MojoExecutionExcep

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057920952 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -134,9 +147,7 @@ public void execute() throws MojoExecutionExcepti

[GitHub] [maven-enforcer] psiroky opened a new pull request, #205: [MENFORCER-431] Introduce property to skip specific rules

2022-12-27 Thread GitBox
psiroky opened a new pull request, #205: URL: https://github.com/apache/maven-enforcer/pull/205 I am creating this draft PR to discuss couple of points. This is not yet ready merge. See the inline comments. - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/b

[jira] [Comment Edited] (MNG-7640) Investigate which ITs really need to set system properties

2022-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652305#comment-17652305 ] Michael Osipov edited comment on MNG-7640 at 12/27/22 8:58 PM: --

[jira] (MNG-7640) Investigate which ITs really need to set system properties

2022-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7640 ] Michael Osipov deleted comment on MNG-7640: - was (Author: michael-o): After PR down to valid cases: {noformat} mosipov@mikaw10 MINGW64 /d/Entwicklung/Projekte/maven-integration-testing (MNG-764

[jira] [Commented] (MNG-7640) Investigate which ITs really need to set system properties

2022-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652305#comment-17652305 ] Michael Osipov commented on MNG-7640: - After PR not calls are left. > Investigate whic

[jira] [Created] (MENFORCER-452) Manage all Maven Core dependencies as provided

2022-12-27 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MENFORCER-452: - Summary: Manage all Maven Core dependencies as provided Key: MENFORCER-452 URL: https://issues.apache.org/jira/browse/MENFORCER-452 Project: Maven En

[jira] [Commented] (MRESOLVER-308) HTTP transport showdown

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652304#comment-17652304 ] ASF GitHub Bot commented on MRESOLVER-308: -- cstamas commented on PR #231: URL

[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.

2022-12-27 Thread GitBox
cstamas commented on PR #231: URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366150231 It does not work _currently_, but https://github.com/apache/maven-resolver/pull/232 is here to solve that bit as well (naturally, once that is merged, this PR will need changes: to h

[jira] [Commented] (MRESOLVER-308) HTTP transport showdown

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652303#comment-17652303 ] ASF GitHub Bot commented on MRESOLVER-308: -- rmannibucau commented on PR #231:

[GitHub] [maven-resolver] rmannibucau commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.

2022-12-27 Thread GitBox
rmannibucau commented on PR #231: URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366137758 My 2cts would be that `Java 11 HttpClient` is really worth it since it will, ultimately, enable to almost drop the resolver transitive stack when we'll be java >= 11 and go react

[jira] [Commented] (MRESOLVER-308) HTTP transport showdown

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652302#comment-17652302 ] ASF GitHub Bot commented on MRESOLVER-308: -- kwin commented on PR #231: URL: h

[GitHub] [maven-resolver] kwin commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.

2022-12-27 Thread GitBox
kwin commented on PR #231: URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366135447 Whether we ship with Maven or not is completely orthogonal to me. If they are part of resolver releases we should make sure they work properly and I don't see the capacity to maintain t

[jira] [Commented] (MRESOLVER-308) HTTP transport showdown

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652301#comment-17652301 ] ASF GitHub Bot commented on MRESOLVER-308: -- cstamas commented on PR #231: URL

[GitHub] [maven-resolver] cstamas commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.

2022-12-27 Thread GitBox
cstamas commented on PR #231: URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366133370 Just to clear up: the fact we have here 5 (7 to be exact) transports, that does not mean we need to deliver all these with Maven. Or in other words, transport-http, transport-file an

[jira] [Commented] (MRESOLVER-308) HTTP transport showdown

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652299#comment-17652299 ] ASF GitHub Bot commented on MRESOLVER-308: -- kwin commented on PR #231: URL: h

[GitHub] [maven-resolver] kwin commented on pull request #231: [MRESOLVER-308] HTTP transport showdown.

2022-12-27 Thread GitBox
kwin commented on PR #231: URL: https://github.com/apache/maven-resolver/pull/231#issuecomment-1366125656 > We just need a small decent set. Exactly, for me shipping 5 transport modules is too much. That also makes the decision for consumers much harder. -- This is an automated mes

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #204: [MENFORCER-451] Refresh download page

2022-12-27 Thread GitBox
slawekjaranowski opened a new pull request, #204: URL: https://github.com/apache/maven-enforcer/pull/204 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[jira] [Created] (MENFORCER-451) Refresh download page

2022-12-27 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MENFORCER-451: - Summary: Refresh download page Key: MENFORCER-451 URL: https://issues.apache.org/jira/browse/MENFORCER-451 Project: Maven Enforcer Plugin I

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #193: Avoid NullPointerException where there is no plugins

2022-12-27 Thread GitBox
slawekjaranowski commented on PR #193: URL: https://github.com/apache/maven-enforcer/pull/193#issuecomment-1366105743 Thanks for fix I assume that we can also remove `catch ( NullPointerException e )` patterns 😄 Please resolve conflicts, and create an issue for tracking. --

[jira] [Updated] (MNG-7653) Integrate resolver onSessionClose

2022-12-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7653: - Fix Version/s: 4.0.0-alpha-4 4.0.0 > Integrate resolver onSessionClose > ---

[jira] [Created] (MNG-7653) Integrate resolver onSessionClose

2022-12-27 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7653: Summary: Integrate resolver onSessionClose Key: MNG-7653 URL: https://issues.apache.org/jira/browse/MNG-7653 Project: Maven Issue Type: Task Compon

[jira] [Closed] (MENFORCER-450) Code cleanup

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-450. - Resolution: Fixed > Code cleanup > > > Key: MENFO

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #203: [MENFORCER-450] Code cleanup

2022-12-27 Thread GitBox
slawekjaranowski merged PR #203: URL: https://github.com/apache/maven-enforcer/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #568: [SUREFIRE-2117] Include package, outer classes in XML report for @Nested

2022-12-27 Thread GitBox
slawekjaranowski commented on code in PR #568: URL: https://github.com/apache/maven-surefire/pull/568#discussion_r1057843257 ## surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2117XmlReportingNestedIT.java: ## @@ -0,0 +1,120 @@ +package org.apache.maven.su

[jira] [Updated] (SUREFIRE-2101) Phrased test names with missing @DisplayName result in a "null" test name

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated SUREFIRE-2101: -- Fix Version/s: 3.0.0-M8 > Phrased test names with missing @DisplayName resul

[jira] [Assigned] (SUREFIRE-2101) Phrased test names with missing @DisplayName result in a "null" test name

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned SUREFIRE-2101: - Assignee: Slawomir Jaranowski > Phrased test names with missing @Disp

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #549: [SUREFIRE-2101] - Fixes 'null' phrased test names with JUnit5 without @DisplayName

2022-12-27 Thread GitBox
slawekjaranowski commented on PR #549: URL: https://github.com/apache/maven-surefire/pull/549#issuecomment-1366094560 @ascopes thanks I changed commit message to contains issue number in square brackets 😄 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [maven-surefire] slawekjaranowski merged pull request #549: [SUREFIRE-2101] - Fixes 'null' phrased test names with JUnit5 without @DisplayName

2022-12-27 Thread GitBox
slawekjaranowski merged PR #549: URL: https://github.com/apache/maven-surefire/pull/549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #568: [SUREFIRE-2117] Include package, outer classes in XML report for @Nested

2022-12-27 Thread GitBox
slawekjaranowski commented on code in PR #568: URL: https://github.com/apache/maven-surefire/pull/568#discussion_r1057835437 ## surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2117XmlReportingNestedIT.java: ## @@ -0,0 +1,120 @@ +package org.apache.maven.su

[GitHub] [maven-enforcer] dependabot[bot] commented on pull request #191: Bump maven-dependency-tree from 3.1.1 to 3.2.1

2022-12-27 Thread GitBox
dependabot[bot] commented on PR #191: URL: https://github.com/apache/maven-enforcer/pull/191#issuecomment-1366078402 Looks like org.apache.maven.shared:maven-dependency-tree is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service

[GitHub] [maven-enforcer] dependabot[bot] closed pull request #191: Bump maven-dependency-tree from 3.1.1 to 3.2.1

2022-12-27 Thread GitBox
dependabot[bot] closed pull request #191: Bump maven-dependency-tree from 3.1.1 to 3.2.1 URL: https://github.com/apache/maven-enforcer/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

2022-12-27 Thread GitBox
slawekjaranowski merged PR #202: URL: https://github.com/apache/maven-enforcer/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (MBUILDCACHE-32) Do not print exception when probing builds in remote repo

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652285#comment-17652285 ] ASF GitHub Bot commented on MBUILDCACHE-32: --- AlexanderAshitkin commented on

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #33: [MBUILDCACHE-32] Do not print exception when probing builds

2022-12-27 Thread GitBox
AlexanderAshitkin commented on PR #33: URL: https://github.com/apache/maven-build-cache-extension/pull/33#issuecomment-1366070210 > Both should end up in separate commits, otherwise finding git commits introducing regressions is much harder than it should be. Regression will not happ

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652277#comment-17652277 ] Slawomir Jaranowski commented on MNG-7648: -- Only for reference, I bisected and fou

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652270#comment-17652270 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas commented on PR #941: URL

[GitHub] [maven] cstamas commented on pull request #941: [MRESOLVER-302] Integrate onSessionClose

2022-12-27 Thread GitBox
cstamas commented on PR #941: URL: https://github.com/apache/maven/pull/941#issuecomment-1365978986 Locally Maven IT suite passes OK with this change (w/ locally built related PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652267#comment-17652267 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas opened a new pull request

[GitHub] [maven] cstamas opened a new pull request, #941: [MRESOLVER-302] Integrate onSessionClose

2022-12-27 Thread GitBox
cstamas opened a new pull request, #941: URL: https://github.com/apache/maven/pull/941 Depends on https://github.com/apache/maven-resolver/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652266#comment-17652266 ] ASF GitHub Bot commented on MRESOLVER-302: -- cstamas opened a new pull request

[GitHub] [maven-resolver] cstamas opened a new pull request, #232: [MRESOLVER-302] Introduce onSessionClose hooks

2022-12-27 Thread GitBox
cstamas opened a new pull request, #232: URL: https://github.com/apache/maven-resolver/pull/232 That integrators must integrate, to provide onSessionClosed hooks functionality to any component requiring it. --- https://issues.apache.org/jira/browse/MRESOLVER-302 -- This is a

[jira] [Assigned] (MRESOLVER-302) Introduce onSession close

2022-12-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-302: - Assignee: Tamas Cservenak > Introduce onSession close > -

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652229#comment-17652229 ] ASF GitHub Bot commented on MNG-7648: - pavelhoral commented on PR #940: URL: https://gi

[GitHub] [maven] pavelhoral commented on pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-27 Thread GitBox
pavelhoral commented on PR #940: URL: https://github.com/apache/maven/pull/940#issuecomment-1365831055 I can verify that with the fixed version I am able to successfully build my test project (i.e. this fix fixes problems in enforcer): ```console $ ../apache-maven-4.0.0-alpha-4-SNA

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652225#comment-17652225 ] Slawomir Jaranowski commented on MNG-7648: -- [~pavel.horal] thanks for investigatio

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652227#comment-17652227 ] ASF GitHub Bot commented on MNG-7648: - pavelhoral opened a new pull request, #940: URL:

[GitHub] [maven] pavelhoral opened a new pull request, #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-27 Thread GitBox
pavelhoral opened a new pull request, #940: URL: https://github.com/apache/maven/pull/940 This fixes missing `locationTracking` in project model. Missing `locationTracking` was causing issues down the line in enforcer plugin that was not able to verify source of the model configuratio

[jira] [Commented] (MNG-7590) Allow configure resolver by properties in settings.xml

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652224#comment-17652224 ] Slawomir Jaranowski commented on MNG-7590: -- [~hboutemy] Unfortunately there are no

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread Pavel Horal (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652221#comment-17652221 ] Pavel Horal commented on MNG-7648: -- Ah... it is actually pretty simple - copy constructor

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread Pavel Horal (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652218#comment-17652218 ] Pavel Horal commented on MNG-7648: -- I have tried to debug the code flow and end up in Defa

[jira] [Created] (MNG-7652) switch to Modello Velocity Maven plugin

2022-12-27 Thread Herve Boutemy (Jira)
Herve Boutemy created MNG-7652: -- Summary: switch to Modello Velocity Maven plugin Key: MNG-7652 URL: https://issues.apache.org/jira/browse/MNG-7652 Project: Maven Issue Type: Sub-task

[jira] [Updated] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7571: --- Description: immutable API added in MNG-7553 api directory but maven-api documentation url https://mav

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #203: [MENFORCER-450] Code cleanup

2022-12-27 Thread GitBox
slawekjaranowski opened a new pull request, #203: URL: https://github.com/apache/maven-enforcer/pull/203 - remove not needed throws - remove custom EnforcerExpressionEvaluator - remove not needed toString() - use diamond operator --- Following this checklist to help us inco

[jira] [Updated] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread Pavel Horal (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Horal updated MNG-7648: - Description: -Generated model reader is not setting {{location}} property - [https://github.com/apache/mav

[jira] [Created] (MENFORCER-450) Code cleanup

2022-12-27 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MENFORCER-450: - Summary: Code cleanup Key: MENFORCER-450 URL: https://issues.apache.org/jira/browse/MENFORCER-450 Project: Maven Enforcer Plugin Issue Type

[jira] [Updated] (MENFORCER-437) DependencyConvergence treats provided dependencies are runtime dependencies

2022-12-27 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MENFORCER-437: -- Fix Version/s: 3.2.0 > DependencyConvergence treats provided dependencies ar

[jira] [Updated] (MNG-7648) Generated model reader is not setting location information

2022-12-27 Thread Pavel Horal (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Horal updated MNG-7648: - Component/s: Core (was: Toolchains) > Generated model reader is not setting location i

[jira] [Assigned] (MSHARED-1175) describe from and to in "Copying x resources" info message

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy reassigned MSHARED-1175: -- Assignee: Herve Boutemy > describe from and to in "Copying x resources" info message

[jira] [Assigned] (MRESOURCES-292) describe from and to in "Copying x resources" info message

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy reassigned MRESOURCES-292: Assignee: Herve Boutemy > describe from and to in "Copying x resources" info m

[jira] [Assigned] (MRESOURCES-288) make tests jar reproducible

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy reassigned MRESOURCES-288: Assignee: Herve Boutemy > make tests jar reproducible > --

[jira] [Updated] (MRESOURCES-288) make tests jar reproducible

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MRESOURCES-288: - Summary: make tests jar reproducible (was: make test jar reproducible) > make tests

[GitHub] [maven-resources-plugin] hboutemy opened a new pull request, #44: [MRRESOURCES-288] keep only useful content for IT

2022-12-27 Thread GitBox
hboutemy opened a new pull request, #44: URL: https://github.com/apache/maven-resources-plugin/pull/44 https://issues.apache.org/jira/browse/MRESOURCES-288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (MRESOURCES-288) make test jar reproducible

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571018#comment-17571018 ] Herve Boutemy edited comment on MRESOURCES-288 at 12/27/22 9:37 AM: ---

[jira] [Comment Edited] (MRESOURCES-288) make test jar reproducible

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570692#comment-17570692 ] Herve Boutemy edited comment on MRESOURCES-288 at 12/27/22 9:34 AM: ---

[jira] [Comment Edited] (MRESOURCES-288) make test jar reproducible

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572276#comment-17572276 ] Herve Boutemy edited comment on MRESOURCES-288 at 12/27/22 9:32 AM: ---

[jira] [Commented] (MNG-7590) Allow configure resolver by properties in settings.xml

2022-12-27 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652187#comment-17652187 ] Herve Boutemy commented on MNG-7590: [~sjaranowski] is there any documentation written