psiroky commented on code in PR #205:
URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057922405
##########
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java:
##########
@@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {
@Parameter(required = false, property = "rules")
private String[] commandLineRules;
+ /**
+ * Array of Strings that matches the EnforcerRules to skip.
+ *
+ * @since 3.2.0
+ */
+ @Parameter(required = false, property = "enforcer.skipRules")
+ private String[] commandLineRulesToSkip;
Review Comment:
I don't really like the field name here, since this represents a property
value, which may not be supplied via command line at all, but instead via a
property in pom.xml. I understand that the main use case is likely to override
the rules via cmd line, but still seems a bit weird.
On the other hand, since the other property (`commandLineRules`) is already
using this name it only makes sense to be consistent. So either rename both or
none (hopefully renaming the field would not be considered a breaking change
since it is `private`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
