psiroky commented on code in PR #205:
URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057973498


##########
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java:
##########
@@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {
     @Parameter(required = false, property = "rules")
     private String[] commandLineRules;
 
+    /**
+     * Array of Strings that matches the EnforcerRules to skip.
+     *
+     * @since 3.2.0
+     */
+    @Parameter(required = false, property = "enforcer.skipRules")
+    private String[] commandLineRulesToSkip;

Review Comment:
   Thanks for the additional info. I guess these are a bit specific since users 
likely won't use them directly in pom.xml config section, but rather via a 
property.
   
   One more thing I am not sure about is the property name. `skipRules` may 
suggest that it is a boolean property, which is not the case here. I could not 
come up with a better name
    * `rulesToSkip` seems weird as well
    * `skippedRules` - not sure about the past tense?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to