[jira] [Commented] (MRESOLVER-283) Introduce resolver wide "shared" executor service

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628108#comment-17628108 ] ASF GitHub Bot commented on MRESOLVER-283: -- caiwei-ebay commented on code in

[GitHub] [maven-resolver] caiwei-ebay commented on a diff in pull request #213: [MRESOLVER-283] Shared executor

2022-11-02 Thread GitBox
caiwei-ebay commented on code in PR #213: URL: https://github.com/apache/maven-resolver/pull/213#discussion_r1012479745 ## maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java: ## @@ -656,18 +622,4 @@ private void uploadCh

[GitHub] [maven-enforcer] fdfea commented on pull request #136: [MENFORCER-411] DependencyConvergence takes include/exclude parameters to filter errors

2022-11-02 Thread GitBox
fdfea commented on PR #136: URL: https://github.com/apache/maven-enforcer/pull/136#issuecomment-1301618106 Hi @slawekjaranowski , I forgot about this PR. Thanks for taking a look at it. I've addressed your comments and rebased with master. Please take another look when you get a chance.

[jira] [Commented] (MRESOLVER-283) Introduce resolver wide "shared" executor service

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628098#comment-17628098 ] ASF GitHub Bot commented on MRESOLVER-283: -- caiwei-ebay commented on code in

[GitHub] [maven-resolver] caiwei-ebay commented on a diff in pull request #213: [MRESOLVER-283] Shared executor

2022-11-02 Thread GitBox
caiwei-ebay commented on code in PR #213: URL: https://github.com/apache/maven-resolver/pull/213#discussion_r1012476849 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/concurrency/DefaultResolverExecutor.java: ## @@ -0,0 +1,115 @@ +package org.eclipse.aethe

[jira] [Commented] (MBUILDCACHE-33) Support remote cache credentials from environment variables

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628085#comment-17628085 ] ASF GitHub Bot commented on MBUILDCACHE-33: --- AlexanderAshitkin opened a new

[jira] [Updated] (MBUILDCACHE-33) Support remote cache credentials from environment variables

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MBUILDCACHE-33: -- Labels: pull-request-available (was: ) > Support remote cache credentials from env

[GitHub] [maven-build-cache-extension] AlexanderAshitkin opened a new pull request, #35: [MBUILDCACHE-33] Allow to set remote cache credentials from env vars

2022-11-02 Thread GitBox
AlexanderAshitkin opened a new pull request, #35: URL: https://github.com/apache/maven-build-cache-extension/pull/35 Introduces set of environment variables to provide remote cache settings from environment variables. The feature is to support cases when developers do not have access to

[jira] [Commented] (MRESOLVER-283) Introduce resolver wide "shared" executor service

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628037#comment-17628037 ] ASF GitHub Bot commented on MRESOLVER-283: -- caiwei-ebay commented on PR #213:

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #213: [MRESOLVER-283] Shared executor

2022-11-02 Thread GitBox
caiwei-ebay commented on PR #213: URL: https://github.com/apache/maven-resolver/pull/213#issuecomment-1301528882 @cstamas The PR looks good to me. Thanks for the quick fix. My main concern is about how to tell user pom/metadata.xml is downloaded in parallel now with BF collector.

[jira] [Updated] (MBUILDCACHE-33) Support remote cache credentials from environment variables

2022-11-02 Thread Alexander Ashitkin (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Ashitkin updated MBUILDCACHE-33: -- Issue Type: New Feature (was: Bug) > Support remote cache credentials from

[jira] [Created] (MBUILDCACHE-33) Support remote cache credentials from environment variables

2022-11-02 Thread Alexander Ashitkin (Jira)
Alexander Ashitkin created MBUILDCACHE-33: - Summary: Support remote cache credentials from environment variables Key: MBUILDCACHE-33 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-33

[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
HannesWell commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012333852 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: That's right Guillaume Nodet was not av

[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
slawekjaranowski commented on PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#issuecomment-1301311704 As I wrote early, I feel we need discus it again. For case as java util logging we need a bridge from jul to slf4j. -- This is an automated message from the Ap

[GitHub] [maven-dependency-analyzer] slachiewicz commented on pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
slachiewicz commented on PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#issuecomment-1301281631 Maven simply supports only slf4j based logging and nothing else: https://github.com/apache/maven/blob/maven-3.9.x/maven-embedder/src/main/resources/META-INF/maven/slf4j-

[jira] [Assigned] (MRESOLVER-283) Introduce resolver wide "shared" executor service

2022-11-02 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-283: - Assignee: Tamas Cservenak > Introduce resolver wide "shared" executor service

[jira] [Assigned] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-282: - Assignee: Tamas Cservenak > Drop PartialFile > > >

[GitHub] [maven-dependency-analyzer] elharo commented on pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
elharo commented on PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#issuecomment-1301105269 The info you found was written 10+ years ago and predates log4shell. It might even go as far back as a time when Maven supported Java 1.3. If these logs are still visi

[jira] [Closed] (MINSTALL-182) Bump mockito-core from 2.28.2 to 4.8.1

2022-11-02 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINSTALL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINSTALL-182. Resolution: Fixed > Bump mockito-core from 2.28.2 to 4.8.1 >

[jira] [Created] (MINSTALL-182) Bump mockito-core from 2.28.2 to 4.8.1

2022-11-02 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINSTALL-182: Summary: Bump mockito-core from 2.28.2 to 4.8.1 Key: MINSTALL-182 URL: https://issues.apache.org/jira/browse/MINSTALL-182 Project: Maven Install Plugin

[GitHub] [maven-install-plugin] slawekjaranowski merged pull request #40: Bump mockito-core from 2.28.2 to 4.8.1

2022-11-02 Thread GitBox
slawekjaranowski merged PR #40: URL: https://github.com/apache/maven-install-plugin/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-dependency-plugin] cstamas commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
cstamas commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012099254 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: > Indeed that would be bad and was the rea

[jira] [Commented] (MRESOLVER-283) Introduce resolver wide "shared" executor service

2022-11-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627852#comment-17627852 ] Michael Osipov commented on MRESOLVER-283: -- Good idea. > Introduce resolver

[GitHub] [maven-dependency-plugin] cstamas commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
cstamas commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012099254 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: > Indeed that would be bad and was the rea

[GitHub] [maven-dependency-plugin] HannesWell commented on pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
HannesWell commented on PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#issuecomment-1300976071 > @kwin @HannesWell what about adding the lifecycle mappings in https://github.com/eclipse-m2e/m2e-core/blob/master/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml a

[GitHub] [maven-resolver] cstamas commented on pull request #211: [EXPERIMENT] Drop DELETE_ON_CLOSE flag

2022-11-02 Thread GitBox
cstamas commented on PR #211: URL: https://github.com/apache/maven-resolver/pull/211#issuecomment-1300971295 This experiment "works" at the cost of leaving $M2_REPO/.locks/ full of 0 byte lock files. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
HannesWell commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012086763 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: > Imagine if every IDE ask for storing

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300966878 2nd experiment: do what Java folks did: retry and hope the best: https://github.com/apache/maven-resolver/pull/214 Patch JAR: [maven-resolver-named-locks-1.7.3.jar.zip](

[GitHub] [maven-resolver] cstamas opened a new pull request, #214: [EXPERIMENT] Do what Java does: retry and hope the best

2022-11-02 Thread GitBox
cstamas opened a new pull request, #214: URL: https://github.com/apache/maven-resolver/pull/214 Java in bugfix for [1] does very same thing: on AccessDeniedEx it just retries. Here, the existing Retry utility is extended, and now "retry for given time" new method added "retry for given a

[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
HannesWell commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012077261 ## pom.xml: ## @@ -247,6 +247,15 @@ under the License. ${resolverVersion} provided + Review Comment: Btw. the website is b

[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
HannesWell commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012076647 ## src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java: ## @@ -59,6 +60,21 @@ @Component private ArchiverManager a

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300857846 Roger that, later evening, or tomorrow will prep alternative patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-mvnd] taclano opened a new issue, #731: maven dependency plugin missing pom: mvnd gives error <=> stock mvn warning

2022-11-02 Thread GitBox
taclano opened a new issue, #731: URL: https://github.com/apache/maven-mvnd/issues/731 Hi, In our project we are trying to use mvnd to speed up our build. We use the maven dependency plugin to fetch from a remote repository some files ( yaml-files ), these artifacts do not cont

[jira] [Created] (MNGSITE-498) Clarify procedure for restarting releases

2022-11-02 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MNGSITE-498: --- Summary: Clarify procedure for restarting releases Key: MNGSITE-498 URL: https://issues.apache.org/jira/browse/MNGSITE-498 Project: Maven Project Web Sit

[GitHub] [maven-mvnd] fsmherrm commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
fsmherrm commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300762954 @cstamas : I am willing to test more :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300739597 If you are willing to test more, i can prepare a similar patch like the "symptom patch" is in java... Also, let's keep the discussion here. -- This is an automated message

[GitHub] [maven-resolver] fsmherrm commented on pull request #211: [EXPERIMENT] Drop DELETE_ON_CLOSE flag

2022-11-02 Thread GitBox
fsmherrm commented on PR #211: URL: https://github.com/apache/maven-resolver/pull/211#issuecomment-1300724651 Is there a possibility to clean it up during daemon idle time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300715189 Sadly, this is the "price" to make it work on Windows that has very quirky locking semantics, see the patch https://github.com/apache/maven-resolver/pull/211 -- This is an automa

[GitHub] [maven-dependency-analyzer] Koziolek commented on pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
Koziolek commented on PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#issuecomment-1300675875 Ok, I found this » https://maven.apache.org/maven-logging.html > We have reached the decision that [SLF4J](http://slf4j.org/) is the best option for a logging API: S

[GitHub] [maven-mvnd] fsmherrm commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
fsmherrm commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300668591 @cstamas: It seems to work now :) but I need to run it multiple times to be sure as I am not able to always reproduce it before. But as a result, the folder .locks is now pop

[jira] [Updated] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-282: -- Description: Drop {{PartialFile}} that may cause locking issues, the drawback is to

[jira] [Created] (MRESOLVER-283) Introduce resolver wide "shared" executor service

2022-11-02 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-283: - Summary: Introduce resolver wide "shared" executor service Key: MRESOLVER-283 URL: https://issues.apache.org/jira/browse/MRESOLVER-283 Project: Maven Resolve

[GitHub] [maven-resolver] cstamas commented on pull request #213: Shared executor

2022-11-02 Thread GitBox
cstamas commented on PR #213: URL: https://github.com/apache/maven-resolver/pull/213#issuecomment-1300539170 @caiwei-ebay ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
slawekjaranowski commented on PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#issuecomment-1300524844 I did a test, I added t oa plugin code: ``` logger.info( "Log info 1 from Java utils" ); logger.info( "Log info 2 from Java utils" );

[GitHub] [maven-resolver] cstamas opened a new pull request, #213: Shared executor

2022-11-02 Thread GitBox
cstamas opened a new pull request, #213: URL: https://github.com/apache/maven-resolver/pull/213 Now that we have shutdown hook, and context parameters, this is possible. Simplest possible but shared executor implementation. -- This is an automated message from the Apache Git Service

[jira] [Commented] (MGPG-91) Compatibility with Maven 4

2022-11-02 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MGPG-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627689#comment-17627689 ] Slawomir Jaranowski commented on MGPG-91: - Probably duplicated of MGPG-74 But yes w

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1300336915 @fsmherrm any results? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-dependency-plugin] mickaelistria commented on pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
mickaelistria commented on PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#issuecomment-1300330087 @kwin @HannesWell what about adding the lifecycle mappings in https://github.com/eclipse-m2e/m2e-core/blob/master/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml

[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
kwin commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011702026 ## src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java: ## @@ -59,6 +60,21 @@ @Component private ArchiverManager archive

[GitHub] [maven-dependency-plugin] olamy commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
olamy commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011681071 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: which should have never been accepted

[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
kwin commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: Fact is: There is no other metadata for any o

[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
kwin commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: Fact is: There is no other metadata defined f

[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
kwin commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: Fact is: There is no other metadata for any o

[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
kwin commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: Fact is: There is no other metadata for any o

[jira] [Commented] (MGPG-91) Compatibility with Maven 4

2022-11-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MGPG-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627672#comment-17627672 ] Michael Osipov commented on MGPG-91: This I cannot tell, but GPG with the current produc

[jira] [Comment Edited] (MGPG-91) Compatibility with Maven 4

2022-11-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MGPG-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627672#comment-17627672 ] Michael Osipov edited comment on MGPG-91 at 11/2/22 12:19 PM: --

[jira] [Commented] (MGPG-91) Compatibility with Maven 4

2022-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/MGPG-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627667#comment-17627667 ] Jorge Solórzano commented on MGPG-91: - So essentially maven-gpg-plugin will be deprecate

[jira] [Commented] (MGPG-91) Compatibility with Maven 4

2022-11-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MGPG-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627664#comment-17627664 ] Michael Osipov commented on MGPG-91: This cannot be addressed because GPG cannot sign st

[jira] [Created] (MGPG-91) Compatibility with Maven 4

2022-11-02 Thread Jira
Jorge Solórzano created MGPG-91: --- Summary: Compatibility with Maven 4 Key: MGPG-91 URL: https://issues.apache.org/jira/browse/MGPG-91 Project: Maven GPG Plugin Issue Type: Improvement Affec

[GitHub] [maven-dependency-plugin] olamy commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
olamy commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011609215 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: is there option to not store such specific I

[GitHub] [maven-dependency-plugin] olamy commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
olamy commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011609215 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: is there option to not store such specific I

[jira] [Commented] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627618#comment-17627618 ] ASF GitHub Bot commented on MRESOLVER-282: -- michael-o commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

2022-11-02 Thread GitBox
michael-o commented on code in PR #212: URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011588336 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -592,16 +594,25 @@ public void handle( HttpResponse

[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on a diff in pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
slawekjaranowski commented on code in PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#discussion_r1011583444 ## pom.xml: ## @@ -95,6 +96,12 @@ 9.3 + Review Comment: @elharo @Koziolek My question is still open how java logging

[GitHub] [maven-dependency-analyzer] Koziolek commented on a diff in pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-11-02 Thread GitBox
Koziolek commented on code in PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#discussion_r1011534616 ## pom.xml: ## @@ -95,6 +96,12 @@ 9.3 + Review Comment: @elharo done. I removed slf4j and Java Core Logger is in use now. --

[jira] [Commented] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627585#comment-17627585 ] ASF GitHub Bot commented on MRESOLVER-282: -- michael-o commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

2022-11-02 Thread GitBox
michael-o commented on code in PR #212: URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011507129 ## maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/transport/wagon/WagonTransporter.java: ## @@ -548,35 +530,25 @@ public void run( Wagon wagon )

[jira] [Commented] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627574#comment-17627574 ] ASF GitHub Bot commented on MRESOLVER-282: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

2022-11-02 Thread GitBox
cstamas commented on code in PR #212: URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011473543 ## maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/transport/wagon/WagonTransporter.java: ## @@ -548,35 +530,25 @@ public void run( Wagon wagon )

[jira] [Commented] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627572#comment-17627572 ] ASF GitHub Bot commented on MRESOLVER-282: -- michael-o commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

2022-11-02 Thread GitBox
michael-o commented on code in PR #212: URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011466776 ## maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/transport/wagon/WagonTransporter.java: ## @@ -548,35 +530,25 @@ public void run( Wagon wagon )

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1299938246 [maven-resolver-named-locks-1.7.3.jar.zip](https://github.com/apache/maven-mvnd/files/9918951/maven-resolver-named-locks-1.7.3.jar.zip) Just remove the `.zip` suffix from file

[GitHub] [maven-dependency-plugin] mickaelistria commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata

2022-11-02 Thread GitBox
mickaelistria commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011466870 ## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ## @@ -0,0 +1,68 @@ + + Review Comment: Eclipse and its derivative, such as

[GitHub] [maven-mvnd] michael-o commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
michael-o commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1299936072 You can rename to .txt and upload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1299935446 Sadly no, GH does not allow JAR uploads (was my initial intent and was suprised to see that)... -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [maven-mvnd] fsmherrm commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
fsmherrm commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1299932500 @cstamas: yes, sorry. Can you provide it via github? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627562#comment-17627562 ] ASF GitHub Bot commented on MRESOLVER-282: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

2022-11-02 Thread GitBox
cstamas commented on code in PR #212: URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011453560 ## maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumValidator.java: ## @@ -85,13 +82,12 @@ boolean fetchChecksum( URI remote

[GitHub] [maven-mvnd] cstamas commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
cstamas commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1299917823 > @cstamas: Are you able to upload the patched jar somewhere else e.g. onedrive? Is in Google Drive, or is that not reachable to you? -- This is an automated message from t

[GitHub] [maven-mvnd] fsmherrm commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"

2022-11-02 Thread GitBox
fsmherrm commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1299913766 @cstamas: Are you able to upload the patched jar somewhere else e.g. onedrive? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627545#comment-17627545 ] ASF GitHub Bot commented on MRESOLVER-282: -- michael-o commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

2022-11-02 Thread GitBox
michael-o commented on code in PR #212: URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011403386 ## maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumValidator.java: ## @@ -85,13 +82,12 @@ boolean fetchChecksum( URI remo

[jira] [Updated] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-282: - Issue Type: Task (was: Dependency upgrade) > Drop PartialFile > > >

[jira] [Created] (MRESOLVER-282) Drop PartialFile

2022-11-02 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-282: - Summary: Drop PartialFile Key: MRESOLVER-282 URL: https://issues.apache.org/jira/browse/MRESOLVER-282 Project: Maven Resolver Issue Type: Dependenc

[GitHub] [maven-integration-testing] pzygielo commented on pull request #205: [MNG-7568] Test for deactivating profile defined in settings and project

2022-11-02 Thread GitBox
pzygielo commented on PR #205: URL: https://github.com/apache/maven-integration-testing/pull/205#issuecomment-1299773264 I pushed updated version range. I imagine this will make test to be skipped for all previous, unfixed maven versions and will fire otherwise for 3.x. -- This is an aut

[GitHub] [maven-integration-testing] pzygielo commented on pull request #205: [MNG-7568] Test for deactivating profile defined in settings and project

2022-11-02 Thread GitBox
pzygielo commented on PR #205: URL: https://github.com/apache/maven-integration-testing/pull/205#issuecomment-1299759340 > @pzygielo it looks like the ITs are failing. They used to succeed, right? The new test fails with maven up to 3.8.6. It would pass with - apache/maven#850

[GitHub] [maven-integration-testing] MartinKanters commented on pull request #205: [MNG-7568] Test for deactivating profile defined in settings and project

2022-11-02 Thread GitBox
MartinKanters commented on PR #205: URL: https://github.com/apache/maven-integration-testing/pull/205#issuecomment-1299732643 @pzygielo it looks like the ITs are failing. They used to succeed, right? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-integration-testing] MartinKanters commented on pull request #205: [MNG-7568] Test for deactivating profile defined in settings and project

2022-11-02 Thread GitBox
MartinKanters commented on PR #205: URL: https://github.com/apache/maven-integration-testing/pull/205#issuecomment-1299718025 Sorry that it takes so long to get it merged. I should have some time on Friday merge your PRs. -- This is an automated message from the Apache Git Service. To re

[GitHub] [maven-surefire] SimonBaars commented on pull request #575: [SUREFIRE-1654] Remove deprecated `forkMode` parameter

2022-11-02 Thread GitBox
SimonBaars commented on PR #575: URL: https://github.com/apache/maven-surefire/pull/575#issuecomment-1299683827 Hey, I resolved the failing tests (except for `ubuntu-latest jdk-18-temurin`, but that also fails on`master`). Can someone else do a review? Maybe @slawekjaranowski since you also