[
https://issues.apache.org/jira/browse/MRESOLVER-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627562#comment-17627562
]
ASF GitHub Bot commented on MRESOLVER-282:
------------------------------------------
cstamas commented on code in PR #212:
URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011453560
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumValidator.java:
##########
@@ -85,13 +82,12 @@ boolean fetchChecksum( URI remote, File local )
{
this.dataFile = dataFile;
this.checksumAlgorithmFactories = checksumAlgorithmFactories;
- this.tempFiles = new HashSet<>();
this.fileProcessor = fileProcessor;
this.checksumFetcher = checksumFetcher;
this.checksumPolicy = checksumPolicy;
this.providedChecksums = providedChecksums;
this.checksumLocations = checksumLocations;
- this.checksumFiles = new HashMap<>();
+ this.checksumExpectedValues = new HashMap<>();
Review Comment:
Yes, that map has checksum Files as keys (their final files, not tmp or so)
and values are the "expected" ones as Strings, no more Object and so on....
> Drop PartialFile
> ----------------
>
> Key: MRESOLVER-282
> URL: https://issues.apache.org/jira/browse/MRESOLVER-282
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> Drop {{PartialFile}} that may cause locking issues, the drawback is to loose
> "resumable downloads".
> Also, clear up the temp file usage around it, and simplify resource handling.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
