[
https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628037#comment-17628037
]
ASF GitHub Bot commented on MRESOLVER-283:
------------------------------------------
caiwei-ebay commented on PR #213:
URL: https://github.com/apache/maven-resolver/pull/213#issuecomment-1301528882
@cstamas
The PR looks good to me. Thanks for the quick fix.
My main concern is about how to tell user pom/metadata.xml is downloaded in
parallel now with BF collector.
As the special param "aether.dependencyCollector.bf.threads" has to be
removed using SharedExecutor, could you put some lines to explain the parallel
download behavior in param "aether.dependencyCollector.impl" where you've
introduced BF and DF. With such information, user may try the BF and feedback
so we can discuss whether BF could be the default based on the feedbacks.
> Introduce resolver wide "shared" executor service
> -------------------------------------------------
>
> Key: MRESOLVER-283
> URL: https://issues.apache.org/jira/browse/MRESOLVER-283
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.0
>
>
> More and more component in resolver does parallel processing (BF collector,
> MD resolver, basic connector), and they all create, maintain their own
> executor instance.
> Instead of this, create one shared "thread pool" (executor) component and
> just share it accross resovler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
