MartinKanters commented on a change in pull request #459:
URL: https://github.com/apache/maven/pull/459#discussion_r606099395
##
File path:
maven-core/src/test/java/org/apache/maven/graph/DefaultGraphBuilderTest.java
##
@@ -390,6 +400,7 @@ private Dependency toDependency( Mave
[
https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313437#comment-17313437
]
Henning Schmiedehausen commented on MRELEASE-1042:
--
With the 3.0.0-M1
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605924419
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605924120
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605894867
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
#
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605894867
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
#
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605894387
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
#
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605883578
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605882860
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605882185
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605881464
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605881464
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
elharo merged pull request #18:
URL: https://github.com/apache/maven-jar-plugin/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
Tibor17 edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-812088775
You have a plenty of commits in here and I saw [a lock for
file](https://github.com/apache/maven-resolver/pull/77/commits/6d5581510f613b9e2f8c774c6691a358f6eb04d1#diff-
Tibor17 commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-812088775
You have a plenty of commits in here and I saw a lock for file. My goal was
to avoid the lock.
-- for explaining why it was related.
Cheers
Tibor
--
This is an aut
Tibor17 commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812087636
If the assertion statement fails, we would see a complete array in the log,
the index of element and types which do not match. So it will be very verbose
report. That's the
Tibor17 commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812086654
This would work
`assertThat( provider.getFilters() ).asList().element( 0 ).isInstanceOf(
TestEngine.class )`
--
This is an automated message from the Apache Git Servic
adam11grafik commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812078484
I check and there is no method: .element()
assertThat( provider.getFilters() ).element( 0 )
getFilters() return array so maybe this is the reason
--
This is an
Tibor17 edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811832259
@hboutemy
@cstamas
@michael-o
Some long time ago I was talking about the following idea in our Slack.
It was about atomic move for the artifact. Maybe the
Tibor17 commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812034002
Now this looks much better. Pls fix the line length.
Are you going to use the `isInstanceOf` in several tests?
--
This is an automated message from the Apache Git Servi
adam11grafik edited a comment on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811936118
@Tibor17, I got errors here now:
Error:
src\test\java\org\apache\maven\surefire\junitplatform\JUnitPlatformProviderTest.java:[892]
(sizes) LineLength: Line
adam11grafik commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811936118
@Tibor17, I got errors here now:
Error:
src\test\java\org\apache\maven\surefire\junitplatform\JUnitPlatformProviderTest.java:[892]
(sizes) LineLength: Line is lon
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605676523
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
#
cstamas commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811916624
@Tibor17 agreed, the use of atomic move in resolver is out of scope for this
PR.
Re atomic move, it was used throughout Proximity/Nexus/1/2 since Java7 came
out with i
michael-o commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811833880
>
>
> @hboutemy
> @cstamas
> @michael-o
> Some long time ago I was talking about the following isea in our Slack.
> It was about atomic move for the artif
Tibor17 edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811832259
@hboutemy
@cstamas
@michael-o
Some long time ago I was talking about the following isea in our Slack.
It was about atomic move for the artifact. Maybe the
Tibor17 edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811832259
@hboutemy
@cstamas
@michael-o
Some long time ago I was talking about the following isea in our Slack.
It was about atomic move for the artifact. Maybe the
Tibor17 commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811832259
@hboutemy
@cstamas
@michael-o
Some long time ago I was talking about the following isea in our Slack.
It was about atomic move for the artifact. Maybe the lock f
michael-o commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811828377
Let me go through this today/tomorrow. Thanks for the elaborate response!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811824284
> A left a few comments, please go through.
>
> * I have a few more homework to do because I do not fully understand all
involved layers with `AdaptedReadWriteLo
cstamas commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811824284
> A left a few comments, please go through.
>
> * I have a few more homework to do because I do not fully understand all
involved layers with `AdaptedReadWriteLockNamed
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605556278
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NamedSyncContextFactory.java
##
@@ -0,0 +1,128 @@
+packag
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r60998
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NamedSyncContextFactory.java
##
@@ -0,0 +1,128 @@
+packag
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r60586
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
##
@@ -0,0 +1,86 @@
+packa
michael-o commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605551000
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
##
@@ -0,0 +1,86 @@
+pac
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605548725
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1568,13 +1572,13 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605547899
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -59,6 +62,7 @@
import org.apache
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as they are, so `Type variable = new Type()`, in cases when the variable
is strictly loca
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605541753
##
File path:
maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java
##
@@ -0,0 +1,88 @@
+package org.
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605541753
##
File path:
maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java
##
@@ -0,0 +1,88 @@
+package org.
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605539574
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/GAVNameMapper.java
##
@@ -0,0 +1,89 @@
+package org
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605539574
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/GAVNameMapper.java
##
@@ -0,0 +1,89 @@
+package org
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605533224
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605525855
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NamedSyncContextFactory.java
##
@@ -0,0 +1,128 @@
+packag
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605525340
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/StaticNameMapper.java
##
@@ -0,0 +1,78 @@
+package
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605523316
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/takari/TakariNameMapper.java
##
@@ -0,0 +1,98 @@
+p
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605522828
##
File path:
maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/NamedLockFactorySupport.java
##
@@ -0,0 +1,88 @@
+package org.
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as they are, so `T variable = new T()`, in cases when the variable is
strictly local scop
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as `T variable = new T()`, in cases when the variable is strictly local
scoped. I really
cstamas commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as `T variable = new T()`, in cases when the variable is strictly local
scoped. I really see no
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605520475
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/impl/guice/AetherModule.java
##
@@ -146,10 +161,77 @@ protected void configure()
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605520269
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
#
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605516892
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/DefaultSyncContextFactory.java
##
@@ -0,0 +1,86 @@
+packa
[
https://issues.apache.org/jira/browse/MNG-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313045#comment-17313045
]
Michael Osipov commented on MNG-7133:
-
I wonder whether some Plexus components needs to
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605494931
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private
adam11grafik commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605492296
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605492071
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605492071
##
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##
@@
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605488089
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605488089
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605484137
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605484013
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605484013
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605484013
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605482069
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605481968
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##
@@ -1560,6 +1566,18 @@ private void
adam11grafik closed pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servi
[
https://issues.apache.org/jira/browse/MNG-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312983#comment-17312983
]
Slawomir Jaranowski commented on MNG-7133:
--
Yes I know, that I must wrap collectio
Tibor17 commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811738125
My advice for you is to copy the class and revert it. Then apply only code
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message
Tibor17 commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811729884
Do you use IntelliJ IDEA?
You can configure it so that the IDE will be according to the checkstyle
plugin, see this:
https://maven.apache.org/developers/conventions/co
adam11grafik commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811729840
Ahh sorry, maybe I click wrong button :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Tibor17 edited a comment on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811727484
I can see that you closed your PR but I have reopened it.
Please continue here.
--
This is an automated message from the Apache Git Service.
To respond to th
Tibor17 commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811727484
I can see that zou closed your PR but I have reopened it.
Please continue here.
--
This is an automated message from the Apache Git Service.
To respond to the messa
adam11grafik commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811722247
@Tibor17, hmm why maven repository does not use maven formatter plugin? :)
Should I fix this on the same branch and create new PR?
I do not know why PR was closed
adam11grafik commented on pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811720519
>
>
> yes, you have modified the biggest class AbstractSurefireMojo. The problem
is that I am not able to recognize real changes within the code format you
cha
adam11grafik closed pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servi
[
https://issues.apache.org/jira/browse/MNG-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312961#comment-17312961
]
Michael Osipov commented on MNG-7133:
-
Use:
{code}
...
..
{code}
> Allow to inli
michael-o commented on pull request #92:
URL: https://github.com/apache/maven/pull/92#issuecomment-811701661
I will try to look at this in the next two weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
78 matches
Mail list logo
