[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

[GitBox]

Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605924120



##########
File path: 
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##########
@@ -772,7 +775,8 @@ public void filtersWithEmptyJunitEngineAreNotRegistered()
         JUnitPlatformProvider provider = new JUnitPlatformProvider( 
providerParameters );
 
         assertThat( provider.getFilters() ).hasSize( 1 );
-        assertThat( provider.getFilters() ).allMatch( x -> x instanceof 
EngineFilter );
+        assertThat( Arrays.stream( provider.getFilters() ).collect( 
Collectors.toList()) )

Review comment:
       ok, then better do it without the Java Stream like this `assertThat( 
provider.getFilters()[0] ).isInstanceOf( EngineFilter.class )`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org