cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r605539574
########## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/GAVNameMapper.java ########## @@ -0,0 +1,89 @@ +package org.eclipse.aether.internal.impl.synccontext.named; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Collection; +import java.util.TreeSet; + +import javax.inject.Named; +import javax.inject.Singleton; + +import org.eclipse.aether.RepositorySystemSession; +import org.eclipse.aether.artifact.Artifact; +import org.eclipse.aether.metadata.Metadata; + +/** + * Artifact GAV {@link NameMapper}, uses artifact and metadata coordinates to name their corresponding locks. Is not + * considering local repository, only the artifact coordinates. + */ +@Singleton +@Named( GAVNameMapper.NAME ) +public class GAVNameMapper + implements NameMapper +{ + public static final String NAME = "gav"; + + @Override + public TreeSet<String> nameLocks( final RepositorySystemSession session, Review comment: It matter as much as interface implementation matter :smile: So, iface is `Collection` but implementation clearly says "am giving out sorted names". This is really an implementation detail here, no need to "mask" return type to `Collection`, as iface (and anyone coding against iface) use it "masked" already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
