[jira] [Created] (MARTIFACT-11) multi-module: copy also aggregate buildinfo.compare to root target

2021-01-31 Thread Herve Boutemy (Jira)
Herve Boutemy created MARTIFACT-11: -- Summary: multi-module: copy also aggregate buildinfo.compare to root target Key: MARTIFACT-11 URL: https://issues.apache.org/jira/browse/MARTIFACT-11 Project: Mav

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #36: Bump plexus-archiver from 4.2.3 to 4.2.4

2021-01-31 Thread GitBox
dependabot[bot] opened a new pull request #36: URL: https://github.com/apache/maven-jlink-plugin/pull/36 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.3 to 4.2.4. Commits https://github.com/codehaus-plexus/plexus-archiver/commit/d9e27ce28

[GitHub] [maven-parent] dependabot[bot] opened a new pull request #23: Bump maven-checkstyle-plugin from 3.0.0 to 3.1.2

2021-01-31 Thread GitBox
dependabot[bot] opened a new pull request #23: URL: https://github.com/apache/maven-parent/pull/23 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.0.0 to 3.1.2. Commits https://github.com/apache/maven-checkstyle-plugin/commit/27b9ef3e

[GitHub] [maven-dependency-plugin] dependabot[bot] closed pull request #113: Bump plexus-archiver from 4.2.2 to 4.2.3

2021-01-31 Thread GitBox
dependabot[bot] closed pull request #113: URL: https://github.com/apache/maven-dependency-plugin/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [maven-dependency-plugin] dependabot[bot] commented on pull request #113: Bump plexus-archiver from 4.2.2 to 4.2.3

2021-01-31 Thread GitBox
dependabot[bot] commented on pull request #113: URL: https://github.com/apache/maven-dependency-plugin/pull/113#issuecomment-770548198 Superseded by #125. This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #125: Bump plexus-archiver from 4.2.2 to 4.2.4

2021-01-31 Thread GitBox
dependabot[bot] opened a new pull request #125: URL: https://github.com/apache/maven-dependency-plugin/pull/125 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.2 to 4.2.4. Release notes Sourced from https://github.com/codehaus-plexus/plexus-arc

[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #124: Bump maven-common-artifact-filters from 3.1.0 to 3.1.1

2021-01-31 Thread GitBox
dependabot[bot] opened a new pull request #124: URL: https://github.com/apache/maven-dependency-plugin/pull/124 Bumps [maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters) from 3.1.0 to 3.1.1. Commits https://github.com/apache/maven-common-a

[jira] [Closed] (MJAVADOC-653) fix javadoc; fix code smells; performance improvement; add travis-ci script.

2021-01-31 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MJAVADOC-653. - Resolution: Fixed > fix javadoc; fix code smells; performance improvement; add

[jira] [Updated] (MJAVADOC-653) fix javadoc; fix code smells; performance improvement; add travis-ci script.

2021-01-31 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MJAVADOC-653: -- Fix Version/s: 3.2.1 > fix javadoc; fix code smells; performance improvement;

[GitHub] [maven-enforcer] KroArtem commented on pull request #90: [MENFORCER-365] - A naive way to ignore test scope

2021-01-31 Thread GitBox
KroArtem commented on pull request #90: URL: https://github.com/apache/maven-enforcer/pull/90#issuecomment-770486099 Help is required as the new IT is failing and I'm not sure how to properly debug such ITs. This is an autom

[GitHub] [maven-enforcer] KroArtem opened a new pull request #90: [MENFORCER-365] - A naive way to ignore test scope

2021-01-31 Thread GitBox
KroArtem opened a new pull request #90: URL: https://github.com/apache/maven-enforcer/pull/90 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[GitHub] [maven-enforcer] KroArtem opened a new pull request #89: [MENFORCER-379] - Update maven-common-artifact-filters to 3.1.1

2021-01-31 Thread GitBox
KroArtem opened a new pull request #89: URL: https://github.com/apache/maven-enforcer/pull/89 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[jira] [Created] (MENFORCER-379) Update maven-common-artifact-filters to 3.1.1

2021-01-31 Thread Krosheninnikov Artem (Jira)
Krosheninnikov Artem created MENFORCER-379: -- Summary: Update maven-common-artifact-filters to 3.1.1 Key: MENFORCER-379 URL: https://issues.apache.org/jira/browse/MENFORCER-379 Project: Maven E

[jira] [Comment Edited] (SCM-748) Automatically create parent dirs with 'svn --parents'

2021-01-31 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/SCM-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403826#comment-16403826 ] Herve Boutemy edited comment on SCM-748 at 1/31/21, 10:24 PM: --

[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-31 Thread GitBox
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-770444673 I still have one question, what should happen if I define a list of `includes` but current vendor doesn't satisfy this list? With this implementation it doesn't fail. Howeve

[GitHub] [maven] MartinKanters commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770443280 > This looks very good to me now. Going through changed IT now. > > I'd like to stress out that I really love how you use lambas for concise and compact code. I can real

[GitHub] [maven] asfgit merged pull request #439: Avoid empty locations

2021-01-31 Thread GitBox
asfgit merged pull request #439: URL: https://github.com/apache/maven/pull/439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] michael-o commented on a change in pull request #439: Avoid empty locations

2021-01-31 Thread GitBox
michael-o commented on a change in pull request #439: URL: https://github.com/apache/maven/pull/439#discussion_r567471937 ## File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java ## @@ -149,7 +149,8 @@ private ExceptionSummary handle( Proj

[GitHub] [maven-integration-testing] MartinKanters commented on pull request #87: [MNG-7051] Test activation of non-existing profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #87: URL: https://github.com/apache/maven-integration-testing/pull/87#issuecomment-770436106 @michael-o I added tests for the `!?` scenario. This is an automated message from the Apach

[GitHub] [maven] MartinKanters commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770433374 > > > > > A few small issues left. > > > > > One question pops up: What happended to `?!name`? Did we discard this? > > > > > > > > > > > > Yep! [We discarded th

[GitHub] [maven] MartinKanters commented on a change in pull request #439: Avoid empty locations

2021-01-31 Thread GitBox
MartinKanters commented on a change in pull request #439: URL: https://github.com/apache/maven/pull/439#discussion_r567469482 ## File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java ## @@ -149,7 +149,8 @@ private ExceptionSummary handle(

[GitHub] [maven] MartinKanters commented on a change in pull request #439: Avoid empty locations

2021-01-31 Thread GitBox
MartinKanters commented on a change in pull request #439: URL: https://github.com/apache/maven/pull/439#discussion_r567469482 ## File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java ## @@ -149,7 +149,8 @@ private ExceptionSummary handle(

[GitHub] [maven] michael-o commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
michael-o commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770431345 > > > > > > A few small issues left. > > > > One question pops up: What happended to `?!name`? Did we discard this? > > > > > > > > > Yep! [We discarded this

[GitHub] [maven] michael-o commented on pull request #439: Avoid empty locations

2021-01-31 Thread GitBox
michael-o commented on pull request #439: URL: https://github.com/apache/maven/pull/439#issuecomment-770431091 This was found during https://issues.apache.org/jira/projects/MNG/issues/MNG-7087. This is an automated message f

[GitHub] [maven] MartinKanters commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770431005 > > > A few small issues left. > > > One question pops up: What happended to `?!name`? Did we discard this? > > > > > > Yep! [We discarded this](https://github.co

[GitHub] [maven] michael-o opened a new pull request #439: Avoid empty locations

2021-01-31 Thread GitBox
michael-o opened a new pull request #439: URL: https://github.com/apache/maven/pull/439 This one turns non-sense output like this: ``` [DEBUG] Looking up lifecycle mappings for packaging jar from ClassRealm[plexus.core, parent: null] [ERROR] [ERROR] Some problems were encountered w

[GitHub] [maven] michael-o commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
michael-o commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770423308 I will run all tests again and let you know... This is an automated message from the Apache Git Service. To respon

[GitHub] [maven] michael-o commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
michael-o commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770423250 > > This is fishy: ... > > Oh, nice find! Apparently the parent POM profile was not taken into account in the `getAllProfiles` method. I've just fixed that. > > Also

[GitHub] [maven] michael-o commented on a change in pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
michael-o commented on a change in pull request #429: URL: https://github.com/apache/maven/pull/429#discussion_r567461438 ## File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java ## @@ -277,22 +277,62 @@ MavenExecutionRequest setProfi

[GitHub] [maven] michael-o commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
michael-o commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770422380 > > A few small issues left. > > One question pops up: What happended to `?!name`? Did we discard this? > > Yep! [We discarded this](https://github.com/apache/maven-site/

[GitHub] [maven] MartinKanters edited a comment on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters edited a comment on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770411763 > This is fishy: ... Oh, nice find! Apparently the parent POM profile was not taken into account in the `getAllProfiles` method. I've just fixed that. Also

[GitHub] [maven] MartinKanters commented on a change in pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on a change in pull request #429: URL: https://github.com/apache/maven/pull/429#discussion_r567452950 ## File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java ## @@ -493,22 +505,88 @@ private void validatePrerequisitesForNonMavenPluginP

[GitHub] [maven] MartinKanters commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770411763 > This is fishy: ... Oh, nice find! Apparently the parent POM profile was not taken into account in the `getAllProfiles` method. I've just fixed that. Also got so

[GitHub] [maven] MartinKanters commented on a change in pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on a change in pull request #429: URL: https://github.com/apache/maven/pull/429#discussion_r567444119 ## File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java ## @@ -277,22 +277,62 @@ MavenExecutionRequest setP

[GitHub] [maven] MartinKanters commented on pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #429: URL: https://github.com/apache/maven/pull/429#issuecomment-770401423 > A few small issues left. > > One question pops up: What happended to `?!name`? Did we discard this? Yep! [We discarded this](https://github.com/apache/maven-sit

[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #87: [MNG-7051] Test activation of non-existing profiles

2021-01-31 Thread GitBox
MartinKanters commented on a change in pull request #87: URL: https://github.com/apache/maven-integration-testing/pull/87#discussion_r567441629 ## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7051NonExistingProfileActivationTest.java ## @@ -0,0 +1,94 @

[GitHub] [maven-integration-testing] MartinKanters commented on pull request #87: [MNG-7051] Test activation of non-existing profiles

2021-01-31 Thread GitBox
MartinKanters commented on pull request #87: URL: https://github.com/apache/maven-integration-testing/pull/87#issuecomment-770399525 > I wen't through all tests. While the actual test if fine, I am absolutely not convinced in the test copies because they are 95% identical. There are now t

[jira] [Updated] (SUREFIRE-1878) Add failOnFlakeCount option

2021-01-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1878: --- Description: The Surefire plugin currently covers two use cases with its `rerunFailingTes

[jira] [Assigned] (SUREFIRE-1878) Add failOnFlakeCount option

2021-01-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1878: -- Assignee: Tibor Digana > Add failOnFlakeCount option > ---

[jira] [Updated] (SUREFIRE-1878) Add failOnFlakeCount option

2021-01-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1878: --- Fix Version/s: 3.0.0-M6 > Add failOnFlakeCount option > --- > >

[jira] [Updated] (SUREFIRE-1878) Add failOnFlakeCount option

2021-01-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1878: --- Priority: Major (was: Minor) > Add failOnFlakeCount option > ---

[jira] [Updated] (SUREFIRE-1878) Add failOnFlakeCount option

2021-01-31 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1878: --- Summary: Add failOnFlakeCount option (was: Add failOnFlake option) > Add failOnFlakeCount

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #333: Add failOnFlakeCount option

2021-01-31 Thread GitBox
Tibor17 edited a comment on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-770372094 > > > I would have used that normally, but all the other methods in this test didn't use it either, but instead used the pattern shown here. I generally alwa

[GitHub] [maven-surefire] Tibor17 commented on pull request #333: Add failOnFlakeCount option

2021-01-31 Thread GitBox
Tibor17 commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-770372094 > > > I would have used that normally, but all the other methods in this test didn't use it either, but instead used the pattern shown here. I generally always go w

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-31 Thread GitBox
Tibor17 commented on a change in pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567415122 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java ## @@ -142,7 +142,10 @@ public static void re

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-31 Thread GitBox
Tibor17 commented on a change in pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567414679 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java ## @@ -142,7 +142,10 @@ public static void re

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-31 Thread GitBox
Tibor17 commented on a change in pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567414679 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java ## @@ -142,7 +142,10 @@ public static void re

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

2021-01-31 Thread GitBox
Tibor17 commented on a change in pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#discussion_r567414679 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java ## @@ -142,7 +142,10 @@ public static void re