michael-o commented on pull request #429:
URL: https://github.com/apache/maven/pull/429#issuecomment-770423250


   > > This is fishy: ...
   > 
   > Oh, nice find! Apparently the parent POM profile was not taken into 
account in the `getAllProfiles` method. I've just fixed that.
   > 
   > Also got some fun facts:
   > 
   > 1. The maven help plugin also does not take this one into account (mvn 
help:all-profiles does not show the release-profile).
   > 2. [A comment from 
2009](https://github.com/apache/maven/blob/master/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml#L86)
 says that the release-profile should be removed when the pom version changes, 
but that never happened...
   
   I will remove it, PR pending, but none the less our approach should work 
through all layers for consistency. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to