MartinKanters commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r567444119



##########
File path: 
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -277,22 +277,62 @@
 
     MavenExecutionRequest setProfiles( List<Profile> profiles );
 
+    /**
+     * @deprecated Use {@link #getProfileActivation()}.

Review comment:
       We thought about this, but there is not one perfect replacement. For 
example: `addActiveProfile` could be replaced with either 
`activateRequiredProfile` or `activateOptionalProfile`. Our (slight) preference 
was to point the user to the new class instead of having `@deprecated Use 
this() or that()` everywhere. I don't mind to change it if you prefer that, 
though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to