[GitHub] [lucene-solr] markharwood commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
markharwood commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583313015 I've reclaimed my Jira log-in and opened https://issues.apache.org/jira/browse/LUCENE-9211

[GitHub] [lucene-solr] romseygeek opened a new pull request #1243: LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton

2020-02-07 Thread GitBox
romseygeek opened a new pull request #1243: LUCENE-9212: Intervals.multiterm() should take CompiledAutomaton URL: https://github.com/apache/lucene-solr/pull/1243 Currently it takes `Automaton` and then compiles it internally, but we need to do things like check for binary-vs-unicode sta

[GitHub] [lucene-solr] markharwood commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
markharwood commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583449275 There was a suggestion from @jimczi that we fall back to writing raw data if content doesn't compress well. I'm not sure this logic

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376459427 ## File path: solr/core/src/java/org/apache/solr/schema/TextField.java ## @@ -43,6 +43,7 @@ public

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376455962 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -509,33 +549,40 @@

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376450137 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/DelimitedBoostTokenFilter.java

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376460611 ## File path: solr/core/src/test-files/solr/collection1/conf/schema12.xml ## @@ -238,6 +227,18 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-583474019 hi @romseygeek , @dsmiley , first of all, thank you again for your patience and very useful insights. I have incorpora

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376474333 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -509,33 +549,40

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376473778 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -450,9 +485,13

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376476198 ## File path: solr/core/src/java/org/apache/solr/schema/TextField.java ## @@ -43,6 +43,7

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376476976 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/DelimitedBoostToke

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376478661 ## File path: solr/core/src/test-files/solr/collection1/conf/schema12.xml ## @@ -238,6 +

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376503587 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -509,3

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376513280 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -450,9

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload

2020-02-07 Thread GitBox
alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-583518344 I have applied the changes to solve the feedback points and consequentially added additional tests to cover some missing sc

[GitHub] [lucene-solr] msokolov commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
msokolov commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583519622 > The LZ4 compressed versions of this content were only marginally bigger than their raw counterparts Did you also test read perform

[GitHub] [lucene-solr] madrob opened a new pull request #1244: SOLR-14247 Remove unneeded sleeps

2020-02-07 Thread GitBox
madrob opened a new pull request #1244: SOLR-14247 Remove unneeded sleeps URL: https://github.com/apache/lucene-solr/pull/1244 This test is slow because it sleeps a lot. Removing the sleeps, it still passes consistently on my machine, but I would like other folks to confirm this on their d

[GitHub] [lucene-solr] msokolov edited a comment on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
msokolov edited a comment on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583519622 > The LZ4 compressed versions of this content were only marginally bigger than their raw counterparts Did you also test

[GitHub] [lucene-solr] jpountz commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583529199 In the case of content that can't be compressed, the compressed data will consist of the number of bytes, followed by the bytes. So decom

[GitHub] [lucene-solr] markharwood commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
markharwood commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583529462 >Did you also test read performance in this incompressible case? Just tried it and it does look 4x faster reading raw random b

[GitHub] [lucene-solr] rmuir commented on issue #1236: Add back assertions removed by LUCENE-9187.

2020-02-07 Thread GitBox
rmuir commented on issue #1236: Add back assertions removed by LUCENE-9187. URL: https://github.com/apache/lucene-solr/pull/1236#issuecomment-583534489 +1, thanks This is an automated message from the Apache Git Service. To re

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r376528169 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r376531952 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r376527753 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r376529195 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r376532189 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
jpountz commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583536606 @msokolov FWIW LZ4 only removes duplicate strings from a stream: when it finds one it inserts a reference to a previous sequence of bytes

[GitHub] [lucene-solr] msokolov commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
msokolov commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583538389 Strange that Mark would measure 4x slowdown from decoding the lengths... Perhaps the random bytes are not totally incompressible, just b

[GitHub] [lucene-solr] markharwood commented on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
markharwood commented on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583539216 >Strange that Mark would measure 4x slowdown from decoding the lengths... Perhaps the random bytes are not totally incompressible, j

[GitHub] [lucene-solr] markharwood edited a comment on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
markharwood edited a comment on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583539216 >Strange that Mark would measure 4x slowdown from decoding the lengths... Perhaps the random bytes are not totally incompress

[GitHub] [lucene-solr] iverase merged pull request #1224: LUCENE-9194: Simplify XYShapeQuery API

2020-02-07 Thread GitBox
iverase merged pull request #1224: LUCENE-9194: Simplify XYShapeQuery API URL: https://github.com/apache/lucene-solr/pull/1224 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] markharwood edited a comment on issue #1234: Add compression for Binary doc value fields

2020-02-07 Thread GitBox
markharwood edited a comment on issue #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#issuecomment-583539216 >Strange that Mark would measure 4x slowdown from decoding the lengths... Perhaps the random bytes are not totally incompress

[GitHub] [lucene-solr] anshumg opened a new pull request #1245: Create gradle precommit action

2020-02-07 Thread GitBox
anshumg opened a new pull request #1245: Create gradle precommit action URL: https://github.com/apache/lucene-solr/pull/1245 This adds a gradle precommit action w/ Java11 for all branches. This is an automated message from the

[GitHub] [lucene-solr] asfgit merged pull request #1182: LUCENE-9149: Increase data dimension limit in BKD

2020-02-07 Thread GitBox
asfgit merged pull request #1182: LUCENE-9149: Increase data dimension limit in BKD URL: https://github.com/apache/lucene-solr/pull/1182 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-solr] anshumg merged pull request #1245: LUCENE-9146: Create gradle precommit action

2020-02-07 Thread GitBox
anshumg merged pull request #1245: LUCENE-9146: Create gradle precommit action URL: https://github.com/apache/lucene-solr/pull/1245 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-08 Thread GitBox
uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-583751044 The task should just be defined for each sourceSet. Then tests and compile works automatically. Grafles will automatica

[GitHub] [lucene-solr] uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-08 Thread GitBox
uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-583751044 The task should just be defined for each sourceSet. Then tests and compile works automatically. Grafles will aut

[GitHub] [lucene-solr] uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-08 Thread GitBox
uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-583753281 Here the forbiddenapis example how to setup a task per sourceSet: https://github.com/policeman-tools/forbidden-apis/blo

[GitHub] [lucene-solr] risdenk closed pull request #1209: SOLR-14209: Upgrade JQuery to 3.4.1

2020-02-08 Thread GitBox
risdenk closed pull request #1209: SOLR-14209: Upgrade JQuery to 3.4.1 URL: https://github.com/apache/lucene-solr/pull/1209 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] risdenk commented on issue #591: SOLR-9840: Add a unit test for LDAP integration (Hrishikesh Gadre, Kevin Risden)

2020-02-08 Thread GitBox
risdenk commented on issue #591: SOLR-9840: Add a unit test for LDAP integration (Hrishikesh Gadre, Kevin Risden) URL: https://github.com/apache/lucene-solr/pull/591#issuecomment-583764671 working on rebasing to latest master to make sure still valid. --

[GitHub] [lucene-solr] dsmiley closed pull request #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff

2020-02-08 Thread GitBox
dsmiley closed pull request #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff URL: https://github.com/apache/lucene-solr/pull/1202 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-08 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376753387 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/DelimitedBoostTokenFilter.java ##

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-08 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376754130 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java ## @@ -124,6

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-08 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376753645 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/package-info.java ## @@ -0,0 +1,

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-08 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376754130 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java ## @@ -124,6

[GitHub] [lucene-solr] ErickErickson commented on issue #1169: LUCENE-9004: A minor feature and patch -- support deleting vector values and fix segments merging

2020-02-09 Thread GitBox
ErickErickson commented on issue #1169: LUCENE-9004: A minor feature and patch -- support deleting vector values and fix segments merging URL: https://github.com/apache/lucene-solr/pull/1169#issuecomment-583848170 Julie: Moving the conversation about forceMerge over from the JIRA as

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1245: LUCENE-9146: Create gradle precommit action

2020-02-09 Thread GitBox
dweiss commented on a change in pull request #1245: LUCENE-9146: Create gradle precommit action URL: https://github.com/apache/lucene-solr/pull/1245#discussion_r376800656 ## File path: .github/workflows/gradle-precommit.yml ## @@ -0,0 +1,23 @@ +name: Gradle Precommit + +on

[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-09 Thread GitBox
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-583950052 Perhaps the remaining larger changes relating to new classes (e.g. StandaloneSolrResourceLoader) should wait for a follow-on commit; ther

[GitHub] [lucene-solr] iverase opened a new pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE

2020-02-10 Thread GitBox
iverase opened a new pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE URL: https://github.com/apache/lucene-solr/pull/1246 Trivial test fix This is an automated message from the Apache Git Service. To re

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376935901 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/package-info.java ## @@ -0,0

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376936277 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java ## @@ -12

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376937485 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -63,6 +66,25 @@ protecte

[GitHub] [lucene-solr] s1monw commented on issue #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed

2020-02-10 Thread GitBox
s1monw commented on issue #1215: LUCENE-9164: Ignore ACE on tragic event if IW is closed URL: https://github.com/apache/lucene-solr/pull/1215#issuecomment-584038675 I will start working on some refactorings to streamline this. ---

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376974784 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/package-info.java ##

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376978767 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java #

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376980226 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -63,6 +66,25 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376980226 ## File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java ## @@ -63,6 +66,25 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376982361 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/boost/DelimitedBoostTokenFilter.java

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-584059142 Latest comments have been addressed, let me know if there's anything else needed here :) --

[GitHub] [lucene-solr] iverase merged pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE

2020-02-10 Thread GitBox
iverase merged pull request #1246: LUCENE-9216: Make sure we index LEAST_DOUBLE_VALUE URL: https://github.com/apache/lucene-solr/pull/1246 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] andywebb1975 opened a new pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-10 Thread GitBox
andywebb1975 opened a new pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247 # Description The getMax and getMin methods in AggregateMetric can throw an NPE if non-Number values are present in values, when i

[GitHub] [lucene-solr] andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-10 Thread GitBox
andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#issuecomment-584087529 The PR really just changes an exception to a warning - it may be papering over another issue. I'm going to try changing `

[GitHub] [lucene-solr] ErickErickson closed pull request #1241: Gradle util

2020-02-10 Thread GitBox
ErickErickson closed pull request #1241: Gradle util URL: https://github.com/apache/lucene-solr/pull/1241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [lucene-solr] ErickErickson commented on issue #1241: Gradle util

2020-02-10 Thread GitBox
ErickErickson commented on issue #1241: Gradle util URL: https://github.com/apache/lucene-solr/pull/1241#issuecomment-584119269 Didn't link appropriately, I wondered why nobody replied. This is an automated message from the A

[GitHub] [lucene-solr] ErickErickson opened a new pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson opened a new pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248 This adds the generation targets for util/packed and util/automaton. For whatever reason my local Python doesn't do anything weir

[GitHub] [lucene-solr] shalinmangar merged pull request #1220: SOLR-13996: Refactor HttpShardHandler.prepDistributed method

2020-02-10 Thread GitBox
shalinmangar merged pull request #1220: SOLR-13996: Refactor HttpShardHandler.prepDistributed method URL: https://github.com/apache/lucene-solr/pull/1220 This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-10 Thread GitBox
andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r377223058 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -9

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-10 Thread GitBox
dsmiley commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r377238017 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java ## @@ -124,6

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked

2020-02-10 Thread GitBox
HoustonPutman commented on a change in pull request #1238: SOLR-14240: Clean up znodes after shard deletion is invoked URL: https://github.com/apache/lucene-solr/pull/1238#discussion_r377325559 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteShardCmd.ja

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377332813 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ##

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377327334 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Ap

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377327836 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Ap

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377369604 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ###

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377374590 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377376693 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] [lucene-solr] ErickErickson commented on issue #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
ErickErickson commented on issue #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#issuecomment-584409136 I made the changes Mike mentioned, but I won't create another PR for a bit to give others a chance to look ---

[GitHub] [lucene-solr] madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
madrob commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377429993 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Ap

[GitHub] [lucene-solr] madrob merged pull request #1244: SOLR-14247 Remove unneeded sleeps

2020-02-10 Thread GitBox
madrob merged pull request #1244: SOLR-14247 Remove unneeded sleeps URL: https://github.com/apache/lucene-solr/pull/1244 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-10 Thread GitBox
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-584496996 I think this PR is ready for review @madrob since there are a lot of changes even without introducing SRL subclasses. --

[GitHub] [lucene-solr] iverase opened a new pull request #1249: LUCENE-9217: Add validation to XYGeometries

2020-02-10 Thread GitBox
iverase opened a new pull request #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249 This PR adds validation for XYGeometries, in particular checking for non-valid values like NaN, INF and -INF.

[GitHub] [lucene-solr] iverase commented on a change in pull request #1249: LUCENE-9217: Add validation to XYGeometries

2020-02-10 Thread GitBox
iverase commented on a change in pull request #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249#discussion_r377470379 ## File path: lucene/core/src/java/org/apache/lucene/geo/XYRectangle.java ## @@ -29,12 +31,16 @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-10 Thread GitBox
dweiss commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377479333 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ##

[GitHub] [lucene-solr] atris commented on issue #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-10 Thread GitBox
atris commented on issue #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#issuecomment-584514132 @jpountz Updated, please see and let me know your thoughts ---

[GitHub] [lucene-solr] atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-10 Thread GitBox
atris commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r377481946 ## File path: lucene/core/src/java/org/apache/lucene/search/QueueSizeBasedExecutionContr

[GitHub] [lucene-solr] janhoy opened a new pull request #1250: SOLR-14250 Fix error logging on Expect: 100-continue

2020-02-11 Thread GitBox
janhoy opened a new pull request #1250: SOLR-14250 Fix error logging on Expect: 100-continue URL: https://github.com/apache/lucene-solr/pull/1250 See https://issues.apache.org/jira/browse/SOLR-14250 With this PR, we'll still always try to consume the stream, but if the input stre

[GitHub] [lucene-solr] janhoy commented on issue #1250: SOLR-14250 Fix error logging on Expect: 100-continue

2020-02-11 Thread GitBox
janhoy commented on issue #1250: SOLR-14250 Fix error logging on Expect: 100-continue URL: https://github.com/apache/lucene-solr/pull/1250#issuecomment-584537676 I tested manually that the new DEBUG log line is printed when hitting a non-existent URL, e.g. curl -H "Content-Type:

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost

2020-02-11 Thread GitBox
alessandrobenedetti commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#discussion_r377532448 ## File path: lucene/core/src/java/org/apache/lucene/util/graph/GraphTokenStreamFiniteStrings.java #

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

2020-02-11 Thread GitBox
alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-584554973 So the code should be ok now, should we think where and how to properly document it ? I will definitely write a blog post on that (th

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-11 Thread GitBox
juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r377544478 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ###

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-11 Thread GitBox
juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r377545909 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ###

[GitHub] [lucene-solr] mocobeta commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-11 Thread GitBox
mocobeta commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584574521 Thanks @uschindler for your comments. I rewrote the task to use sourceSets instead of relying the assumption the target p

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-11 Thread GitBox
juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r377566543 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesFormat.java #

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-11 Thread GitBox
juanka588 commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r377579943 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-11 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r377621003 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-11 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377624894 ## File path: gradle/generation/util.gradle ## @@ -0,0 +1,102 @@ +/* + * Licensed to

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build

2020-02-11 Thread GitBox
ErickErickson commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377627813 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ###

[GitHub] [lucene-solr] uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-11 Thread GitBox
uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584631168 Hi @mocobeta, what's the problem with the source folder? Here it is https://docs.gradle.org/current/dsl/org.gradle.

[GitHub] [lucene-solr] uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-11 Thread GitBox
uschindler edited a comment on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584631168 Hi @mocobeta, what's the problem with the source folder? Here it is https://docs.gradle.org/current/dsl/org.

[GitHub] [lucene-solr] uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build

2020-02-11 Thread GitBox
uschindler commented on issue #1242: LUCENE-9201: Port documentation-lint task to Gradle build URL: https://github.com/apache/lucene-solr/pull/1242#issuecomment-584633315 The `copyAllJavadocs` should be placed outside of linter. We will need this anyways, as the whole Javadocs are no

  1   2   3   4   5   6   7   8   9   10   >