romseygeek commented on a change in pull request #357: [SOLR-12238] Synonym 
Queries boost by payload 
URL: https://github.com/apache/lucene-solr/pull/357#discussion_r376473778
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java
 ##########
 @@ -450,9 +485,13 @@ protected Query analyzePhrase(String field, TokenStream 
stream, int slop) throws
         position += 1;
       }
       builder.add(new Term(field, termAtt.getBytesRef()), position);
+      phraseBoost = boostAtt.getBoost();
 
 Review comment:
   I think this isn't quite right, because we need to combine boosts together 
somehow; currently your phrase boost is just the boost of the last term in the 
phrase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to