Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-06-24 Thread via GitHub
dungba88 commented on code in PR #14009: URL: https://github.com/apache/lucene/pull/14009#discussion_r2164187870 ## lucene/core/src/java/org/apache/lucene/search/RescoreTopNQuery.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] Decrease TieredMergePolicy's default number of segments per tier to 8. [lucene]

2025-06-24 Thread via GitHub
rmuir commented on PR #14823: URL: https://github.com/apache/lucene/pull/14823#issuecomment-3001353043 Here's the trend of HNSW indexing performance in the nightly bench: https://github.com/user-attachments/assets/e6f51f7c-5c76-48ec-9a84-a39c91aeb108"; /> You can see why I thin

Re: [PR] Optimize FieldExistsQuery to leverage index statistic in DocValuesSkipper [lucene]

2025-06-24 Thread via GitHub
jpountz commented on code in PR #14830: URL: https://github.com/apache/lucene/pull/14830#discussion_r2164950524 ## lucene/core/src/test/org/apache/lucene/search/TestFieldExistsQuery.java: ## @@ -88,6 +88,25 @@ public void testDocValuesRewriteWithPointValuesPresent() throws IOEx

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-06-24 Thread via GitHub
dungba88 commented on code in PR #14009: URL: https://github.com/apache/lucene/pull/14009#discussion_r2164222681 ## lucene/core/src/java/org/apache/lucene/search/RescoreTopNQuery.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-06-24 Thread via GitHub
dungba88 commented on code in PR #14009: URL: https://github.com/apache/lucene/pull/14009#discussion_r2164192783 ## lucene/core/src/test/org/apache/lucene/search/TestRescoreTopNQuery.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-06-24 Thread via GitHub
jmazanec15 commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-3000947753 > For hybrid search in OpenSearch/Elastic Search, I'm wondering if @jmazanec15 and @benwtrent have any input. I'm having a feeling that it's quite common to combine lexical + KNN matc

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-06-24 Thread via GitHub
dungba88 commented on code in PR #14009: URL: https://github.com/apache/lucene/pull/14009#discussion_r2164192783 ## lucene/core/src/test/org/apache/lucene/search/TestRescoreTopNQuery.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-06-24 Thread via GitHub
dungba88 commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-3000831503 Sorry for spamming the replies! I should have gone to the Files changed tab, which allow sending all replies in the same message. -- This is an automated message from the Apache Git S

Re: [PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-06-24 Thread via GitHub
thecoop merged PR #14702: URL: https://github.com/apache/lucene/pull/14702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Add more information to IOContext [lucene]

2025-06-24 Thread via GitHub
thecoop closed issue #14422: Add more information to IOContext URL: https://github.com/apache/lucene/issues/14422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] Add more information to IOContext [lucene]

2025-06-24 Thread via GitHub
thecoop commented on issue #14422: URL: https://github.com/apache/lucene/issues/14422#issuecomment-3001039855 This has now been done - `IOContext` allows hints to be specified, and `ReadAdvice` is only used by `MMapDirectory` -- This is an automated message from the Apache Git Service. To

Re: [PR] Make it possible to extend Patience/Seeded knn queries [lucene]

2025-06-24 Thread via GitHub
tteofili commented on PR #14838: URL: https://github.com/apache/lucene/pull/14838#issuecomment-3001043146 @benwtrent extended this to `SeededKnnVectorQuery ` in [ecc37de](https://github.com/apache/lucene/pull/14838/commits/ecc37de92b9c78fecfdf5214ba219692c873c4ad) (changed also PR descripti

Re: [I] fix sources to conform to .editorconfig [lucene]

2025-06-24 Thread via GitHub
rmuir commented on issue #14819: URL: https://github.com/apache/lucene/issues/14819#issuecomment-3002202141 closing this out: we're now linting in CI, space and indentation is fixed. One thing that happened was disabling the `max_line_length`. Personally I'm ok with that, but if you d

Re: [I] fix sources to conform to .editorconfig [lucene]

2025-06-24 Thread via GitHub
rmuir closed issue #14819: fix sources to conform to .editorconfig URL: https://github.com/apache/lucene/issues/14819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] ci: enable gh annotations with ast-grep [lucene]

2025-06-24 Thread via GitHub
rmuir merged PR #14840: URL: https://github.com/apache/lucene/pull/14840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] ci: enable gh annotations with ast-grep [lucene]

2025-06-24 Thread via GitHub
rmuir commented on PR #14840: URL: https://github.com/apache/lucene/pull/14840#issuecomment-3003008814 ill try to look if it makes sense to configure any other checkers... if you have ideas let me know. the EditorConfigLint would be my first idea to look at next otherwise, due to the fact i

[PR] Backport Faiss-based vector format to 10.x [lucene]

2025-06-24 Thread via GitHub
kaivalnp opened a new pull request, #14843: URL: https://github.com/apache/lucene/pull/14843 ### Description Backport #14178 to 10.x ### Summary of changes - Support for JDK21 via MR-JAR and runtime lookup (similar to other Panama-based classes [here](https://github.co

[PR] deps(java): bump com.google.googlejavaformat:google-java-format from 1.23.0 to 1.27.0 [lucene]

2025-06-24 Thread via GitHub
dependabot[bot] opened a new pull request, #14842: URL: https://github.com/apache/lucene/pull/14842 Bumps [com.google.googlejavaformat:google-java-format](https://github.com/google/google-java-format) from 1.23.0 to 1.27.0. Release notes Sourced from https://github.com/google/goog

Re: [PR] Decrease TieredMergePolicy's default number of segments per tier to 8. [lucene]

2025-06-24 Thread via GitHub
jpountz commented on code in PR #14823: URL: https://github.com/apache/lucene/pull/14823#discussion_r2164006633 ## lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java: ## @@ -85,7 +85,7 @@ public class TieredMergePolicy extends MergePolicy { private long maxMe

Re: [PR] deps(java): bump com.google.errorprone:error_prone_core from 2.38.0 to 2.39.0 [lucene]

2025-06-24 Thread via GitHub
rmuir commented on PR #14841: URL: https://github.com/apache/lucene/pull/14841#issuecomment-3003098142 note the guava version shenanigans... i'd have to test, but i don't think any of the new 3 checks apply to us... two are for frameworks not in use. The Boolean.TRUE/FALSE -> t

Re: [PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]

2025-06-24 Thread via GitHub
vsop-479 commented on PR #14813: URL: https://github.com/apache/lucene/pull/14813#issuecomment-2999202574 Emm~, Use heap will remove(pop) element in orderedGroups, which will result in `TestGrouping#testRandom` fail, since this test case `getTopGroups` many times. -- This is an automated

Re: [PR] Decrease TieredMergePolicy's default number of segments per tier to 8. [lucene]

2025-06-24 Thread via GitHub
easyice commented on code in PR #14823: URL: https://github.com/apache/lucene/pull/14823#discussion_r2163420971 ## lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java: ## @@ -85,7 +85,7 @@ public class TieredMergePolicy extends MergePolicy { private long maxMe

Re: [PR] Make it possible to extend PatienceKnnQuery [lucene]

2025-06-24 Thread via GitHub
github-actions[bot] commented on PR #14838: URL: https://github.com/apache/lucene/pull/14838#issuecomment-2999407207 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop