rmuir commented on PR #14841:
URL: https://github.com/apache/lucene/pull/14841#issuecomment-3003098142
note the guava version shenanigans...
i'd have to test, but i don't think any of the new 3 checks apply to us...
two are for frameworks not in use.
The Boolean.TRUE/FALSE -> true/false check doesnt make sense to me: it is an
object. If we want to prevent autoboxing, then i'd rather just set
`org.eclipse.jdt.compiler.problem.autoboxing=error`:
```
> Task :lucene:core:ecjLintTest
----------
1. ERROR in
/home/rmuir/workspace/lucene/lucene/core/src/test/org/apache/lucene/TestDemo.java
(at line 86)
if (hasResults == Boolean.TRUE) {
^^^^^^^^^^^^
The expression of type Boolean is unboxed into boolean
```
Of course this would require fixing a lot of issues :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
