github-actions[bot] commented on PR #14831:
URL: https://github.com/apache/lucene/pull/14831#issuecomment-2993943716
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir opened a new pull request, #14831:
URL: https://github.com/apache/lucene/pull/14831
Error-prone has many checks, but the tool doesn't scale well with respect to
many checks: replace six (arbitrary) easy ones.
ast-grep:
* https://errorprone.info/bugpattern/SubstringOfZero
*
rmuir commented on code in PR #14831:
URL: https://github.com/apache/lucene/pull/14831#discussion_r2160226517
##
lucene/test-framework/src/test/org/apache/lucene/tests/util/TestBeforeAfterOverrides.java:
##
@@ -30,7 +30,9 @@ public TestBeforeAfterOverrides() {
public static
dweiss commented on PR #14764:
URL: https://github.com/apache/lucene/pull/14764#issuecomment-2993509963
> whoa, `precommit` time is ~6 minutes, and test time is ~1.2 minutes
I just realized that this is also an unfair comparison because that initial
```check -x test``` is compiling al
HUSTERGS commented on PR #14827:
URL: https://github.com/apache/lucene/pull/14827#issuecomment-2993494222
For what it's worth, the reason of this PR is that I find
`filterCompetitiveHits` ocuppied about 13% of flamegraph on OrHighHigh query,
 to help?
--
This is an automated message from the Apache Git Service.
To respond to the mes
dweiss merged PR #14828:
URL: https://github.com/apache/lucene/pull/14828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
HUSTERGS opened a new pull request, #14827:
URL: https://github.com/apache/lucene/pull/14827
### Description
This PR propose to specialize function `filterCompetitiveHits` when we have
exact 2 scorers, in order to reduce float calculation and potential function
calls
Luceneutil re
bugmakerr opened a new pull request, #14830:
URL: https://github.com/apache/lucene/pull/14830
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #14830:
URL: https://github.com/apache/lucene/pull/14830#issuecomment-2993596164
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
dweiss commented on PR #14828:
URL: https://github.com/apache/lucene/pull/14828#issuecomment-2993693465
> But I'm afraid they keep the check and just fail.
I think they shouldn't mess with extra arguments - maybe you can convince
them so. It's similar to this issue -
https://githu
dweiss commented on PR #14824:
URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993698382
With:
```
-Xmx1g -XX:ReservedCodeCacheSize=256m -XX:TieredStopAtLevel=1
```
I get:
```
max-workers: 8
real 0m9.768s
real 0m9.486s
real 0m9.501s
max-workers: 1
github-actions[bot] commented on PR #14824:
URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993699244
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
dweiss commented on PR #14824:
URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993704851
On gh runners changing these options seems to have no effect.
* before removing ```-XX:TieredStopAtLevel=1 -XX:ActiveProcessorCount=1```:
![image](https://github.com/user-attachment
github-actions[bot] commented on PR #14824:
URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993705268
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
rmuir commented on PR #14824:
URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993683230
@dweiss maybe remove the parallelgc along with if you are testing. It's only
needed because with 1 CPU ergonomics will default you to SerialGC which is too
slow.
--
This is an automated
dweiss commented on PR #14824:
URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993560243
Here are some benchmarks from my Linux system.
This runs the patch with varying number of workers and the default
```-XX:ActiveProcessorCount=1``` in gradle.properties. This is a
breskeby commented on PR #14828:
URL: https://github.com/apache/lucene/pull/14828#issuecomment-2993580446
it will be actually interesting how this will behave in gradle 9.0. Ideally
it would just work as junit would be found on the module path in this case
here. But I'm afraid they keep the
breskeby opened a new pull request, #14828:
URL: https://github.com/apache/lucene/pull/14828
### Description
This fixes deprecation warning "The automatic loading of test framework
implementation dependencies has been deprecated." Gradle test tasks relies on
having the test framework
33 matches
Mail list logo
