rmuir commented on code in PR #14831:
URL: https://github.com/apache/lucene/pull/14831#discussion_r2160226517
##########
lucene/test-framework/src/test/org/apache/lucene/tests/util/TestBeforeAfterOverrides.java:
##########
@@ -30,7 +30,9 @@ public TestBeforeAfterOverrides() {
public static class Before1 extends WithNestedTests.AbstractNestedTest {
@Before
- public void before() {}
+ public void before() {
+ /* intentionally left blank */
+ }
Review Comment:
their checker is kinda wimpy on these and wasn't catching these. I added a
comment node inside each one so they wouldn't be empty anymore: hope this is
OK.
alternatively we could add ignore entire file or try to use an
`ast-grep-ignore:` comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
