HUSTERGS commented on PR #14827:
URL: https://github.com/apache/lucene/pull/14827#issuecomment-2993494222

   For what it's worth, the reason of this PR is that I find 
`filterCompetitiveHits` ocuppied about 13% of flamegraph on OrHighHigh query, 
   
![image](https://github.com/user-attachments/assets/b45154f9-a837-40e9-b8a3-49aae5d31e82)
   
   Also, `filterCompetitiveHits` calls `MathUtil.sumUpperBound` in a loop, 
seems repeatly calculate `MathUtil.sumRelativeErrorBound(numValues)`, 
(`numValues` is constant within the loop), I tried to optimize this, but it 
shows no performance difference, maybe `filterCompetitiveHits` is no longer the 
bottleneck when `numValues` > 2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to