Re: [PR] Fix usage of deprecated Gradle APIs scheduled to be removed in Gradle 9.0 [lucene]

2025-06-15 Thread via GitHub
dweiss commented on PR #14781: URL: https://github.com/apache/lucene/pull/14781#issuecomment-2975245870 > One problem that gradle is suffering from is, all the freedom it had given in the (groovy) DSL implementation in its early days. Thanks. It's subjective, I know, but I have been a

[I] build and push release regression [lucene]

2025-06-15 Thread via GitHub
dweiss opened a new issue, #14786: URL: https://github.com/apache/lucene/issues/14786 ### Description Something stopped working here - https://github.com/apache/lucene/actions/runs/15670563859 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] compileMain24Java fails with JDK25+ [lucene]

2025-06-15 Thread via GitHub
dweiss commented on issue #14782: URL: https://github.com/apache/lucene/issues/14782#issuecomment-2975278118 I've applied your patch, looks better indeed, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Remove duplicate -Xlint:options flags. [lucene]

2025-06-15 Thread via GitHub
dweiss opened a new pull request, #14788: URL: https://github.com/apache/lucene/pull/14788 Fixes #14782 by not emitting duplicate lint flags to javac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[I] spotlessGradleScripts doesn't work with whitespace-paths on Windows [lucene]

2025-06-15 Thread via GitHub
dweiss opened a new issue, #14787: URL: https://github.com/apache/lucene/issues/14787 ### Description As reported by Uwe - ``` > Task :spotlessGradleScripts Missing required bundle org.eclipse.jdt.debug needed by [org.eclipse.jdt.launching, org.eclipse.jdt.launching.macos

[I] Revert back to jgit for collecting git status [lucene]

2025-06-15 Thread via GitHub
dweiss opened a new issue, #14785: URL: https://github.com/apache/lucene/issues/14785 ### Description Revert native git to jgit for collecting git status. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Remove duplicate -Xlint:options flags. [lucene]

2025-06-15 Thread via GitHub
dweiss commented on code in PR #14788: URL: https://github.com/apache/lucene/pull/14788#discussion_r2149179129 ## build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle: ## @@ -32,9 +32,14 @@ configure(project(":lucene:core")) { tasks.named("compileMain${jd

Re: [PR] Remove duplicate -Xlint:options flags. [lucene]

2025-06-15 Thread via GitHub
github-actions[bot] commented on PR #14788: URL: https://github.com/apache/lucene/pull/14788#issuecomment-2975317328 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [I] compileMain24Java fails with JDK25+ [lucene]

2025-06-15 Thread via GitHub
dweiss commented on issue #14782: URL: https://github.com/apache/lucene/issues/14782#issuecomment-2975300641 I looked at the JDK issue and Archie couldn't reproduce the issue. Here's a repro - ``` .../jdk-25+27/bin/javac -source 24 -target 24 -Xlint:options -Xlint:-options -Werror Fo

Re: [PR] Make `pack` methods public for `BigIntegerPoint` and `HalfFloatPoint` [lucene]

2025-06-15 Thread via GitHub
prudhvigodithi commented on PR #14784: URL: https://github.com/apache/lucene/pull/14784#issuecomment-2974928884 I have just updated the CHANGES.txt adding to 10.2.2, please let me know if this is ok else I can change back to 10.3.0. -- This is an automated message from the Apache Git Serv

[PR] Make `pack` methods public for `BigIntegerPoint` and `HalfFloatPoint` [lucene]

2025-06-15 Thread via GitHub
prudhvigodithi opened a new pull request, #14784: URL: https://github.com/apache/lucene/pull/14784 ### Description Following this commit https://github.com/apache/lucene/commit/94c76c790cd0b8b1bca384c5de18ec5c7957d5d9 make `pack` methods public for `BigIntegerPoint` and `HalfFloatPoi

Re: [PR] Make `pack` methods public for `BigIntegerPoint` and `HalfFloatPoint` [lucene]

2025-06-15 Thread via GitHub
github-actions[bot] commented on PR #14784: URL: https://github.com/apache/lucene/pull/14784#issuecomment-2974683710 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] [Build] Fix more gradle deprecation warnings scheduled to be removed in 9.0 [lucene]

2025-06-15 Thread via GitHub
github-actions[bot] commented on PR #14783: URL: https://github.com/apache/lucene/pull/14783#issuecomment-2973667019 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

[PR] [Build] Fix more gradle deprecation warnings scheduled to be removed in 9.0 [lucene]

2025-06-15 Thread via GitHub
breskeby opened a new pull request, #14783: URL: https://github.com/apache/lucene/pull/14783 ### Description This fixes two more types of deprecations seen in the build: 1. Fix file permission setup using non deprecated Gradle API 2. Fix deprecated usage of other projects

Re: [PR] [Build] Fix more gradle deprecation warnings scheduled to be removed in 9.0 [lucene]

2025-06-15 Thread via GitHub
breskeby commented on code in PR #14783: URL: https://github.com/apache/lucene/pull/14783#discussion_r2147569228 ## build-tools/build-infra/src/main/groovy/lucene.regenerate.icu.gradle: ## @@ -30,14 +30,15 @@ def resources = rootProject.file("gradle/regenerate/icu") * download

Re: [PR] [Build] Fix more gradle deprecation warnings scheduled to be removed in 9.0 [lucene]

2025-06-15 Thread via GitHub
breskeby commented on code in PR #14783: URL: https://github.com/apache/lucene/pull/14783#discussion_r2147573314 ## build-tools/build-infra/src/main/groovy/lucene.regenerate.icu.gradle: ## @@ -30,14 +30,15 @@ def resources = rootProject.file("gradle/regenerate/icu") * download

Re: [PR] [Build] Fix more gradle deprecation warnings scheduled to be removed in 9.0 [lucene]

2025-06-15 Thread via GitHub
github-actions[bot] commented on PR #14783: URL: https://github.com/apache/lucene/pull/14783#issuecomment-2973676150 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [I] compileMain24Java fails with JDK25+ [lucene]

2025-06-15 Thread via GitHub
uschindler commented on issue #14782: URL: https://github.com/apache/lucene/issues/14782#issuecomment-2973765065 I added a similar hack to 10.x branch: 2503e832c17f6744dc33fd837f7e9f0e07d4 I'd prefer to only apply this to the MR-JAR part of compilation: ```patch build-t

Re: [I] compileMain24Java fails with JDK25+ [lucene]

2025-06-15 Thread via GitHub
uschindler commented on issue #14782: URL: https://github.com/apache/lucene/issues/14782#issuecomment-2973767174 Of course you could add the version check, too, but disabling -Werror for the MR-JAR part is fine IMHO, because it is a hack anyways and further warnings may appear any time soon

Re: [I] compileMain24Java fails with JDK25+ [lucene]

2025-06-15 Thread via GitHub
uschindler commented on issue #14782: URL: https://github.com/apache/lucene/issues/14782#issuecomment-2973762322 I opened an issue @ JDK: https://bugs.openjdk.org/browse/JDK-8359596 > This used to work with JDK 25-beta+11-ea. It also worked afterwards (25 ea+15). It is a rather

Re: [PR] Build refactoring and cleanups (moving from build scripts to convention plugins) [lucene]

2025-06-15 Thread via GitHub
uschindler commented on PR #14764: URL: https://github.com/apache/lucene/pull/14764#issuecomment-2973786942 > * `:spotlessGradleScripts` seems incredibly slow, but it is just a one-time pain, the very first time you run it. I think it downloads. It is also slow when you run it later.

Re: [PR] Implement `ConstantScoreScorer#nextDocsAndScores` [lucene]

2025-06-15 Thread via GitHub
HUSTERGS commented on PR #14772: URL: https://github.com/apache/lucene/pull/14772#issuecomment-2973806605 > Interesting. I don't believe that being able to use `Arrays#fill` helps much, but maybe the fact that this change helps reduce polymorphism does? @jpountz Thanks for your reply!

Re: [PR] Build refactoring and cleanups (moving from build scripts to convention plugins) [lucene]

2025-06-15 Thread via GitHub
uschindler commented on PR #14764: URL: https://github.com/apache/lucene/pull/14764#issuecomment-2973613662 > * `runtime.java.home` is a build option now but the support for > `RUNTIME_JAVA_HOME` env. variable has been implemented for backward > compatibility. Please keep thi

Re: [PR] Fix usage of deprecated Gradle APIs scheduled to be removed in Gradle 9.0 [lucene]

2025-06-15 Thread via GitHub
breskeby commented on PR #14781: URL: https://github.com/apache/lucene/pull/14781#issuecomment-2973619493 > Right... This is among those things I mentioned that I don't understand - perhaps there are benefits to configuration caching or other advanced features... but overall it's a lot more