breskeby commented on code in PR #14783:
URL: https://github.com/apache/lucene/pull/14783#discussion_r2147573314
##########
build-tools/build-infra/src/main/groovy/lucene.regenerate.icu.gradle:
##########
@@ -30,14 +30,15 @@ def resources = rootProject.file("gradle/regenerate/icu")
* download and compile a matching icu4c version automatically.
*/
-// Configure different icu4j dependencies.
-configure(rootProject) {
Review Comment:
IMO this plugin is a good example of something that can benefit from been
ported into a binary plugin and only keep its actual implementation in this
convention plugin rather all the nitty bits of implementation details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
