uschindler commented on issue #14782:
URL: https://github.com/apache/lucene/issues/14782#issuecomment-2973765065
I added a similar hack to 10.x branch:
2503e832c17f6744dc33fd837f78888e9f0e07d4
I'd prefer to only apply this to the MR-JAR part of compilation:
```patch
build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle | 2 ++
build-tools/build-infra/src/main/groovy/lucene.java.javac.gradle | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git
a/build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle
b/build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle
index 60a4588ba2d..3838cf9854f 100644
--- a/build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle
+++ b/build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle
@@ -43,6 +43,8 @@ configure(project(":lucene:core")) {
"--add-exports",
"java.base/jdk.incubator.vector=ALL-UNNAMED",
]
+ // hack because -Xlint:-options does not work for all options
(regression in JDK 25+?):
+ options.compilerArgs.remove("-Werror")
def argsProvider = objects.newInstance(CompilerArgsProvider)
argsProvider.apiJarFile.set(apijar)
diff --git
a/build-tools/build-infra/src/main/groovy/lucene.java.javac.gradle
b/build-tools/build-infra/src/main/groovy/lucene.java.javac.gradle
index 67aaf29c7a4..8f20d9c030b 100644
--- a/build-tools/build-infra/src/main/groovy/lucene.java.javac.gradle
+++ b/build-tools/build-infra/src/main/groovy/lucene.java.javac.gradle
@@ -81,7 +81,7 @@ tasks.withType(JavaCompile).configureEach {
// proc:none was added because of LOG4J2-1925 / JDK-8186647
options.compilerArgs += ["-proc:none"]
- if (failOnWarningsOption.get() && (rootProject.ext.runtimeJavaVersion <
JavaVersion.VERSION_25)) {
+ if (failOnWarningsOption.get()) {
options.compilerArgs += "-Werror"
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
