rmuir merged PR #14589:
URL: https://github.com/apache/lucene/pull/14589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
dweiss merged PR #14592:
URL: https://github.com/apache/lucene/pull/14592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss merged PR #14591:
URL: https://github.com/apache/lucene/pull/14591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
thecoop commented on code in PR #14593:
URL: https://github.com/apache/lucene/pull/14593#discussion_r2068324330
##
lucene/core/src/java/org/apache/lucene/store/PosixNativeAccess.java:
##
@@ -157,7 +157,6 @@ private int mapReadAdvice(ReadAdvice readAdvice) {
case NORMAL ->
uschindler merged PR #14564:
URL: https://github.com/apache/lucene/pull/14564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #14564:
URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841210449
@thecoop, I renamed the `readAdvice` field in this branch in `MMapDirectory`
to `readAdviceOverride` because the old name is confusing when reading the
code. It may be adviseable to b
thecoop commented on PR #14564:
URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841174064
The changes around `ReadAdvice` look ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmuir opened a new pull request, #14594:
URL: https://github.com/apache/lucene/pull/14594
Add one-liner above comments giving a hint how the dependency is used. This
can help make the dependencies easier to maintain: it points you in the right
direction and will be shown in dependabot diffs
rmuir merged PR #14594:
URL: https://github.com/apache/lucene/pull/14594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068657900
##
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -70,14 +72,15 @@ public static MemorySegmentIndexInput newInstance(
MemorySe
thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068656440
##
lucene/test-framework/src/java/org/apache/lucene/tests/store/SerialIOCountingDirectory.java:
##
@@ -72,7 +72,7 @@ public ChecksumIndexInput openChecksumInput(String
thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068657900
##
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -70,14 +72,15 @@ public static MemorySegmentIndexInput newInstance(
MemorySe
dweiss commented on PR #14582:
URL: https://github.com/apache/lucene/pull/14582#issuecomment-2841156503
Seems like tons of api changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dweiss merged PR #14573:
URL: https://github.com/apache/lucene/pull/14573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
uschindler commented on PR #14564:
URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841192482
Thanks @thecoop. About the other PR: It was only for main branch, right? So
it won't be backported, so all changes to readAdvice will be a feature for
Lucene 11. To me those changes l
dweiss opened a new pull request, #14591:
URL: https://github.com/apache/lucene/pull/14591
This is a limited backport of #14533 bumping gradle to v8.14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dweiss commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841274438
> I think we need to change the gradlew / gradlew.cmd files to pass the
additional command line option `--enable-native-access=ALL-UNNAMED`
gradle is now launched with --jar and con
uschindler commented on PR #14564:
URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841091940
Damn: "Create file open hints on IOContext to replace ReadAdvice
(https://github.com/apache/lucene/pull/14482)" was merged yesterday. Trying
to figure out what's going on. @thecoo
dweiss commented on PR #14575:
URL: https://github.com/apache/lucene/pull/14575#issuecomment-2841138221
I think this dependency should be replaced with google's official release -
https://github.com/google/s2-geometry-library-java
--
This is an automated message from the Apache Git Serv
dweiss merged PR #14585:
URL: https://github.com/apache/lucene/pull/14585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2841306914
The number of clones here seems... ahem, high.
```
2> Apr 30, 2025 11:04:20 AM
org.apache.lucene.internal.vectorization.VectorizationProvider lookup
2> WARNING: Vector bi
dweiss commented on code in PR #14591:
URL: https://github.com/apache/lucene/pull/14591#discussion_r2068225660
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -379,7 +379,9 @@ private static MMapIndexInputProvider
lookupProvider() {
// access t
uschindler commented on PR #14591:
URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841573256
I got a strange error:
* What went wrong:
Execution failed for task ':downloadEcjDrop'.
> A failure occurred while executing
de.undercouch.gradle.tasks.download.internal.
uschindler commented on PR #14591:
URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841576505
Fixed: 0550cc6d2d0294641679131b597d591896211fce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on PR #14591:
URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841591612
One information about Exclipse: With the recent commit all works fine. It
just sometimes fails with a compilation error (but that's not new) regarding:
"Permitted type LeafReaderConte
uschindler commented on PR #14591:
URL: https://github.com/apache/lucene/pull/14591#issuecomment-2841593957
sorry the messages above are in wrong PR. deleting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
uschindler commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841595622
I got a strange error:
* What went wrong:
Execution failed for task ':downloadEcjDrop'.
> A failure occurred while executing
de.undercouch.gradle.tasks.download.internal.
uschindler commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841596170
Fixed: 0550cc6d2d0294641679131b597d591896211fce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2841596506
One information about Exclipse: With the recent commit all works fine. It
just sometimes fails with a compilation error (but that's not new) regarding:
"Permitted type LeafReaderConte
rmuir commented on PR #14583:
URL: https://github.com/apache/lucene/pull/14583#issuecomment-2842062463
i'm gonna circle back to this one, just need a better plan than iterating
with `./gradlew regenerate --rerun-all-tasks` :) Can probably just try to
iterate with StandardTokenizer: the 12GB
gf2121 commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2842434087
I raised:
* https://github.com/apache/lucene/pull/14595 binding limitation to the
number of segments get merged.
* https://github.com/apache/lucene/pull/14596 a tiny simplificat
gf2121 opened a new pull request, #14596:
URL: https://github.com/apache/lucene/pull/14596
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
rmuir commented on issue #14598:
URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843104515
I looked into this, there's a `gradle/wrapper/gradle-wrapper.jar.sha256` but
it is not in the standard format. How is this currently being generated/used? I
would propose:
Gene
rmuir merged PR #14540:
URL: https://github.com/apache/lucene/pull/14540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
uschindler opened a new pull request, #14597:
URL: https://github.com/apache/lucene/pull/14597
First step in getting rid of ASM dependency:
Java 24 added the classfile API (https://openjdk.org/jeps/484) in
non-preview mode. This allows to generate class files with a builder-based API
dweiss commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2842796053
Thank you, Uwe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
dweiss opened a new issue, #14598:
URL: https://github.com/apache/lucene/issues/14598
### Description
Uwe noticed this. After the update to gradle 8.14, I've updated the
gradle-wrapper script's version and SHA. The new scripts launch it using -jar
(previously it was launched using an
rmuir commented on issue #14598:
URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843055994
I had to remove a wrapper manually this morning (maybe it was 0 bytes or
corrupt or outdated) and force it to be re-downloaded myself. I didn't raise
any issue as you know, i do hacky
uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843218827
I did some final cleanup and added changes entry. Will merge soon.
Thanks for the reviews by @rjernst and @jdconrad, very appreciated.
--
This is an automated message from the
uschindler commented on PR #14564:
URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841163008
I am still verifyying that the conflicting changes due to readAdvice are
merged in here in a correct way.
I will merge this very soon tro avoid conflicts like this. My head is
uschindler commented on PR #14564:
URL: https://github.com/apache/lucene/pull/14564#issuecomment-2841215864
@thecoop is it correct that the `openInput()` code calls a deprecated method
`IOContext#readAdvice()`? Will this be fixed in a later PR?
--
This is an automated message from the Apa
uschindler commented on code in PR #14591:
URL: https://github.com/apache/lucene/pull/14591#discussion_r2068218261
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -379,7 +379,9 @@ private static MMapIndexInputProvider
lookupProvider() {
// acce
dweiss commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2841305012
I hit a failure on this again, after the patch:
```
./gradlew test -Ptests.seed=49BA5A550192C95E --tests TestForTooMuchCloning
```
--
This is an automated message from the
weizijun commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2841464168
I added the change log and changed the initial size of the list to maxSize/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
weizijun commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2841473318
The failed TestHnswFloatVectorGraph.testRamUsageEstimate detail:
The seed is `-Dtests.seed=FEF2FF50C6824DEF`
```
Expected :1723096.0
Actual :3785393.0
jav
ChrisHegarty merged PR #14482:
URL: https://github.com/apache/lucene/pull/14482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
dweiss merged PR #14568:
URL: https://github.com/apache/lucene/pull/14568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
uschindler commented on code in PR #14591:
URL: https://github.com/apache/lucene/pull/14591#discussion_r2068232988
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -379,7 +379,9 @@ private static MMapIndexInputProvider
lookupProvider() {
// acce
gf2121 commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2841363044
Thanks for reporting @dweiss , i'll reopen.
Error assert:
https://github.com/apache/lucene/blob/2a5597e83b976cb11997285811d00565ff828ffc/lucene/core/src/test/org/apache/
mikemccand commented on PR #14178:
URL: https://github.com/apache/lucene/pull/14178#issuecomment-2841908460
> > but how do I know whichever I pick is optimized properly for my
particular env?
>
> These artifacts are created by the scripts in [this
folder](https://github.com/facebookr
thecoop commented on PR #14593:
URL: https://github.com/apache/lucene/pull/14593#issuecomment-2841419541
Is it actually worth keeping `SerialIOCountingDirectory` and
`TestDefaultCodecParallizesIO`? Those are _assuming_ specific loading behaviour
from the OS. Essentially, they're testing tha
uschindler commented on PR #14592:
URL: https://github.com/apache/lucene/pull/14592#issuecomment-2841495185
Hi,
I had a strange error when executing gradlew.bat the first time (sorry for
German message):
```
C:\Users\Uwe Schindler\Projects\lucene\lucene>gradlew clean
kein Hau
uschindler commented on code in PR #14592:
URL: https://github.com/apache/lucene/pull/14592#discussion_r2068371257
##
gradlew:
##
@@ -239,19 +200,59 @@ if "$cygwin" || "$msys" ; then
done
fi
+# START OF LUCENE CUSTOMIZATION
+
+# Add default JVM options here. You can also
uschindler commented on PR #14592:
URL: https://github.com/apache/lucene/pull/14592#issuecomment-2841524735
The error message means that it did not find a "main class" (German
"Hauptklasse" in the manifest attributes. This is really confusing to me. Maybe
I had an older wrapper JAR in my ch
mikemccand commented on PR #14009:
URL: https://github.com/apache/lucene/pull/14009#issuecomment-2841808722
I think this is a nice overall approach, adding a new
`RerankKnnFloatVectorQuery` that wraps a KNN query that used quantization to
get the initial results.
It's reminiscent of
dweiss commented on issue #14598:
URL: https://github.com/apache/lucene/issues/14598#issuecomment-2844174816
You're right - I'm paranoid.
I no longer use Windows on a regular basis but I can check on a vm later
today. Like I said - if nothing else works, we can still just make
Wrappe
dweiss commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2844181355
Uncanny resemblance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss opened a new pull request, #14599:
URL: https://github.com/apache/lucene/pull/14599
This isn't complete. There are some extra dependencies I'm not sure are
needed. But overall, the transition seems to be simple. Not that the "new"
library from Google is that well maintained (there is
dweiss closed pull request #14575: deps(java): bump
io.sgr:s2-geometry-library-java from 1.0.0 to 1.0.1
URL: https://github.com/apache/lucene/pull/14575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dweiss commented on code in PR #14599:
URL: https://github.com/apache/lucene/pull/14599#discussion_r2069539389
##
gradle/validation/dependencies.gradle:
##
@@ -28,7 +28,6 @@ allprojects {
def testConfigurations = project.configurations.matching {
it.name in [
- "a
dweiss commented on PR #14575:
URL: https://github.com/apache/lucene/pull/14575#issuecomment-2843461896
I'll try to switch, the initial draft is here: #14599 . There are some extra
deps I need to work on.
--
This is an automated message from the Apache Git Service.
To respond to the messa
dependabot[bot] commented on PR #14575:
URL: https://github.com/apache/lucene/pull/14575#issuecomment-2843462176
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, le
rmuir commented on issue #14598:
URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843482547
> I also thought about sha256sum check in gradlew - this spawns a process
but doesn't seem to be too bad...
Well i mean this is what shell scripts do. The current `gradlew` spa
rmuir closed issue #14490: update PRs for java dependencies
URL: https://github.com/apache/lucene/issues/14490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
rmuir commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2843493667
Thank you for solving this one @dweiss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dweiss commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843319741
> The hard part was more to understand and figure out how it works.
For the fun of it, I asked chatgpt to do it. Uwe - you're still much, much
better. :)
--
This is an automated
dweiss commented on issue #14598:
URL: https://github.com/apache/lucene/issues/14598#issuecomment-2843324990
I computed the current sha256 using command-line tools byte copy-pasted it
directly into Lucene sources. No magic.
I also thought about sha256sum check in gradlew - this spawns
dweiss commented on issue #14490:
URL: https://github.com/apache/lucene/issues/14490#issuecomment-2843328050
Should we close this, @rmuir ? Seems to be working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
rmuir commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843582527
lol the day we have an army of Uwe AIs, I feel like I've already seen this
[movie](https://www.youtube.com/watch?v=wN6F1l4cJ1Y)
--
This is an automated message from the Apache Git Servi
uschindler merged PR #14597:
URL: https://github.com/apache/lucene/pull/14597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843271854
> Looks great! It seems like ASM translated relatively well (in this case)
to the ClassFile API (much of it was just changing imports/methods to call but
looks very similar).
T
kkewwei commented on issue #14551:
URL: https://github.com/apache/lucene/issues/14551#issuecomment-2843657889
> Yeah -- that should be doable.
>
> My intuition is that we would need to keep the min/max values from the
`SortedNumericDocValuesSetQuery`, then apply skipping logic similar
dweiss commented on issue #14600:
URL: https://github.com/apache/lucene/issues/14600#issuecomment-2844219216
Depends on #14590.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
73 matches
Mail list logo
