thecoop commented on PR #14593: URL: https://github.com/apache/lucene/pull/14593#issuecomment-2841419541
Is it actually worth keeping `SerialIOCountingDirectory` and `TestDefaultCodecParallizesIO`? Those are _assuming_ specific loading behaviour from the OS. Essentially, they're testing that specific ReadAdvice are passed to a Directory, not that the pages are actually loaded as expected from disk. Especially since ReadAdvice is moving into being a MMapDirectory-specific thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
